Looks good, thanks!
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed All Stories
All Stories
All Stories
Oct 27 2022
Oct 27 2022
Build is green
This is a duplicate of the last update. I'm hoping that Arcanist
is now happy with my Git remote settings and will be able to push
the changes to the staging repo to be picked up by CI.
Harbormaster failed remote builds in B32612: Diff 31658 for D8759: model: Add payload to ExtID class!
Build has FAILED
Use a Git SHA-1 for the payload.
Oct 26 2022
Oct 26 2022
Build is green
anlambert committed rDWAPPSaee1c7ccb620: package.json: Pin cy2 to 2.1.0 to fix Jenkins jobs (authored by anlambert).
package.json: Pin cy2 to 2.1.0 to fix Jenkins jobs
anlambert committed rDWAPPS8db9fd3217a9: package.json: Upgrade dependencies (authored by anlambert).
package.json: Upgrade dependencies
anlambert committed rDWAPPSdf0bb952e96d: utils/exc: Ensure exception text is escaped in HTML error page (authored by anlambert).
utils/exc: Ensure exception text is escaped in HTML error page
utils/exc: Add typing
ardumont committed rDLS92d494261f26: lister: Make sure lister that requires github tokens can use it (authored by ardumont).
lister: Make sure lister that requires github tokens can use it
ardumont updated the test plan for D8783: lister: Make sure lister that requires github tokens can use it.
In D8783#228307, @anlambert wrote:Better like this indeed, could you add a test with a sample credentials config file to check github_session object has loaded credentials ?
ardumont updated the summary of D8783: lister: Make sure lister that requires github tokens can use it.
ardumont requested review of D8783: lister: Make sure lister that requires github tokens can use it.
anlambert updated the summary of D8782: templates/stage-cypress-tests: Prevent race condition with support file.
anlambert updated the summary of D8782: templates/stage-cypress-tests: Prevent race condition with support file.
anlambert requested review of D8782: templates/stage-cypress-tests: Prevent race condition with support file.
anlambert requested review of D8781: utils/exc: Ensure exception text is escaped in HTML error page.
vlorentz added inline comments to D8779: codemeta: Fix malformed dates that used to be allowed by the deposit.
vlorentz added inline comments to D8772: metadata_dictionary: Systematically check input URLs before adding to graph.
vlorentz placed T4663: ObjectFormatException: not enough values to unpack (expected 2, got 1) up for grabs.
LGTM
LGTM
anlambert accepted D8772: metadata_dictionary: Systematically check input URLs before adding to graph.
LGTM, added some nitpicks about typing as inline comments.
ardumont committed rDSNIPdb50b4777309: nixguix/analyze-result: Make --obj-type a multiple option (authored by ardumont).
nixguix/analyze-result: Make --obj-type a multiple option
With latest diffs, the filtering seems to sort properly the files and tarballs for the guix manifest:
ardumont closed T4662: staging: Deploy nixguix lister and loader, a subtask of T3781: Replace the Nixguix loader with a lister, as Invalid.
/me sighs
ardumont committed rDLS81688ca17e66: nixguix: Use content-disposition from http head request if provided (authored by ardumont).
nixguix: Use content-disposition from http head request if provided
vlorentz requested review of D8779: codemeta: Fix malformed dates that used to be allowed by the deposit.
In D8775#228206, @vlorentz wrote:Dulwich calls it "raw_string", so I went with that
Dulwich calls it "raw_string", so I went with that
vlorentz committed rDLDG44f70a704eee: converters: Replace '/' with '_' in directory entries (authored by vlorentz).
converters: Replace '/' with '_' in directory entries
vlorentz committed rDLDG4e501c7ba4ac: test_converters: Rename 'raw_manifest' to 'raw_string' (authored by vlorentz).
test_converters: Rename 'raw_manifest' to 'raw_string'
anlambert added a comment to T4548: Add a public API endpoint and documentation to trigger Save Code Now from webhook.
This is the POST request I received from Bitbucket when pushing commit to a sample repository.
swh-public-ci added a comment to D8774: nixguix: Use content-disposition from http head request if provided.
Build is green
LGTM
ardumont committed rDLS026fea21da49: nixguix: Deal with edge case url with version instead of extension (authored by ardumont).
nixguix: Deal with edge case url with version instead of extension
ardumont added inline comments to D8774: nixguix: Use content-disposition from http head request if provided.
ardumont added inline comments to D8774: nixguix: Use content-disposition from http head request if provided.
ardumont updated the diff for D8774: nixguix: Use content-disposition from http head request if provided.
Adapt according to last review
vlorentz updated the task description for T4661: Some Git loader tasks for gitlab.com origins have "lister_name: github" in their arguments.
vlorentz renamed T4661: Some Git loader tasks for gitlab.com origins have "lister_name: github" in their arguments from InvalidOrigin: netloc should be 'github.com', not 'gitlab.com' to Some Git loader tasks for gitlab.com origins have "lister_name: github" in their arguments.
anlambert added a comment to T4548: Add a public API endpoint and documentation to trigger Save Code Now from webhook.
Regarding JSON payload sent by SourceForge, we cannot guess the visit type (git, svn, or hg) from it so we will have to query the project endpoint from SourceForge REST API to get it.
vlorentz updated the task description for T4661: Some Git loader tasks for gitlab.com origins have "lister_name: github" in their arguments.
swh-public-ci added a comment to D8773: nixguix: Deal with edge case url with version instead of extension.
Build is green
anlambert added a comment to T4548: Add a public API endpoint and documentation to trigger Save Code Now from webhook.
In T4548#97884, @vlorentz wrote:In T4548#97818, @anlambert wrote:Based on the received HTTP POST request headers, we should be able to determine which type of forge sent us the request and then
extract repository URL and visit type from the JSON payload in order to create a Save Code Now request when new commits are pushed.We can do that and it certainly works, but once we start allowing a single endpoint for all forges, we cannot go back.
What about a separate path for each forge type, so we have more flexibility later on? eg. to route/"cache" requests from some forges differently directly in Varnish
ardumont updated the diff for D8773: nixguix: Deal with edge case url with version instead of extension.
Rebase (commit id mismatch locally and in the diff, don't recall what changed)
-> must be the commit message.
olasd committed rDSNIP8fe0cbf957b5: takedowns: Transparently compute ""origin SWHIDs"" (authored by olasd).
takedowns: Transparently compute ""origin SWHIDs""
anlambert added inline comments to D8774: nixguix: Use content-disposition from http head request if provided.
I am not a big fan either of adding more tarball detection heuristics but after quickly hacking on the code, it seems this is the only way to handle these edge case URLS (plus there is some cases when even analyzing HTTP headers cannot help to detect if the URL targets a tarball P1512). So let's land this and move on in deploying and testing that lister on staging.
vlorentz added a comment to T4548: Add a public API endpoint and documentation to trigger Save Code Now from webhook.
In T4548#97818, @anlambert wrote:Based on the received HTTP POST request headers, we should be able to determine which type of forge sent us the request and then
extract repository URL and visit type from the JSON payload in order to create a Save Code Now request when new commits are pushed.
vlorentz added a parent task for T4659: Fix all crashes of the git loader caused by malformed git objects: T3653: Stabilize loader git.
vlorentz renamed T4659: Fix all crashes of the git loader caused by malformed git objects from Fix all crashes of the git loader to Fix all crashes of the git loader caused by malformed git objects.
vlorentz added a subtask for T4659: Fix all crashes of the git loader caused by malformed git objects: Unknown Object (Maniphest Task).