HomeSoftware Heritage

lister: Make sure lister that requires github tokens can use it

Description

lister: Make sure lister that requires github tokens can use it

Deploying the nixguix lister, I realized that even though the credentials configuration
is properly set for all listers, the listers actually requiring github origin
canonicalization do not have access to the github credentials. It's lost during the
constructor to only focus on the lister's credentials. Which currently translates to
listers being rate-limited.

This commit fixes it by pushing the self.github_session instantiation in the constructor
when the lister explicitely requires the github session. Hence lifting the rate limit
for maven, packagist, nixguix, and github listers.

Related to infra/sysadm-environment#4655

Details

Provenance
ardumontAuthored on Oct 26 2022, 5:23 PM
ardumontPushed on Oct 26 2022, 5:38 PM
Differential Revision
D8783: lister: Make sure lister that requires github tokens can use it
Parents
rDLS81688ca17e66: nixguix: Use content-disposition from http head request if provided
Branches
Unknown
Tags
Unknown
References
tag: v4.1.1
Build Status
Buildable 32605
Build 51077: test-and-buildJenkins console · Jenkins