Build is green

rebase

Build is green

Build is green

typos

fix typos as reported by anlambert

Build is green

Add the missing docstring entry

In D8751#227397, @anlambert wrote:

Looks good to me , just noticed some remaining typos: one in code and another in commit message (s/sctructure/structure).

fwiw, I've iterated a bit over @zimoun's code and pushed it into the snippets repository
(see commits above and their commit description message). It's also able to deal with
git, hg and svn trees (ignoring their respective top metadata folder .git, .svn, ...
without impacting the performance).

Looks good to me , just noticed some remaining typos: one in code and another in commit message (s/sctructure/structure).

I've relaunched the latest version of the migrate_extrinsic_metadata script on getty...

Looks good to me, thanks !

Build is green

Manage case where author or last_update is empty

Build is green

Add missing test

@Alphare, fyi I improved the rubygems lister in that commit in order to gather all artifacts related to a gem and send these info to the loader as extra arguments.
Below is an example of the lister output for a gem:

ListedOrigin(
    url="https://rubygems.org/gems/haar_joke",
    visit_type="rubygems",
    last_update=iso8601.parse_date("2016-11-05T00:00:00+00:00"),
    extra_loader_arguments={
        "artifacts": [
            {
                "url": "https://rubygems.org/downloads/haar_joke-0.0.2.gem",
                "length": 8704,
                "version": "0.0.2",
                "filename": "haar_joke-0.0.2.gem",
                "checksums": {
                    "sha256": "85a8cf5f41890e9605265eeebfe9e99aa0350a01a3c799f9f55a0615a31a2f5f"
                },
            },
            {
                "url": "https://rubygems.org/downloads/haar_joke-0.0.1.gem",
                "length": 8704,
                "version": "0.0.1",
                "filename": "haar_joke-0.0.1.gem",
                "checksums": {
                    "sha256": "a2ee7052fb8ffcfc4ec0fdb77fae9a36e473f859af196a36870a0f386b5ab55e"
                },
            },
        ],
        "rubygem_metadata": [
            {
                "date": "2016-11-05T00:00:00+00:00",
                "authors": "Gemma Gotch",
                "version": "0.0.2",
                "extrinsic_metadata_url": "https://rubygems.org/api/v2/rubygems/haar_joke/versions/0.0.2.json",
            },
            {
                "date": "2016-07-23T00:00:00+00:00",
                "authors": "Gemma Gotch",
                "version": "0.0.1",
                "extrinsic_metadata_url": "https://rubygems.org/api/v2/rubygems/haar_joke/versions/0.0.1.json",
            },
        ],
    },
}

It enables to improve the scheduling of loading tasks for Ruby gems (by providing last_update value to ListedOrigin)
and it will save you of couple of calls to RubyGems Web API in the loader to fetch the list of versions for a gem.
So loader implementation must be adapted to use these new arguments.

In D8697#227324, @ardumont wrote:

I don't see the difference comparing the master build or the diff build times but wny not ;)

Woohoo, green tests!

In D8705#227333, @ardumont wrote:

...ah... maybe, it's for other tests in another repository, right?

@vlorentz mentions that this is missing a docstring change

Yeah, I'm a bit surprised too that this would decrease overall test times, and seems like a latent bug, but this at least doesn't seem to /increase/ test times in this module, so it's probably fine?

If it's for test speedup only, don't you want to keep the actual behavior instead?
That is, make the auto_flush be False by default, and then you explicitely set it up to True in the calling tests.

I believe that auto_flush=True is the current default, so the diff does what you're asking :-)

I'd be keen on having a warning, at least when we __del__ the object and some deliveries are still pending, because even if not perfect, that'd be the sign of a bug.

In D8705#227328, @ardumont wrote:

If it's for test speedup only, don't you want to keep the actual behavior instead?
That is, make the auto_flush be False by default, and then you explicitely set it up to True in the calling tests.

If it's for test speedup only, don't you want to keep the actual behavior instead?
That is, make the auto_flush be False by default, and then you explicitely set it up to True in the calling tests.

shouldn't this fix come with a test of some sort?

In D8748#227318, @douardda wrote:

it's unclear to me whether this actually implements the iteration protocol described in the API doc (https://learn.microsoft.com/en-us/nuget/api/catalog-resource#iterating-over-catalog-items) or not.

I believe the commit title lacks a verb, doesn't it? ("conda: Yield listed origins after all artifacts in a page are processed" or something similar?)

it's unclear to me whether this actually implements the iteration protocol described in the API doc (https://learn.microsoft.com/en-us/nuget/api/catalog-resource#iterating-over-catalog-items) or not.

I don't see the difference comparing the master build or the diff build times but wny not ;)

This task has been migrated to GitLab.

This task has been migrated to GitLab.

This task has been migrated to GitLab.

This task has been migrated to GitLab.

This task has been migrated to GitLab.

This task has been migrated to GitLab.

This task has been migrated to GitLab.

This task has been migrated to GitLab.

This task has been migrated to GitLab.

This task has been migrated to GitLab.

This task has been migrated to GitLab.