- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Advanced Search
Aug 23 2022
Aug 22 2022
Looks good to me.
Looks great, thanks ! I think you could add the following improvements:
- Declare the categories using constants in apidoc.py and use them in views implementation
- Use keyword parameter when setting category for better readability
- Should a category name starts with an uppercase letter ?
Aug 19 2022
This is deployed so I am closing this.
Nice ! Did you consider adding a check for term validity in the namespace ? I see that the JSONLD file for codemeta is present in this repository, should be easy to parse and extract the terms set no ?
Aug 18 2022
Update commit message
Looks good to me.
Use PIP variable to execute pip.
I could accept the diff but I think another team member should also review it and gives his opinion about the raw content data retrieval and integration in GraphQL responses.
Aug 17 2022
Rebase
Looks good to me.
Looks good to me.
Aug 16 2022
In D8246#214439, @vlorentz wrote:Shouldn't the migration update existing DENIED values to UNSUCCESSFUL?
Looks good to me but we should add a new test in that file checking the migration can be successfully applied.
I would go for that scenario: before applying migration, check the unsucessfull status cannot be set, after applying migration, check the status can be set.
Using either one of these queries will depend on what the query planner thinks either index (id or last_activity_at is worth). This seems like a good area for creating some poorly controlled load on the server side (and an eventual emergency throttling of our requests), so I'd really like us to confirm with upstream that this combined filtering + keyset pagination is intended behavior, before we commit to it.
Looks good to me but still not really convinced by the match field in search results, we should only rely on the result ordering from the search backend imho.