Page MenuHomeSoftware Heritage
Feed Advanced Search

Aug 23 2022

anlambert committed rDWAPPS57c6590017b7: Remove no longer needed swh/web/common folder (authored by anlambert).
Remove no longer needed swh/web/common folder
Aug 23 2022, 1:13 PM
anlambert requested review of D8290: auth/utils: Fix circular import triggered by sphinx autodoc.
Aug 23 2022, 12:16 PM

Aug 22 2022

anlambert accepted D8260: Integrate with swh-search and add a search entrypoint.

Looks good to me.

Aug 22 2022, 4:26 PM
anlambert added inline comments to D8260: Integrate with swh-search and add a search entrypoint.
Aug 22 2022, 4:14 PM
anlambert closed D8280: sql/Makefile: Fix swh-scheduler SQL file paths.
Aug 22 2022, 3:26 PM
anlambert committed rDSCH7cfaa986c22c: sql/Makefile: Fix swh-scheduler SQL file paths (authored by anlambert).
sql/Makefile: Fix swh-scheduler SQL file paths
Aug 22 2022, 3:26 PM
anlambert created P1433 (An Untitled Masterwork).
Aug 22 2022, 3:25 PM
anlambert requested review of D8280: sql/Makefile: Fix swh-scheduler SQL file paths.
Aug 22 2022, 3:24 PM
anlambert added a comment to D8258: Split endpoint table into categories.

Looks great, thanks ! I think you could add the following improvements:

  • Declare the categories using constants in apidoc.py and use them in views implementation
  • Use keyword parameter when setting category for better readability
  • Should a category name starts with an uppercase letter ?
Aug 22 2022, 11:31 AM
anlambert closed D8261: jobs/swh-environment: Execute make check for each swh module.
Aug 22 2022, 11:22 AM
anlambert committed rCJSWHffcd0feb2846: jobs/swh-environment: Execute make check for each swh module (authored by anlambert).
jobs/swh-environment: Execute make check for each swh module
Aug 22 2022, 11:22 AM

Aug 19 2022

anlambert closed D8273: Rename swh.web.common module to swh.web.utils.
Aug 19 2022, 6:22 PM
anlambert closed D8272: Remove no longer needed admin folder.
Aug 19 2022, 6:22 PM
anlambert committed rDWAPPS1975f2b38b6e: Rename swh.web.common module to swh.web.utils (authored by anlambert).
Rename swh.web.common module to swh.web.utils
Aug 19 2022, 6:22 PM
anlambert committed rDWAPPS1f465cfe6a02: Remove no longer needed admin folder (authored by anlambert).
Remove no longer needed admin folder
Aug 19 2022, 6:22 PM
anlambert closed D8271: deposit: Move administration view into a dedicated django application.
Aug 19 2022, 6:22 PM
anlambert committed rDWAPPSbde7e0f1c8ab: deposit: Move administration view into a dedicated django application (authored by anlambert).
deposit: Move administration view into a dedicated django application
Aug 19 2022, 6:22 PM
anlambert requested review of D8271: deposit: Move administration view into a dedicated django application.
Aug 19 2022, 5:50 PM
anlambert requested review of D8273: Rename swh.web.common module to swh.web.utils.
Aug 19 2022, 5:49 PM
anlambert requested review of D8272: Remove no longer needed admin folder.
Aug 19 2022, 5:48 PM
anlambert added a revision to T4398: Create one django application for each webapp feature: D8273: Rename swh.web.common module to swh.web.utils.
Aug 19 2022, 5:32 PM · Web app
anlambert added a revision to T4398: Create one django application for each webapp feature: D8272: Remove no longer needed admin folder.
Aug 19 2022, 5:31 PM · Web app
anlambert added a revision to T4398: Create one django application for each webapp feature: D8271: deposit: Move administration view into a dedicated django application.
Aug 19 2022, 5:30 PM · Web app
anlambert closed D8270: auth: Move related templates, views and urls into application folder.
Aug 19 2022, 5:29 PM
anlambert closed D8269: api: Move templates into django application folder.
Aug 19 2022, 5:29 PM
anlambert closed D8268: add_forge_now: Move all features into a single django application.
Aug 19 2022, 5:29 PM
anlambert committed rDWAPPSf135b35ee569: auth: Move related templates, views and urls into application folder (authored by anlambert).
auth: Move related templates, views and urls into application folder
Aug 19 2022, 5:29 PM
anlambert committed rDWAPPSd1cb35483689: api: Move templates into django application folder (authored by anlambert).
api: Move templates into django application folder
Aug 19 2022, 5:29 PM
anlambert committed rDWAPPS9808e3eb262b: add_forge_now: Move all features into a single django application (authored by anlambert).
add_forge_now: Move all features into a single django application
Aug 19 2022, 5:29 PM
anlambert closed D8267: save_code_now: Move feature into a dedicated django app.
Aug 19 2022, 5:29 PM
anlambert closed D8266: mailmap: Move feature into a dedicated django application.
Aug 19 2022, 5:29 PM
anlambert committed rDWAPPSdc2ecba5b6ef: save_code_now: Move feature into a dedicated django app (authored by anlambert).
save_code_now: Move feature into a dedicated django app
Aug 19 2022, 5:29 PM
anlambert committed rDWAPPSf58181edb8e8: mailmap: Move feature into a dedicated django application (authored by anlambert).
mailmap: Move feature into a dedicated django application
Aug 19 2022, 5:29 PM
anlambert closed D8265: Update swh-web django applications configuration and setup.
Aug 19 2022, 5:29 PM
anlambert committed rDWAPPS0306c23d0378: Update swh-web django applications configuration and setup (authored by anlambert).
Update swh-web django applications configuration and setup
Aug 19 2022, 5:29 PM
anlambert closed D8262: pre-commit: Fix codespell false positives.
Aug 19 2022, 5:28 PM
anlambert committed rDSCRUB630001ce7b60: pre-commit: Fix codespell false positives (authored by anlambert).
pre-commit: Fix codespell false positives
Aug 19 2022, 5:28 PM
anlambert added inline comments to D8265: Update swh-web django applications configuration and setup.
Aug 19 2022, 5:17 PM
anlambert added inline comments to D8265: Update swh-web django applications configuration and setup.
Aug 19 2022, 5:16 PM
anlambert requested review of D8269: api: Move templates into django application folder.
Aug 19 2022, 4:50 PM
anlambert requested review of D8270: auth: Move related templates, views and urls into application folder.
Aug 19 2022, 4:50 PM
anlambert requested review of D8268: add_forge_now: Move all features into a single django application.
Aug 19 2022, 4:48 PM
anlambert added a revision to T4398: Create one django application for each webapp feature: D8270: auth: Move related templates, views and urls into application folder.
Aug 19 2022, 3:44 PM · Web app
anlambert added a revision to T4398: Create one django application for each webapp feature: D8269: api: Move templates into django application folder.
Aug 19 2022, 3:43 PM · Web app
anlambert added a revision to T4398: Create one django application for each webapp feature: D8268: add_forge_now: Move all features into a single django application.
Aug 19 2022, 3:42 PM · Web app
anlambert requested review of D8267: save_code_now: Move feature into a dedicated django app.
Aug 19 2022, 3:35 PM
anlambert closed T4424: Update for add forge now email template to forge admin as Resolved.

This is deployed so I am closing this.

Aug 19 2022, 3:22 PM · Add Forge Now
anlambert renamed T4398: Create one django application for each webapp feature from Create one django application per webapp features to Create one django application for each webapp feature.
Aug 19 2022, 3:21 PM · Web app
anlambert requested review of D8266: mailmap: Move feature into a dedicated django application.
Aug 19 2022, 3:01 PM
anlambert requested review of D8265: Update swh-web django applications configuration and setup.
Aug 19 2022, 2:59 PM
anlambert added a revision to T4398: Create one django application for each webapp feature: D8267: save_code_now: Move feature into a dedicated django app.
Aug 19 2022, 2:43 PM · Web app
anlambert added a revision to T4398: Create one django application for each webapp feature: D8266: mailmap: Move feature into a dedicated django application.
Aug 19 2022, 2:43 PM · Web app
anlambert added a revision to T4398: Create one django application for each webapp feature: D8265: Update swh-web django applications configuration and setup.
Aug 19 2022, 2:42 PM · Web app
anlambert accepted D8263: metadata_dictionary: Simplify code using rdflib-style namespace classes.

Nice ! Did you consider adding a check for term validity in the namespace ? I see that the JSONLD file for codemeta is present in this repository, should be easy to parse and extract the terms set no ?

Aug 19 2022, 12:02 PM
anlambert requested review of D8262: pre-commit: Fix codespell false positives.
Aug 19 2022, 11:35 AM
anlambert committed rDCOREc232fb093e94: github/tests/test_pytest_plugin: Fix imports ordering reported by isort (authored by anlambert).
github/tests/test_pytest_plugin: Fix imports ordering reported by isort
Aug 19 2022, 11:33 AM
anlambert requested review of D8261: jobs/swh-environment: Execute make check for each swh module.
Aug 19 2022, 11:25 AM

Aug 18 2022

anlambert closed D8256: add_forge_now: Deduplicate request status transitions in js code.
Aug 18 2022, 4:42 PM
anlambert committed rDWAPPSd72784ac6514: add_forge_now: Deduplicate request status transitions in js code (authored by anlambert).
add_forge_now: Deduplicate request status transitions in js code
Aug 18 2022, 4:42 PM
anlambert retitled D8256: add_forge_now: Deduplicate request status transitions in js code from add_forge_now: Do not duplicate request status transitions in js code to add_forge_now: Deduplicate request status transitions in js code.
Aug 18 2022, 4:41 PM
anlambert updated the diff for D8256: add_forge_now: Deduplicate request status transitions in js code.

Update commit message

Aug 18 2022, 4:24 PM
anlambert requested review of D8256: add_forge_now: Deduplicate request status transitions in js code.
Aug 18 2022, 4:15 PM
anlambert accepted D8255: Add functional tests for the revision object.
Aug 18 2022, 3:52 PM
anlambert committed rDWAPPS568eb5d7ac0b: assets/add_forge_now: Fix trailing whitespaces in email template (authored by anlambert).
assets/add_forge_now: Fix trailing whitespaces in email template
Aug 18 2022, 2:48 PM
anlambert accepted D8239: Add missing fields to the Content object.

Looks good to me.

Aug 18 2022, 2:10 PM
anlambert created P1431 (An Untitled Masterwork).
Aug 18 2022, 1:44 PM
anlambert closed D8249: bin/install: Temporarily pin pip to < 21.3.
Aug 18 2022, 11:47 AM
anlambert committed rDENV7eaf8942fb58: bin/install: Temporarily pin pip to < 21.3 (authored by anlambert).
bin/install: Temporarily pin pip to < 21.3
Aug 18 2022, 11:47 AM
anlambert updated the diff for D8249: bin/install: Temporarily pin pip to < 21.3.

Use PIP variable to execute pip.

Aug 18 2022, 11:46 AM
anlambert added inline comments to D8249: bin/install: Temporarily pin pip to < 21.3.
Aug 18 2022, 11:44 AM
anlambert committed rDWAPPSb8cfbc2f1b08: package.json: Upgrade dependencies (authored by anlambert).
package.json: Upgrade dependencies
Aug 18 2022, 11:32 AM
anlambert closed D8247: add_forge_now: Add client-side and server-side forge URL validation.
Aug 18 2022, 11:32 AM
anlambert committed rDWAPPS39abda7135c0: add_forge_now: Add client-side and server-side forge URL validation (authored by anlambert).
add_forge_now: Add client-side and server-side forge URL validation
Aug 18 2022, 11:32 AM
anlambert added a comment to D8239: Add missing fields to the Content object.

I could accept the diff but I think another team member should also review it and gives his opinion about the raw content data retrieval and integration in GraphQL responses.

Aug 18 2022, 11:06 AM
anlambert added inline comments to D8249: bin/install: Temporarily pin pip to < 21.3.
Aug 18 2022, 10:51 AM

Aug 17 2022

anlambert updated the diff for D8247: add_forge_now: Add client-side and server-side forge URL validation.

Rebase

Aug 17 2022, 7:32 PM
anlambert requested review of D8249: bin/install: Temporarily pin pip to < 21.3.
Aug 17 2022, 5:33 PM
anlambert accepted D8248: Add checking and reporting of references to missing objects.

Looks good to me.

Aug 17 2022, 4:31 PM
anlambert accepted D8246: rename add forge now status from 'denied' to 'unsuccessful'.

Looks good to me.

Aug 17 2022, 4:20 PM
anlambert added inline comments to D8246: rename add forge now status from 'denied' to 'unsuccessful'.
Aug 17 2022, 4:02 PM
anlambert created P1428 (An Untitled Masterwork).
Aug 17 2022, 2:58 PM
anlambert added inline comments to D8239: Add missing fields to the Content object.
Aug 17 2022, 2:13 PM
anlambert created P1426 (An Untitled Masterwork).
Aug 17 2022, 2:02 PM
anlambert added inline comments to D8239: Add missing fields to the Content object.
Aug 17 2022, 1:40 PM
anlambert added inline comments to D8247: add_forge_now: Add client-side and server-side forge URL validation.
Aug 17 2022, 1:33 PM
anlambert requested review of D8247: add_forge_now: Add client-side and server-side forge URL validation.
Aug 17 2022, 12:26 PM
anlambert added inline comments to D8246: rename add forge now status from 'denied' to 'unsuccessful'.
Aug 17 2022, 10:50 AM
anlambert accepted D8245: Add missing functional tests for resolveSwhid.
Aug 17 2022, 10:48 AM

Aug 16 2022

anlambert added a comment to D8246: rename add forge now status from 'denied' to 'unsuccessful'.

Shouldn't the migration update existing DENIED values to UNSUCCESSFUL?

Aug 16 2022, 4:42 PM
anlambert requested changes to D8246: rename add forge now status from 'denied' to 'unsuccessful'.

Looks good to me but we should add a new test in that file checking the migration can be successfully applied.
I would go for that scenario: before applying migration, check the unsucessfull status cannot be set, after applying migration, check the status can be set.

Aug 16 2022, 4:38 PM
anlambert added a comment to D8240: gitlab: Improve incremental listing.

Using either one of these queries will depend on what the query planner thinks either index (id or last_activity_at is worth). This seems like a good area for creating some poorly controlled load on the server side (and an eventual emergency throttling of our requests), so I'd really like us to confirm with upstream that this combined filtering + keyset pagination is intended behavior, before we commit to it.

Aug 16 2022, 3:58 PM
anlambert accepted D8231: Add the possibility to search using a SWHID.

Looks good to me but still not really convinced by the match field in search results, we should only rely on the result ordering from the search backend imho.

Aug 16 2022, 11:29 AM
anlambert closed D8244: add_forge_now: Add last_{moderator, modified_date} fields to Request.
Aug 16 2022, 11:23 AM
anlambert committed rDWAPPS27e448ca12f5: add_forge_now: Add last_{moderator, modified_date} fields to Request (authored by anlambert).
add_forge_now: Add last_{moderator, modified_date} fields to Request
Aug 16 2022, 11:23 AM

Aug 12 2022

anlambert requested review of D8244: add_forge_now: Add last_{moderator, modified_date} fields to Request.
Aug 12 2022, 6:34 PM
anlambert updated the summary of D8240: gitlab: Improve incremental listing.
Aug 12 2022, 2:45 PM
anlambert requested review of D8240: gitlab: Improve incremental listing.
Aug 12 2022, 2:36 PM
anlambert closed D8241: Makefile.sphinx: Exclude root conftest.py from apidoc.
Aug 12 2022, 2:31 PM
anlambert committed rDDOC480ec26a4f53: Makefile.sphinx: Exclude root conftest.py from apidoc (authored by anlambert).
Makefile.sphinx: Exclude root conftest.py from apidoc
Aug 12 2022, 2:31 PM
anlambert requested review of D8241: Makefile.sphinx: Exclude root conftest.py from apidoc.
Aug 12 2022, 2:27 PM