Page MenuHomeSoftware Heritage
Differential D8247

add_forge_now: Add client-side and server-side forge URL validation
ClosedPublic
Actions

Authored by anlambert on Aug 16 2022, 5:09 PM.

Details

Reviewers
jayeshv
Group Reviewers
Reviewers
Commits
rDWAPPS39abda7135c0: add_forge_now: Add client-side and server-side forge URL validation
Summary

This will prevent submission of add forge now requests with invalid
forge URLs from the Web UI and the Web API.

Diff Detail

Repository
rDWAPPS Web applications
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

anlambert created this revision.Aug 16 2022, 5:09 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptAug 16 2022, 5:09 PM
swh-public-ci added a comment.Aug 16 2022, 5:26 PM

Build has FAILED

Patch application report for D8247 (id=29764)

Rebasing onto 27e448ca12...

Current branch diff-target is up to date.
Changes applied before test
commit 7cd88d370c860cfe9ee77b1248843d32dd9eac21
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Tue Aug 16 16:14:10 2022 +0200

    add_forge_now: Add client-side and server-side forge URL validation
    
    This will prevent submission of add forge now requests with invalid
    forge URLs from the Web UI and the Web API.

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1966/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1966/console

Harbormaster returned this revision to the author for changes because remote builds failed.Aug 16 2022, 5:26 PM
Harbormaster failed remote builds in B30816: Diff 29764!
swh-public-ci added a comment.Aug 17 2022, 11:04 AM

Build has FAILED

Patch application report for D8247 (id=29764)

Rebasing onto 27e448ca12...

Current branch diff-target is up to date.
Changes applied before test
commit 7cd88d370c860cfe9ee77b1248843d32dd9eac21
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Tue Aug 16 16:14:10 2022 +0200

    add_forge_now: Add client-side and server-side forge URL validation
    
    This will prevent submission of add forge now requests with invalid
    forge URLs from the Web UI and the Web API.

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1969/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1969/console

anlambert updated this revision to Diff 29780.Aug 17 2022, 11:45 AM

Fix cypress test

swh-public-ci added a comment.Aug 17 2022, 12:00 PM

Build has FAILED

Patch application report for D8247 (id=29780)

Rebasing onto 27e448ca12...

Current branch diff-target is up to date.
Changes applied before test
commit 49edb72083a0136f04be1d9de2235daaa7352600
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Tue Aug 16 16:14:10 2022 +0200

    add_forge_now: Add client-side and server-side forge URL validation
    
    This will prevent submission of add forge now requests with invalid
    forge URLs from the Web UI and the Web API.

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1972/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1972/console

Harbormaster returned this revision to the author for changes because remote builds failed.Aug 17 2022, 12:00 PM
Harbormaster failed remote builds in B30832: Diff 29780!
swh-public-ci added a comment.Aug 17 2022, 12:26 PM

Build is green

Patch application report for D8247 (id=29780)

Rebasing onto 27e448ca12...

Current branch diff-target is up to date.
Changes applied before test
commit 49edb72083a0136f04be1d9de2235daaa7352600
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Tue Aug 16 16:14:10 2022 +0200

    add_forge_now: Add client-side and server-side forge URL validation
    
    This will prevent submission of add forge now requests with invalid
    forge URLs from the Web UI and the Web API.

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1973/ for more details.

Harbormaster completed remote builds in B30832: Diff 29780.Aug 17 2022, 12:26 PM
anlambert requested review of this revision.Aug 17 2022, 12:26 PM
jayeshv added a subscriber: jayeshv.Aug 17 2022, 1:09 PM
jayeshv added inline comments.
swh/web/templates/add_forge_now/creation_form.html
48

Can we avoid this validation using URL field in a Django form? That seems to support custom validation as well.

anlambert added inline comments.Aug 17 2022, 1:32 PM
swh/web/templates/add_forge_now/creation_form.html
48

At the moment we cannot as we do not use django ModelForm the right way (we handled the HTML form ourself instead of "simply" including the django form in the template and we send form data to server through js).
It is planned to use pure django forms later in swh-web refactoring whenever it is possible.

Proceeding like this also enables to save an HTTP request to validate form data.

jayeshv accepted this revision.Aug 17 2022, 1:41 PM
This revision is now accepted and ready to land.Aug 17 2022, 1:41 PM
anlambert updated this revision to Diff 29792.Aug 17 2022, 7:32 PM

Rebase

swh-public-ci added a comment.Aug 17 2022, 7:47 PM

Build is green

Patch application report for D8247 (id=29792)

Rebasing onto b6ddca59dd...

Current branch diff-target is up to date.
Changes applied before test
commit 39abda7135c0203177ee35b2d01e0c5befb7bf1f
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Tue Aug 16 16:14:10 2022 +0200

    add_forge_now: Add client-side and server-side forge URL validation
    
    This will prevent submission of add forge now requests with invalid
    forge URLs from the Web UI and the Web API.

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1976/ for more details.

Harbormaster completed remote builds in B30844: Diff 29792.Aug 17 2022, 7:47 PM
Closed by commit rDWAPPS39abda7135c0: add_forge_now: Add client-side and server-side forge URL validation (authored by anlambert). · Explain WhyAug 18 2022, 11:32 AM
This revision was automatically updated to reflect the committed changes.
anlambert added a commit: rDWAPPS39abda7135c0: add_forge_now: Add client-side and server-side forge URL validation.

Revision Contents
Changeset List

PathSize
assets/
src/
bundles/
add_forge/
16 lines
save/
26 lines
utils/
22 lines
cypress/
e2e/
24 lines
swh/
web/
add_forge_now/
migrations/
18 lines
2 lines
templates/
add_forge_now/
2 lines
tests/
add_forge_now/
39 lines
api/
views/
22 lines

Diff 29799

View Options

assets/src/bundles/add_forge/create-request.js

Loading...
View Options

assets/src/bundles/save/index.js

Loading...
View Options

assets/src/utils/functions.js

Loading...
View Options

cypress/e2e/add-forge-now-request-create.cy.js

Loading...
View Options

swh/web/add_forge_now/migrations/0008_turn_request_forge_url_into_url_field.py

Loading...
View Options

swh/web/add_forge_now/models.py

Loading...
View Options

swh/web/templates/add_forge_now/creation_form.html

Loading...
View Options

swh/web/tests/add_forge_now/test_migration.py

Loading...
View Options

swh/web/tests/api/views/test_add_forge_now.py

Loading...
About · Developer information · Legal