Update swh-web django applications configuration and setup
ClosedPublic
Actions

Authored by anlambert on Aug 19 2022, 2:42 PM.

Details

Reviewers

vlorentz

Group Reviewers

Reviewers

Maniphest Tasks

T4398: Create one django application for each webapp feature

Commits

rDWAPPS0306c23d0378: Update swh-web django applications configuration and setup

Summary

Towards reorganizing swh-web features into multiple django applications,
introduce the following changes regarding their settings:

Declare a fixed set of base django apps and enable to add extra ones through configuration

Add application templates directory to django templates search paths

Automatically register URLs of selected django applications

Inject swh-web django app names in templates to check a feature is enabled

Diffs that follow mainly move files around and perform renaming to isolate
swh-web features into dedicated django applications.

Related to T4398

Diff Detail

Repository

rDWAPPS Web applications

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

anlambert created this revision.Aug 19 2022, 2:42 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptAug 19 2022, 2:42 PM

anlambert added a child revision: D8266: mailmap: Move feature into a dedicated django application.Aug 19 2022, 2:43 PM

Build is green

Patch application report for D8265 (id=29854)

Rebasing onto d72784ac65...

Current branch diff-target is up to date.

Changes applied before test

commit 0306c23d03783a1e5fdc898e76444dd2c534fbea
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Mon Jul 18 15:17:38 2022 +0200

    Update swh-web django applications configuration and setup
    
    Towards reorganizing swh-web features into multiple django applications,
    introduce the following changes regarding their settings:
    
    - Declare a fixed set of base django apps and enable to add extra ones
      through configuration
    
    - Add application templates directory to django templates search paths
    
    - Automatically register URLs of selected django applications
    
    - Inject swh-web django app names in templates to check a feature is enabled
    
    Related to T4398

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1980/ for more details.

Harbormaster completed remote builds in B30907: Diff 29854.Aug 19 2022, 2:59 PM

anlambert requested review of this revision.Aug 19 2022, 2:59 PM

vlorentz added a subscriber: vlorentz.Aug 19 2022, 5:10 PM

vlorentz added inline comments.

swh/web/tests/conftest.py
1209–1217	how come you need that in tests?

anlambert added inline comments.Aug 19 2022, 5:16 PM

swh/web/tests/conftest.py
1209–1217	That small hack is required for the new tests in following diffs to work correctly. In those tests, I removed a django application from django settings by updating the `SWH_DJANGO_APPS` list dynamically. As view URLs set depends on the declared applications, the django URL cache needs to be cleared and repopulated to match the configuration. Then I can check that URLs of an application are not registered if the application is not declared in settings.