bin/install: Temporarily pin pip to < 21.3
ClosedPublic
Actions

Authored by anlambert on Aug 17 2022, 5:33 PM.

Details

Reviewers

vlorentz

Group Reviewers

Reviewers

Commits

rDENV7eaf8942fb58: bin/install: Temporarily pin pip to < 21.3

Summary

pip 21.3 added support to editable installs for projects that have a
pyproject.toml and use a build backend that supports PEP 660, but mypy
does not detect yet such editable installs and following errors are
reported when type checking swh modules:

Cannot find implementation or library stub for module named swh...

So temporarily pin pip until mypy properly supports PEP 660 editable
installs (see https://github.com/python/mypy/issues/12313).

Diff Detail

Repository

rDENV Development environment

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

anlambert created this revision.Aug 17 2022, 5:33 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptAug 17 2022, 5:33 PM

anlambert requested review of this revision.Aug 17 2022, 5:33 PM

Harbormaster completed remote builds in B30843: Diff 29791.Aug 17 2022, 5:33 PM

vlorentz added a subscriber: vlorentz.Aug 18 2022, 9:52 AM

vlorentz added inline comments.

bin/install
17	Shouldn't it be `$PIP install "pip<21.3"`?

vlorentz accepted this revision.Aug 18 2022, 10:02 AM

This revision is now accepted and ready to land.Aug 18 2022, 10:02 AM

anlambert added inline comments.Aug 18 2022, 10:51 AM

bin/install
17	Ah right, I am also wondering if pinning `setuptools` to < 64 (before PEP 660 support) is not the right way to go instead of pinning pip, need to check.