Page MenuHomeSoftware Heritage
Feed Advanced Search

Jun 13 2022

anlambert added a comment to D7980: Return origin object for analogues URLs.

(I forgot to add the logic for ://" character sequencemangled into ":, fixing it now)

Jun 13 2022, 3:49 PM
anlambert accepted D7981: docker: Update and normalize conf/web.yaml and conf/web-search.yml.
Jun 13 2022, 3:41 PM
anlambert requested changes to D7981: docker: Update and normalize conf/web.yaml and conf/web-search.yml.
Jun 13 2022, 3:13 PM
anlambert added inline comments to D7980: Return origin object for analogues URLs.
Jun 13 2022, 3:08 PM
anlambert requested changes to D7980: Return origin object for analogues URLs.

I think it would be better to handle that process directly in the Archive.get_origin function, adding an utility function for a small set of instructions seems a bit overkill.

Jun 13 2022, 3:06 PM
anlambert requested review of D7979: assets/readme-rendering: Use showdown github flavor for github origins.
Jun 13 2022, 1:49 PM
anlambert committed rDWAPPSca459efe19b8: package.json: Upgrade dependencies (authored by anlambert).
package.json: Upgrade dependencies
Jun 13 2022, 11:42 AM
anlambert closed D7971: common/archive: Ensure backward compatibility with swh-indexer 1.x.
Jun 13 2022, 11:42 AM
anlambert committed rDWAPPS284e0d9857b2: common/archive: Ensure backward compatibility with swh-indexer 1.x (authored by anlambert).
common/archive: Ensure backward compatibility with swh-indexer 1.x
Jun 13 2022, 11:42 AM
anlambert closed T4318: Consider using jar command to extract jar archives as Resolved.
Jun 13 2022, 11:28 AM · Maven loader
anlambert updated the diff for D7971: common/archive: Ensure backward compatibility with swh-indexer 1.x.

Rebase

Jun 13 2022, 11:24 AM
anlambert closed D7974: common/utils: Ensure str type for query parameters in reverse function.
Jun 13 2022, 11:23 AM
anlambert committed rDWAPPSde50f0b44996: common/utils: Ensure str type for query parameters in reverse function (authored by anlambert).
common/utils: Ensure str type for query parameters in reverse function
Jun 13 2022, 11:23 AM
anlambert updated the diff for D7974: common/utils: Ensure str type for query parameters in reverse function.

More code simplification

Jun 13 2022, 10:54 AM

Jun 9 2022

anlambert added inline comments to D7974: common/utils: Ensure str type for query parameters in reverse function.
Jun 9 2022, 6:45 PM
anlambert updated the diff for D7974: common/utils: Ensure str type for query parameters in reverse function.

Simplify some code

Jun 9 2022, 6:44 PM
anlambert updated the diff for D7974: common/utils: Ensure str type for query parameters in reverse function.

Rebase and remove redundant sorted call

Jun 9 2022, 4:39 PM
anlambert closed D7973: browse: Add typing to view function signatures.
Jun 9 2022, 4:38 PM
anlambert committed rDWAPPSb54d930bed54: browse: Add typing to view function signatures (authored by anlambert).
browse: Add typing to view function signatures
Jun 9 2022, 4:38 PM
anlambert added a comment to D7977: Increase runtime of origin_visit_find_by_date.

I think the proper fix would be to add a specific index to the origin_visit table in PostgreSQL database (see T4198).

Jun 9 2022, 4:29 PM
anlambert added inline comments to D7974: common/utils: Ensure str type for query parameters in reverse function.
Jun 9 2022, 4:22 PM
anlambert closed D7976: tarball: Use standard Python module zipfile to extract jar archive.
Jun 9 2022, 4:20 PM
anlambert committed rDCORE7f85bd7cea2c: tarball: Use standard Python module zipfile to extract jar archive (authored by anlambert).
tarball: Use standard Python module zipfile to extract jar archive
Jun 9 2022, 4:20 PM
anlambert updated the diff for D7976: tarball: Use standard Python module zipfile to extract jar archive.

Rebase

Jun 9 2022, 4:13 PM
anlambert updated the diff for D7973: browse: Add typing to view function signatures.

Address @vlorentz comments

Jun 9 2022, 4:03 PM
anlambert added inline comments to D7973: browse: Add typing to view function signatures.
Jun 9 2022, 4:02 PM
anlambert added a comment to D7976: tarball: Use standard Python module zipfile to extract jar archive.

why don't we also use this module for ZIP files?

Jun 9 2022, 3:45 PM
anlambert added inline comments to D7973: browse: Add typing to view function signatures.
Jun 9 2022, 3:36 PM
anlambert requested review of D7976: tarball: Use standard Python module zipfile to extract jar archive.
Jun 9 2022, 3:29 PM
anlambert added a revision to T4318: Consider using jar command to extract jar archives: D7976: tarball: Use standard Python module zipfile to extract jar archive.
Jun 9 2022, 3:27 PM · Maven loader
anlambert added a comment to T4318: Consider using jar command to extract jar archives.

Alternatively, we could use the zipfile standard Python module which seems to work in a similar way as the jar command, see below:

(swh) anlambert@carnavalet:/tmp/jar_test$ wget https://repo1.maven.org/maven2/org/pustefixframework/pustefix-archetype-basic/0.15.20/pustefix-archetype-basic-0.15.20-sources.jar
--2022-06-09 14:56:17--  https://repo1.maven.org/maven2/org/pustefixframework/pustefix-archetype-basic/0.15.20/pustefix-archetype-basic-0.15.20-sources.jar
Resolving repo1.maven.org (repo1.maven.org)... 151.101.120.209
Connecting to repo1.maven.org (repo1.maven.org)|151.101.120.209|:443... connected.
HTTP request sent, awaiting response... 200 OK
Length: 45637 (45K) [application/java-archive]
Saving to: ‘pustefix-archetype-basic-0.15.20-sources.jar’
Jun 9 2022, 3:02 PM · Maven loader
anlambert triaged T4318: Consider using jar command to extract jar archives as Normal priority.
Jun 9 2022, 1:50 PM · Maven loader
anlambert accepted D7975: Add functional tests for the release node.

Looks good to me.

Jun 9 2022, 1:12 PM
anlambert requested review of D7974: common/utils: Ensure str type for query parameters in reverse function.
Jun 9 2022, 11:58 AM

Jun 8 2022

anlambert requested review of D7973: browse: Add typing to view function signatures.
Jun 8 2022, 5:44 PM
anlambert closed D7959: api: Add typing to view function signatures.
Jun 8 2022, 3:36 PM
anlambert committed rDWAPPS72b6022e0966: api: Add typing to view function signatures (authored by anlambert).
api: Add typing to view function signatures
Jun 8 2022, 3:36 PM
anlambert updated the diff for D7971: common/archive: Ensure backward compatibility with swh-indexer 1.x.

Remove debian folder staged by mistake.

Jun 8 2022, 2:49 PM
anlambert added a comment to D7971: common/archive: Ensure backward compatibility with swh-indexer 1.x.

Why bother with swh-indexer 1.x? updating prod should be good enough

and I don't think you meant to stage debian/

Jun 8 2022, 2:47 PM
anlambert requested review of D7971: common/archive: Ensure backward compatibility with swh-indexer 1.x.
Jun 8 2022, 2:05 PM
anlambert updated the diff for D7959: api: Add typing to view function signatures.

Address @vlorentz comments

Jun 8 2022, 2:03 PM
anlambert accepted D7970: Fix InMemoryJournalWriter: do not anonymize objects by default.

Looks good, thanks !

Jun 8 2022, 12:27 PM

Jun 7 2022

anlambert closed D7967: package/archive: Handle tarball artifact with null time.
Jun 7 2022, 3:36 PM
anlambert committed rDLDBASEd925d06e6f1a: package/archive: Handle tarball artifact with null time (authored by anlambert).
package/archive: Handle tarball artifact with null time
Jun 7 2022, 3:36 PM
anlambert closed D7964: assets/functions: Add missing await keywords in getCanonicalOriginURL.
Jun 7 2022, 3:29 PM
anlambert committed rDWAPPS66ded032dca0: assets/functions: Add missing await keywords in getCanonicalOriginURL (authored by anlambert).
assets/functions: Add missing await keywords in getCanonicalOriginURL
Jun 7 2022, 3:29 PM
anlambert requested review of D7967: package/archive: Handle tarball artifact with null time.
Jun 7 2022, 3:17 PM
anlambert triaged T4311: Package and deploy dulwich 0.20.43 in production as Normal priority.
Jun 7 2022, 2:45 PM · System administration, Git loader
anlambert requested review of D7964: assets/functions: Add missing await keywords in getCanonicalOriginURL.
Jun 7 2022, 2:25 PM
anlambert closed D7963: common, tests: Fix compatibility with swh-indexer 2.0.0.
Jun 7 2022, 1:59 PM
anlambert committed rDWAPPS749b6f5bf453: common, tests: Fix compatibility with swh-indexer 2.0.0 (authored by anlambert).
common, tests: Fix compatibility with swh-indexer 2.0.0
Jun 7 2022, 1:59 PM
anlambert updated the diff for D7963: common, tests: Fix compatibility with swh-indexer 2.0.0.

Remove file added by mistake

Jun 7 2022, 1:16 PM
anlambert updated the diff for D7963: common, tests: Fix compatibility with swh-indexer 2.0.0.

Bump swh-indexer in requirements-swh.txt

Jun 7 2022, 1:13 PM
anlambert requested review of D7963: common, tests: Fix compatibility with swh-indexer 2.0.0.
Jun 7 2022, 12:18 PM

Jun 3 2022

anlambert requested review of D7959: api: Add typing to view function signatures.
Jun 3 2022, 5:52 PM
anlambert closed D7947: cypress: Upgrade to version 10.
Jun 3 2022, 5:27 PM
anlambert committed rDWAPPS631925c646cd: cypress: Upgrade to version 10 (authored by anlambert).
cypress: Upgrade to version 10
Jun 3 2022, 5:27 PM
anlambert accepted D7961: jobs/swh-packages: Bump swh-storage build jobs timeout to 25 minutes.
Jun 3 2022, 5:11 PM
anlambert updated the diff for D7947: cypress: Upgrade to version 10.

Rebase

Jun 3 2022, 4:59 PM
anlambert closed D7960: jobs/swh-packages: Bump swh-web build jobs timeout to 30 minutes.
Jun 3 2022, 4:37 PM
anlambert committed rCJSWH1609a9ab4702: jobs/swh-packages: Bump swh-web build jobs timeout to 30 minutes (authored by anlambert).
jobs/swh-packages: Bump swh-web build jobs timeout to 30 minutes
Jun 3 2022, 4:37 PM
anlambert added a comment to D7960: jobs/swh-packages: Bump swh-web build jobs timeout to 30 minutes.

ouch!

@vlorentz some impact from stopping the concurrency build part ¯\_(ツ)_/¯

Jun 3 2022, 4:36 PM
anlambert requested review of D7960: jobs/swh-packages: Bump swh-web build jobs timeout to 30 minutes.
Jun 3 2022, 4:31 PM
anlambert added a comment to D7947: cypress: Upgrade to version 10.

/me closes his eyes and accepts the diff ¯\_(ツ)_/¯

Jun 3 2022, 3:34 PM
anlambert accepted D7955: Fix pagination in api_raw_extrinsic_metadata_swhid.

Looks good to me. I will submit another diff to ensure the query_params parameter of the reverse function is of type Dict[str, Optional[str]] in order to avoid that kind of issues.

Jun 3 2022, 1:41 PM
anlambert created P1376 (An Untitled Masterwork).
Jun 3 2022, 11:25 AM
anlambert requested review of D7947: cypress: Upgrade to version 10.
Jun 3 2022, 11:17 AM
anlambert created P1375 (An Untitled Masterwork).
Jun 3 2022, 11:02 AM

Jun 2 2022

anlambert closed D7948: tests: Fix flaky ones since hypothesis 6.46.11 release.
Jun 2 2022, 5:42 PM
anlambert committed rDWAPPSce5824a68aed: tests: Fix flaky ones since hypothesis 6.46.11 release (authored by anlambert).
tests: Fix flaky ones since hypothesis 6.46.11 release
Jun 2 2022, 5:42 PM
anlambert requested review of D7948: tests: Fix flaky ones since hypothesis 6.46.11 release.
Jun 2 2022, 5:10 PM
anlambert added a comment to T4303: hypothesis test failure .

I also spotted the issue and could reproduce locally, looks like it is related to latest hypothesis release that makes some of our tests became flaky. I just pushed D7948 as a workaround to make them pass again.

Jun 2 2022, 4:54 PM · Web app
anlambert added a project to T4303: hypothesis test failure : Web app.
Jun 2 2022, 4:53 PM · Web app
anlambert accepted D7946: github/utils: Deal with exotic urls to canonicalize.

Looks good to me.

Jun 2 2022, 3:58 PM
anlambert added inline comments to D7946: github/utils: Deal with exotic urls to canonicalize.
Jun 2 2022, 3:37 PM
anlambert committed rDWAPPS0735488be047: package.json: Upgrade dependencies (authored by anlambert).
package.json: Upgrade dependencies
Jun 2 2022, 2:27 PM
anlambert committed rDWAPPS845abee6f267: api/views/vault: Fix isort error (authored by anlambert).
api/views/vault: Fix isort error
Jun 2 2022, 2:27 PM
anlambert closed D7938: mypy: Fix errors after django*-stubs upgrade.
Jun 2 2022, 2:27 PM
anlambert committed rDWAPPS6e52f32e3e84: mypy: Fix errors after django*-stubs upgrade (authored by anlambert).
mypy: Fix errors after django*-stubs upgrade
Jun 2 2022, 2:27 PM

Jun 1 2022

anlambert added a comment to D7938: mypy: Fix errors after django*-stubs upgrade.

Can query_params[k] really be not a string? why?

Jun 1 2022, 5:19 PM
anlambert requested review of D7938: mypy: Fix errors after django*-stubs upgrade.
Jun 1 2022, 4:59 PM
anlambert added a subtask for T3560: Polish the swh-search QL: T4296: Pagination does not work when using sort_by in search query language.
Jun 1 2022, 1:42 PM · Archive search
anlambert added a parent task for T4296: Pagination does not work when using sort_by in search query language: T3560: Polish the swh-search QL.
Jun 1 2022, 1:42 PM · Archive search
anlambert triaged T4296: Pagination does not work when using sort_by in search query language as Normal priority.
Jun 1 2022, 1:37 PM · Archive search
anlambert closed D7878: svn: Wraps commit info retrieval in a retryable SvnRepo method.
Jun 1 2022, 11:51 AM
anlambert committed rDLDSVN670365596e4a: svn: Wraps commit info retrieval in a retryable SvnRepo method (authored by anlambert).
svn: Wraps commit info retrieval in a retryable SvnRepo method
Jun 1 2022, 11:51 AM
anlambert added inline comments to D7878: svn: Wraps commit info retrieval in a retryable SvnRepo method.
Jun 1 2022, 11:51 AM
anlambert added inline comments to D7878: svn: Wraps commit info retrieval in a retryable SvnRepo method.
Jun 1 2022, 11:41 AM
anlambert updated the diff for D7878: svn: Wraps commit info retrieval in a retryable SvnRepo method.

Address @ardumont comment.

Jun 1 2022, 11:39 AM

May 20 2022

anlambert added inline comments to D7874: Add a schema type for handling binary strings.
May 20 2022, 4:42 PM
anlambert added inline comments to D7874: Add a schema type for handling binary strings.
May 20 2022, 4:41 PM
anlambert requested changes to D7874: Add a schema type for handling binary strings.
May 20 2022, 4:36 PM
anlambert requested review of D7878: svn: Wraps commit info retrieval in a retryable SvnRepo method.
May 20 2022, 4:14 PM
anlambert closed D7875: svn_retry: Retry operation when server sent a truncated HTTP response.
May 20 2022, 4:04 PM
anlambert committed rDLDSVN2afad0ee23f5: svn_retry: Retry operation when server sent a truncated HTTP response (authored by anlambert).
svn_retry: Retry operation when server sent a truncated HTTP response
May 20 2022, 4:04 PM
anlambert closed D7872: cvs2gitdump: Fix local variable 'expkw' referenced before assignment.
May 20 2022, 4:03 PM
anlambert committed rDLDCVSd52686be9182: cvs2gitdump: Fix local variable 'expkw' referenced before assignment (authored by anlambert).
cvs2gitdump: Fix local variable 'expkw' referenced before assignment
May 20 2022, 4:03 PM
anlambert accepted D7876: Log summary of filtered objects in store_data.
May 20 2022, 4:03 PM
anlambert accepted D7873: Add an unweighted average for filtered_objects + fix existing metric name.
May 20 2022, 4:02 PM
anlambert requested review of D7875: svn_retry: Retry operation when server sent a truncated HTTP response.
May 20 2022, 3:42 PM