Differential D7964

assets/functions: Add missing await keywords in getCanonicalOriginURL
ClosedPublic
Actions

Authored by anlambert on Jun 7 2022, 2:04 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Commits

rDWAPPS66ded032dca0: assets/functions: Add missing await keywords in getCanonicalOriginURL

Summary

Promise was returned instead of the expected asynchronous result which
was causing issues when submitting save code now requests.

Diff Detail

Repository

rDWAPPS Web applications

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

anlambert created this revision.Jun 7 2022, 2:04 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptJun 7 2022, 2:04 PM

Build is green

Patch application report for D7964 (id=28701)

Rebasing onto 749b6f5bf4...

Current branch diff-target is up to date.

Changes applied before test

commit 66ded032dca05869e34329dac27dc0c1029cab54
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Tue Jun 7 13:27:51 2022 +0200

    assets/functions: Add missing await keywords in getCanonicalOriginURL
    
    Promise was returned instead of the expected asynchronous result which
    was causing issues when submitting save code now requests.

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1887/ for more details.

Harbormaster completed remote builds in B29782: Diff 28701.Jun 7 2022, 2:25 PM

anlambert requested review of this revision.Jun 7 2022, 2:25 PM

ardumont accepted this revision.Jun 7 2022, 2:36 PM

This revision is now accepted and ready to land.Jun 7 2022, 2:36 PM

Closed by commit rDWAPPS66ded032dca0: assets/functions: Add missing await keywords in getCanonicalOriginURL (authored by anlambert). · Explain WhyJun 7 2022, 3:29 PM

This revision was automatically updated to reflect the committed changes.

anlambert added a commit: rDWAPPS66ded032dca0: assets/functions: Add missing await keywords in getCanonicalOriginURL.