Page MenuHomeSoftware Heritage
Feed All Stories

Sep 23 2021

vlorentz added a parent task for T3333: Document the different storage backends: T3604: Document the architecture of all major packages/components.
Sep 23 2021, 2:51 PM · Documentation, Storage manager
vlorentz added a subtask for T3604: Document the architecture of all major packages/components: T3333: Document the different storage backends.
Sep 23 2021, 2:51 PM · meta-task, Documentation
vlorentz triaged T3604: Document the architecture of all major packages/components as Normal priority.
Sep 23 2021, 2:50 PM · meta-task, Documentation
swh-public-ci added a comment to D6325: Refactor identifiers & model to make *_git_object() functions work on model classes instead of dicts.

Build is green

Sep 23 2021, 2:45 PM
vlorentz updated the diff for D6325: Refactor identifiers & model to make *_git_object() functions work on model classes instead of dicts.

fix spec of author/committer formatting in revision_identifier + update function name in ValueErrors raised by TimestampWithTimezone.from_dict

Sep 23 2021, 2:42 PM
vlorentz added inline comments to D6325: Refactor identifiers & model to make *_git_object() functions work on model classes instead of dicts.
Sep 23 2021, 2:42 PM
vlorentz added a comment to D6165: Add new RabbitMQ-based client/server API.

It should be reStructuredText (introduction here: https://www.sphinx-doc.org/en/master/usage/restructuredtext/basics.html ), with a reference from the toctree in docs/index.rst

Sep 23 2021, 2:33 PM
olasd added inline comments to D6325: Refactor identifiers & model to make *_git_object() functions work on model classes instead of dicts.
Sep 23 2021, 2:32 PM
vlorentz added a comment to D6326: Move manifest computation functions from identifiers.py to git_objects.py.

yes, that's the plan

Sep 23 2021, 2:30 PM
olasd added a comment to D6326: Move manifest computation functions from identifiers.py to git_objects.py.

Nevermind, I was confused by all the red and it's much clearer what's left over in a text editor.

Sep 23 2021, 2:26 PM
swh-public-ci added a comment to D6273: Remove remote storage based on `swh.core.api.RPCClient`.

Build is green

Sep 23 2021, 2:20 PM
swh-public-ci added a comment to D6165: Add new RabbitMQ-based client/server API.

Build is green

Sep 23 2021, 2:18 PM
aeviso added a comment to D6165: Add new RabbitMQ-based client/server API.

It could be something like these:

You can start from your Hedgedoc document, remove the description of the current state, but keep the description of the new design and the rationale

Sep 23 2021, 2:18 PM
aeviso updated the diff for D6273: Remove remote storage based on `swh.core.api.RPCClient`.

rebase

Sep 23 2021, 2:17 PM
aeviso updated the diff for D6165: Add new RabbitMQ-based client/server API.

rebase

Sep 23 2021, 2:14 PM
anlambert renamed T3603: Replace stateful hypothesis strategies by pytest fixtures from Replace non stateful hypothesis strategies by pytest fixtures to Replace stateful hypothesis strategies by pytest fixtures.
Sep 23 2021, 2:12 PM · Web app
anlambert triaged T3603: Replace stateful hypothesis strategies by pytest fixtures as Normal priority.
Sep 23 2021, 2:12 PM · Web app
vlorentz added a comment to D6326: Move manifest computation functions from identifiers.py to git_objects.py.

documentation of what?

Sep 23 2021, 1:39 PM
swh-public-ci added a comment to D6272: Remove remote storage based on `swh.core.api.RPCClient`.

Build is green

Sep 23 2021, 1:38 PM
aeviso updated the diff for D6272: Remove remote storage based on `swh.core.api.RPCClient`.

rebase

Sep 23 2021, 1:33 PM
vlorentz added a comment to D6165: Add new RabbitMQ-based client/server API.

It could be something like these:

Sep 23 2021, 1:31 PM
aeviso added a comment to D6165: Add new RabbitMQ-based client/server API.

It's actually explained in the document:

Oh, sorry, I missed the hedgedoc link. I only looked in the repo and the diff's content.

Could you document the new design in this diff too, in the docs/ folder?

Sep 23 2021, 1:16 PM
olasd added a comment to D6326: Move manifest computation functions from identifiers.py to git_objects.py.

Well except both sides show deleted documentation, which can't be right :P

Sep 23 2021, 11:59 AM
anlambert added a comment to T3602: Use swh-storage PostgreSQL backend in tests.

Instead of running tests only with the pg backend, what about both the in-mem and pg, using a parametrized fixture?
This would allow catching discrepancies between backends, instead of accidentally relying on pg's.

And, as the in-mem backend is much faster, we could exclude the pg backend while iterating (eg. pytest -k 'not postgresql').

Sep 23 2021, 11:59 AM · Web app
vlorentz added a comment to T3602: Use swh-storage PostgreSQL backend in tests.

Instead of running tests only with the pg backend, what about both the in-mem and pg, using a parametrized fixture?
This would allow catching discrepancies between backends, instead of accidentally relying on pg's.

Sep 23 2021, 11:38 AM · Web app
zack added a project to T3581: List heptapod instance foss.heptapod.net: Archive coverage.
Sep 23 2021, 11:32 AM · Archive coverage, System administration, Origin-GitLab
zack added a project to T3568: Deploy opam lister/loader to production: Archive coverage.
Sep 23 2021, 11:32 AM · System administration, Archive coverage, Opam
anlambert triaged T3602: Use swh-storage PostgreSQL backend in tests as Normal priority.
Sep 23 2021, 11:25 AM · Web app
vlorentz added a comment to D6165: Add new RabbitMQ-based client/server API.

It's actually explained in the document:

Sep 23 2021, 11:20 AM
ardumont created P1174 (An Untitled Masterwork).
Sep 23 2021, 11:11 AM
anlambert triaged T3601: Use PostgreSQL backend for django database in tests as Normal priority.
Sep 23 2021, 11:08 AM · Web app
ardumont closed T3599: List and ingest heptapod instances as Resolved.

All referenced heptapod instances listed.
Closing this.

Sep 23 2021, 11:08 AM · System administration, Archive coverage
ardumont closed T3584: loader mercurial edge case about missing mapping from revision to hgnode-id as Resolved.

Deployed v2.3.1 with that fix.

Sep 23 2021, 11:07 AM · Mercurial loader
swh-public-ci added a comment to D6322: Add bazaar as supported revision type.

Build is green

Sep 23 2021, 11:05 AM
swh-public-ci added a comment to D6321: Add bazaar as supported revision type.

Build is green

Sep 23 2021, 10:59 AM
Alphare closed D6321: Add bazaar as supported revision type.
Sep 23 2021, 10:58 AM
Alphare committed rDMOD0dd33cdf7d8a: Add bazaar as supported revision type (authored by Alphare).
Add bazaar as supported revision type
Sep 23 2021, 10:58 AM
vlorentz added a comment to D6326: Move manifest computation functions from identifiers.py to git_objects.py.

It's technically correct: when I split a file, it considers it to be a copy followed by deletions.

Sep 23 2021, 10:58 AM
Alphare closed D6322: Add bazaar as supported revision type.
Sep 23 2021, 10:58 AM
Alphare committed rDSTOec548ee8bb15: Add bazaar as supported revision type (authored by Alphare).
Add bazaar as supported revision type
Sep 23 2021, 10:58 AM
swh-public-ci added a comment to D6325: Refactor identifiers & model to make *_git_object() functions work on model classes instead of dicts.

Build is green

Sep 23 2021, 10:57 AM
Alphare updated the diff for D6321: Add bazaar as supported revision type.

Rebase

Sep 23 2021, 10:57 AM
Alphare updated the diff for D6322: Add bazaar as supported revision type.

Rebase

Sep 23 2021, 10:56 AM
ardumont closed D6300: Capture missing revision <-> hgnode-id scenario in a xfail test.
Sep 23 2021, 10:56 AM
ardumont added a comment to D6300: Capture missing revision <-> hgnode-id scenario in a xfail test.

Landed through ef502bc

Sep 23 2021, 10:55 AM
vlorentz added inline comments to D6325: Refactor identifiers & model to make *_git_object() functions work on model classes instead of dicts.
Sep 23 2021, 10:55 AM
vlorentz updated the diff for D6325: Refactor identifiers & model to make *_git_object() functions work on model classes instead of dicts.

apply comments

Sep 23 2021, 10:54 AM
ardumont closed D6329: Fix branch bookmark id format so ingestion can finish.
Sep 23 2021, 10:54 AM
ardumont committed rDLDHG395ea80518cd: Fix branch bookmark id format so ingestion can finish (authored by ardumont).
Fix branch bookmark id format so ingestion can finish
Sep 23 2021, 10:54 AM
ardumont committed rDLDHGef502bcdf3a2: Capture missing revision <-> hgnode-id scenario in a xfail test (authored by ardumont).
Capture missing revision <-> hgnode-id scenario in a xfail test
Sep 23 2021, 10:54 AM
ardumont added a comment to D6329: Fix branch bookmark id format so ingestion can finish.

Thanks, let's deploy this so we can ingest properly now.
I notice it happens once in a while in the bitbucket origins.

Sep 23 2021, 10:54 AM
Alphare accepted D6329: Fix branch bookmark id format so ingestion can finish.

LGTM!

Sep 23 2021, 10:51 AM
ardumont closed T3597: List heptapod instance https://forge.extranet.logilab.fr/ as Resolved.
Sep 23 2021, 10:51 AM · System administration, Archive coverage
ardumont closed T3597: List heptapod instance https://forge.extranet.logilab.fr/, a subtask of T3599: List and ingest heptapod instances, as Resolved.
Sep 23 2021, 10:51 AM · System administration, Archive coverage
ardumont moved T3597: List heptapod instance https://forge.extranet.logilab.fr/ from code-review/await-feedback/pause to deployed/landed/monitoring on the System administration board.
Sep 23 2021, 10:51 AM · System administration, Archive coverage
ardumont added a comment to T3597: List heptapod instance https://forge.extranet.logilab.fr/.
  • Ingestion mostly done (2 git origins remains to be done but the 99% of hg origins are done).. [1]
  • archive changelog updated
Sep 23 2021, 10:50 AM · System administration, Archive coverage
ardumont moved T3597: List heptapod instance https://forge.extranet.logilab.fr/ from Backlog to code-review/await-feedback/pause on the System administration board.
Sep 23 2021, 10:50 AM · System administration, Archive coverage
swh-public-ci added a comment to D6329: Fix branch bookmark id format so ingestion can finish.

Build is green

Sep 23 2021, 10:46 AM
ardumont updated the diff for D6329: Fix branch bookmark id format so ingestion can finish.

Drop spurious pdb

Sep 23 2021, 10:44 AM
swh-public-ci added a comment to D6329: Fix branch bookmark id format so ingestion can finish.

Build is green

Sep 23 2021, 10:44 AM
ardumont retitled D6329: Fix branch bookmark id format so ingestion can finish from Identify & fix missing mapping scenario about mismatched bookmark id to Fix branch bookmark id format so ingestion can finish.
Sep 23 2021, 10:42 AM
ardumont updated the diff for D6329: Fix branch bookmark id format so ingestion can finish.

Proper fix

Sep 23 2021, 10:42 AM
olasd added a comment to D6326: Move manifest computation functions from identifiers.py to git_objects.py.

Looks like Phabricator is doing a funny one when displaying this diff. Lemme check what's actually in the staging repo...

Sep 23 2021, 10:34 AM
vsellier added a comment to T3592: POC elastic worker infrastructure.

Interesting documentations on how to manage jobs:

Sep 23 2021, 10:32 AM · System administration
ardumont added inline comments to D6329: Fix branch bookmark id format so ingestion can finish.
Sep 23 2021, 10:26 AM
olasd accepted D6324: test_identifiers.py: Fix/update malformed data dicts.
Sep 23 2021, 10:25 AM
olasd accepted D6328: test_identifiers.py: Make sha1_git literals more consistent..
Sep 23 2021, 10:24 AM
ardumont moved T3599: List and ingest heptapod instances from in-progress to code-review/await-feedback/pause on the System administration board.
Sep 23 2021, 10:23 AM · System administration, Archive coverage
ardumont committed rDDOC9525eeb3bcd9: docs: Update archive changelog about the logilab heptapod instance (authored by ardumont).
docs: Update archive changelog about the logilab heptapod instance
Sep 23 2021, 10:23 AM
douardda accepted D6322: Add bazaar as supported revision type.

LGTM

Sep 23 2021, 10:17 AM
ardumont updated the summary of D6329: Fix branch bookmark id format so ingestion can finish.
Sep 23 2021, 10:17 AM
ardumont requested review of D6329: Fix branch bookmark id format so ingestion can finish.
Sep 23 2021, 10:16 AM
ardumont added a revision to T3584: loader mercurial edge case about missing mapping from revision to hgnode-id: D6329: Fix branch bookmark id format so ingestion can finish.
Sep 23 2021, 10:14 AM · Mercurial loader
ardumont updated subscribers of T3584: loader mercurial edge case about missing mapping from revision to hgnode-id.

@Alphare any clues as to why the format here is not in sync? ^

Sep 23 2021, 10:13 AM · Mercurial loader
ardumont added a comment to T3584: loader mercurial edge case about missing mapping from revision to hgnode-id.

Ok, found where the wrong format is found somehow, the branching_info.bookmarks is not in the right format.

Sep 23 2021, 10:03 AM · Mercurial loader
ardumont added a comment to T3584: loader mercurial edge case about missing mapping from revision to hgnode-id.

The test helped, it's a mismatch format problem.
Uncomment the test, place the right pdb stanza in the code and behold:

Sep 23 2021, 9:50 AM · Mercurial loader
Alphare requested review of D6322: Add bazaar as supported revision type.
Sep 23 2021, 9:47 AM
ardumont added a comment to T3597: List heptapod instance https://forge.extranet.logilab.fr/.

Comment at the wrong position: T3599#71039

Sep 23 2021, 9:40 AM · System administration, Archive coverage
ardumont added a comment to T3599: List and ingest heptapod instances.

Listing and partial ingestion ok in staging.
Deployed on production (reduced to a minimum of 4 workers with concurrency 1).
Ingestion ongoing.

Sep 23 2021, 9:40 AM · System administration, Archive coverage
ardumont changed the status of T3599: List and ingest heptapod instances from Open to Work in Progress.
Sep 23 2021, 9:39 AM · System administration, Archive coverage
ardumont added a project to T3599: List and ingest heptapod instances: System administration.
Sep 23 2021, 9:39 AM · System administration, Archive coverage
olasd added a comment to D6325: Refactor identifiers & model to make *_git_object() functions work on model classes instead of dicts.

I believe most annotations for the *_git_object functions should formally be Unions. I think the fallbacks from dict should raise DeprecationWarnings too?

Sep 23 2021, 9:35 AM
ardumont added inline comments to D6305: opam: Install and maintain up-to-date shared opam root directories.
Sep 23 2021, 9:29 AM
ardumont closed T3600: List heptapod instance https://heptapod.host/, a subtask of T3599: List and ingest heptapod instances, as Resolved.
Sep 23 2021, 9:26 AM · System administration, Archive coverage
ardumont closed T3600: List heptapod instance https://heptapod.host/ as Resolved.
Sep 23 2021, 9:25 AM · System administration, Archive coverage
ardumont moved T3600: List heptapod instance https://heptapod.host/ from code-review/await-feedback/pause to deployed/landed/monitoring on the System administration board.
Sep 23 2021, 9:25 AM · System administration, Archive coverage
ardumont added a comment to T3600: List heptapod instance https://heptapod.host/.

This is done:

  • Archive changelog updated accordingly.
  • We now have 2 heptapod instances listed (ingestion done) [1]
Sep 23 2021, 9:25 AM · System administration, Archive coverage
ardumont added a comment to T3374: Ingest sourceforge repositories (origins of type git, svn, hg).

Heads up on this task, i'm actually waiting for the bitbucket ingestion (which is going faster now) to finish.
To re-use our worker17 to make one last run on all the mercurial origins.

Sep 23 2021, 9:19 AM · System administration, Archive coverage, Origin-SourceForge
ardumont closed T3563: Analyze and make the bitbucket ingestion faster, a subtask of T3338: Load the archived bitbucket mercurial repositories, as Resolved.
Sep 23 2021, 9:13 AM · System administration, Mercurial loader
ardumont closed T3563: Analyze and make the bitbucket ingestion faster as Resolved.
Sep 23 2021, 9:13 AM · System administration, Mercurial loader
ardumont moved T3563: Analyze and make the bitbucket ingestion faster from code-review/await-feedback/pause to deployed/landed/monitoring on the System administration board.
Sep 23 2021, 9:13 AM · System administration, Mercurial loader
ardumont added a comment to T3563: Analyze and make the bitbucket ingestion faster.

I've patched the systemd swh-worker@loader_oneshot to actually lift --autoscale 10,20

Sep 23 2021, 9:13 AM · System administration, Mercurial loader
ardumont committed rDDOC96129d005782: docs: Update archive changelog about heptapod.host instance ingestion (authored by ardumont).
docs: Update archive changelog about heptapod.host instance ingestion
Sep 23 2021, 9:10 AM
ardumont moved T3600: List heptapod instance https://heptapod.host/ from in-progress to code-review/await-feedback/pause on the System administration board.
Sep 23 2021, 9:05 AM · System administration, Archive coverage
ardumont changed the status of T3600: List heptapod instance https://heptapod.host/ from Open to Work in Progress.
Sep 23 2021, 8:57 AM · System administration, Archive coverage
ardumont changed the status of T3600: List heptapod instance https://heptapod.host/, a subtask of T3599: List and ingest heptapod instances, from Open to Work in Progress.
Sep 23 2021, 8:57 AM · System administration, Archive coverage
ardumont moved T3600: List heptapod instance https://heptapod.host/ from Backlog to Weekly backlog on the System administration board.
Sep 23 2021, 8:57 AM · System administration, Archive coverage
ardumont claimed T3600: List heptapod instance https://heptapod.host/.
Sep 23 2021, 8:57 AM · System administration, Archive coverage
ardumont added a comment to T3600: List heptapod instance https://heptapod.host/.

Tested on staging and listing then (partial) ingestion went fine.
Triggered on production.

Sep 23 2021, 8:57 AM · System administration, Archive coverage
ardumont updated the task description for T3600: List heptapod instance https://heptapod.host/.
Sep 23 2021, 8:55 AM · System administration, Archive coverage