Added test being:

rebase, rework to use new SWHID classes/model

superseeded by new SWHID classes

adapted to nes SWHID classes

again

blank, to fire jenkins

In D5172#131088, @ardumont wrote:

looks like it's doing the job ;)

I was wondering if it would not be clearer to alter the schema at the end of the file
(or in a subsequent file). Kinda what's done for indexes.

\if :dbflavor_with_path
alter table content_early_in_rev
add column loc bigint not null;  -- location of the content relative to the revision root directory

comment on column content_early_in_rev.loc is 'Location of content in revision';
...
\end

But that would split the reading so let's keep it that way
¯\_(ツ)_/¯

rebase

rebase

rebase

rebase

Rebase + better commit message + add a docstring

rebased

rebased

rebase + default to with_path=True as asked by @aeviso

rebase

The swh_storage_with_objects fixtures returns a (postgresal-based) storage with some objects in it (only a few of each type). The test that given storage do indeed have at least a content, a directory and a revision. I'll improve the commit message a bit.

In D5072#128933, @vlorentz wrote:

I'm not convinced by the flavor thing. Why not a single schema, but with empty values in loc when it's disabled?

(as mentioned on IRC): Since we are doing big works, I see no reason to keep the 'qualifiers' a schema-less dict-like attribute. I'd rather have them as attributes.

rebase

rebase

rebase

ad forgotten isorts (after proper config in pyproject.toml)

rebase and fix db initialization in tests

rebase and fix tests

add missing isort config in pyproject.toml

rebase and fix tests

Fix tests and properly initialize the db using swh.core.db in the pytest fixture

rebase

moslty rebase on D5080

In T3034#58665, @zack wrote:

Who needs to reference REMs in the first place?

lgtm but I would wait for a green stamp from @vlorentz as well

lgtm

it would be nice to have an explanation in the commit message of why this is actually needed. Explain why the original implementation is incorrect, and how it fixes this old incorrect behavior.

@vsellier nice. Note that if we draw these with a y-axis starting from 0, the step shape will be really negligible, so IMHO it's really not a problem.

put the deps on djangorestframework-stubs >= 1.4 in requirement-tests.txt

ok but see my comment