Page MenuHomeSoftware Heritage

Fix swh.deposit.urls typing
ClosedPublic

Authored by douardda on Feb 4 2021, 2:10 PM.

Details

Summary

Needs djangorestframework-stubs>=1.4 for proper mypy checking.

Diff Detail

Repository
rDDEP Push deposit
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Build is green

Patch application report for D5010 (id=17880)

Rebasing onto 4deee5ba94...

Current branch diff-target is up to date.
Changes applied before test
commit babb4d279fc22cc8b107fd48177ee26b88d036cc
Author: David Douard <david.douard@sdfa3.org>
Date:   Mon Nov 2 14:52:33 2020 +0100

    Fix swh.deposit.urls typing
    
    Needs djangorestframework-stubs>=1.4 for proper mypy checking.

See https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/534/ for more details.

put the deps on djangorestframework-stubs >= 1.4 in requirement-tests.txt

also remove the deps on django-stubs and djangorestframework-stubs from the
tox file since these are now in the testing requirement file.

Build is green

Patch application report for D5010 (id=17881)

Rebasing onto 4deee5ba94...

Current branch diff-target is up to date.
Changes applied before test
commit 6275caba93142addb53ea4ba680f49b5b2603e2d
Author: David Douard <david.douard@sdfa3.org>
Date:   Mon Nov 2 14:52:33 2020 +0100

    Fix swh.deposit.urls typing
    
    Needs djangorestframework-stubs>=1.4 for proper mypy checking.

See https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/535/ for more details.

This revision is now accepted and ready to land.Feb 4 2021, 2:30 PM
This revision was automatically updated to reflect the committed changes.