Differential D5101

Refactor and fix the iterate_statuses function
ClosedPublic
Actions

Authored by douardda on Feb 17 2021, 5:37 PM.

Details

Reviewers

aeviso

Commits

rDPROVce0e7fe398f3: Refactor and fix the iterate_statuses function

Summary

do not yield OriginEntry objects if the visit status has no snapshot
use set() as intermediate structures to prevent adding the same revision twice

And add simple tests for the ArchiveOriginIterator class (which is an
inderect test for this iterate_statuses() function, really).

Depends on D5100.

Diff Detail

Repository

rDPROV Provenance database

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

douardda requested review of this revision.Feb 17 2021, 5:37 PM

douardda created this revision.

Harbormaster completed remote builds in B19307: Diff 18208.Feb 17 2021, 5:37 PM

OK about this refactoring, although this will probably change in the future. I think we actually want to receive the status or status visit as parameter, not the origins themselves.

This revision is now accepted and ready to land.Feb 18 2021, 1:50 PM

rebase

Harbormaster completed remote builds in B19361: Diff 18267.Feb 18 2021, 5:58 PM

Closed by commit rDPROVce0e7fe398f3: Refactor and fix the iterate_statuses function (authored by douardda). · Explain WhyFeb 19 2021, 10:02 AM

This revision was automatically updated to reflect the committed changes.

douardda added a commit: rDPROVce0e7fe398f3: Refactor and fix the iterate_statuses function.

Revision Contents
Changeset List

Path

Size

swh/

provenance/

origin.py

39 lines

tests/

test_origin_iterator.py

24 lines

Diff 18283

View Options

swh/provenance/origin.py