In D3177#77360, @vlorentz wrote:

We wouldn't need that if pytest had an equivalent for assertCountEqual :/

improve the commit message

In D3177#77354, @douardda wrote:

In D3177#77353, @douardda wrote:

In D3177#77343, @vlorentz wrote:

What is the motivation for this?

Be able to create sets of revisions.

Also, having frozen objects that are modifiable seems a bit fuzzy to me, to say the least.

In D3177#77353, @douardda wrote:

In D3177#77343, @vlorentz wrote:

What is the motivation for this?

Be able to create sets of revisions.

In D3177#77343, @vlorentz wrote:

What is the motivation for this?

Forgot to update hypothesis strategies also.

Bump dep on attrs_strict >= 0.0.7

typo

bump dep on swh-model to 0.2

use ModelType instead of T for type annotation

typos, rename a couple of tests, and better comments

properly annotate BaseModel.anonymize()

Typos + comments/docstrings + hash on the fullname in Person.anonymize()

Replaced by D3171 + D3172

In D3171#77185, @vlorentz wrote:

Shouldn't we make anonymized objects error when their compute_hash() method is called?

Replaced by D3171 + D3172

typo

same, but with the actual chuck

assert object_type is unset is the class has subclasses

add the test suggested by olasd

In D3152#76660, @ardumont wrote:

Looks good.

Do you plan to add the test olasd mentioned? [1]

We should also have a test checking that no two objects types have the same object_type value. This test should check all BaseModel subclasses (instead of just stuff generated by strategies.objects).

[1] D3152#76613

so be it :-)

rename tag as object_type and use a Final instead of a Literal.

In D3152#76561, @vlorentz wrote:

And I'm not a big fan of the name. What about object_type, as we already use this name in other places?

typos (thx ardumont)

In D3151#76517, @ardumont wrote:

Remove global var and put that definition local to its use

In D3149#76484, @vlorentz wrote:

What about using a different prefix instead of adding a suffix, eg. swh.journal.anonymized_objects.?

It would require less special handling/configuration

In D3149#76430, @ardumont wrote:

I'm ok, but for one question.

Shouldn't this also accept no : in the object type (the prior behavior if i understood correctly)?

In D3149#76474, @douardda wrote:

In D3149#76428, @vlorentz wrote:

Did we already decide anonymized topics should use this name scheme?

Nope, this is a base for discussion :-)

In D3149#76428, @vlorentz wrote:

Did we already decide anonymized topics should use this name scheme?

typos (thx ardumont)

rebase

In D3137#76220, @vlorentz wrote:

we usually define a now() function at the beginning of modules to return an aware datetime, but that's ok too

several typos reported by anlambert

typo in commit message

In D3130#76039, @anlambert wrote:

Looks good to me. Just one nitpick, there is some typos in commit messages:

• instanciation -> instantiation
• instanciating -> instantiating

fix a few typos

few changes according to comments on IRC