Use the new mocked kafka server fixture provided by swh.journal's pytest
plugin instead of deprecated (and broken) FakeKafkaXXX classes.
Details
Details
- Reviewers
ardumont - Group Reviewers
Reviewers - Commits
- rDCIDX10251a186621: Fix test_cli for swh.journal 0.1.0
Diff Detail
Diff Detail
- Repository
- rDCIDX Metadata indexer
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
Comment Actions
Build has FAILED
Patch application report for D3144 (id=11166)
Rebasing onto 10f8af474c...
Current branch diff-target is up to date.
Changes applied before test
commit a3e97d560b27e75d3fa337adcce566804f2a5696
Author: David Douard <david.douard@sdfa3.org>
Date: Tue May 12 16:25:17 2020 +0200
Fix test_cli for swh.journal 0.1.0
Use the new mocked kafka server fixture provided by swh.journal's pytest
plugin instead of deprecated (and broken) FakeKafkaXXX classes.Link to build: https://jenkins.softwareheritage.org/job/DCIDX/job/tests-on-diff/8/
See console output for more information: https://jenkins.softwareheritage.org/job/DCIDX/job/tests-on-diff/8/console
Comment Actions
Thanks.
(That's what i had in mind to try and investigate \m/ but got nowhere near it ;)
Comment Actions
Build has FAILED
The build failure is unrelated (it's "new" flake8 errors we have in jenkins
since today). I have been fixing those one at a time (as they pop up actually).
I have pushed the fix on master for this one, so you should just have to rebase
for this build to go green.
Comment Actions
Build is green
Patch application report for D3144 (id=11172)
Rebasing onto db01227740...
Current branch diff-target is up to date.
Changes applied before test
commit 10251a186621d61187e43902d9ba32bdf81f09a0
Author: David Douard <david.douard@sdfa3.org>
Date: Tue May 12 16:25:17 2020 +0200
Fix test_cli for swh.journal 0.1.0
Use the new mocked kafka server fixture provided by swh.journal's pytest
plugin instead of deprecated (and broken) FakeKafkaXXX classes.See https://jenkins.softwareheritage.org/job/DCIDX/job/tests-on-diff/9/ for more details.