journal: add a skipped_content topic dedicated to SkippedContent objects
ClosedPublic
Actions

Authored by douardda on May 12 2020, 9:52 AM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Commits

rDSTO87f7bee6935b: journal: add a skipped_content topic dedicated to SkippedContent objects

Summary

instead of mixing them with Content in the content topic.

Diff Detail

Repository

rDSTO Storage manager

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

douardda created this revision.May 12 2020, 9:52 AM

Herald added a reviewer: Reviewers. · View Herald TranscriptMay 12 2020, 9:52 AM

Build is green

Patch application report for D3140 (id=11158)

Rebasing onto 306aa69b26...

Current branch diff-target is up to date.

Changes applied before test

commit 6bedc5b16f443b51cbba3c0f3ceb1b3e261fd812
Author: David Douard <david.douard@sdfa3.org>
Date:   Tue Apr 7 16:20:35 2020 +0200

    journal: add a skipped_content topic dedicated to SkippedContent objects
    
    instead of mixing them with Content in the content topic.

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/167/ for more details.

Harbormaster completed remote builds in B12336: Diff 11158.May 12 2020, 9:58 AM

Looks good.

Some questions/remarks in the diff.

swh/storage/tests/test_replay.py
434	I recall this form is no longer required... (maybe in conjunction of the use of `stop_after_objects` though). A direct call of `replayer.process` should be enough
451	does not `play`
454	naive form?

This revision is now accepted and ready to land.May 12 2020, 10:11 AM

typos (thx ardumont)

douardda added a child revision: D3150: Add support for anonymized journal topics.May 13 2020, 12:23 PM

Build is green

Patch application report for D3140 (id=11178)

Rebasing onto 306aa69b26...

Current branch diff-target is up to date.

Changes applied before test

commit 87f7bee6935b831a3c300cadd9afb5ce890f2292
Author: David Douard <david.douard@sdfa3.org>
Date:   Tue Apr 7 16:20:35 2020 +0200

    journal: add a skipped_content topic dedicated to SkippedContent objects
    
    instead of mixing them with Content in the content topic.

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/168/ for more details.

Harbormaster completed remote builds in B12360: Diff 11178.May 13 2020, 12:28 PM

ardumont accepted this revision.May 13 2020, 1:38 PM

Closed by commit rDSTO87f7bee6935b: journal: add a skipped_content topic dedicated to SkippedContent objects (authored by douardda). · Explain WhyMay 15 2020, 10:24 AM

This revision was automatically updated to reflect the committed changes.

douardda added a commit: rDSTO87f7bee6935b: journal: add a skipped_content topic dedicated to SkippedContent objects.