Page MenuHomeSoftware Heritage

journal: add a skipped_content topic dedicated to SkippedContent objects
ClosedPublic

Authored by douardda on Tue, May 12, 9:52 AM.

Details

Summary

instead of mixing them with Content in the content topic.

Diff Detail

Repository
rDSTO Storage manager
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

douardda created this revision.Tue, May 12, 9:52 AM

Build is green

Patch application report for D3140 (id=11158)

Rebasing onto 306aa69b26...

Current branch diff-target is up to date.
Changes applied before test
commit 6bedc5b16f443b51cbba3c0f3ceb1b3e261fd812
Author: David Douard <david.douard@sdfa3.org>
Date:   Tue Apr 7 16:20:35 2020 +0200

    journal: add a skipped_content topic dedicated to SkippedContent objects
    
    instead of mixing them with Content in the content topic.

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/167/ for more details.

ardumont accepted this revision.Tue, May 12, 10:11 AM
ardumont added a subscriber: ardumont.

Looks good.

Some questions/remarks in the diff.

swh/storage/tests/test_replay.py
435

I recall this form is no longer required... (maybe in conjunction of the use of stop_after_objects though).
A direct call of replayer.process should be enough

452

does not play

455

naive form?

This revision is now accepted and ready to land.Tue, May 12, 10:11 AM
douardda updated this revision to Diff 11178.Wed, May 13, 12:22 PM

typos (thx ardumont)

Build is green

Patch application report for D3140 (id=11178)

Rebasing onto 306aa69b26...

Current branch diff-target is up to date.
Changes applied before test
commit 87f7bee6935b831a3c300cadd9afb5ce890f2292
Author: David Douard <david.douard@sdfa3.org>
Date:   Tue Apr 7 16:20:35 2020 +0200

    journal: add a skipped_content topic dedicated to SkippedContent objects
    
    instead of mixing them with Content in the content topic.

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/168/ for more details.

ardumont accepted this revision.Wed, May 13, 1:38 PM