Fix test data: only create aware datetime objects
ClosedPublic
Actions

Authored by douardda on May 13 2020, 11:39 AM.

Details

Reviewers

Group Reviewers

Commits

rDJNL89cd8f7bea87: Fix test data: only create aware datetime objects
rDJNLbad6e3d67d50: Move OBJECT_TYPES global variable to tests/journal_data.py

Summary

Also move OBJECT_TYPES global variable to tests/journal_data.py
since it's the only user of this variable left.

Diff Detail

Repository

rDJNL Journal infrastructure

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

douardda created this revision.May 13 2020, 11:39 AM

Herald added a reviewer: Reviewers. · View Herald TranscriptMay 13 2020, 11:39 AM

douardda added a child revision: D3149: Add support for "flags" in object_type used for kafka topics.May 13 2020, 11:40 AM

Build is green

Patch application report for D3148 (id=11176)

Rebasing onto 25339889f8...

Current branch diff-target is up to date.

Changes applied before test

commit 89cd8f7bea879b989ee0609fb93923a8578cd132
Author: David Douard <david.douard@sdfa3.org>
Date:   Tue May 12 16:06:04 2020 +0200

    Fix test data: only create aware datetime objects

commit bad6e3d67d500ceffeabb308dcf4723d7a469729
Author: David Douard <david.douard@sdfa3.org>
Date:   Tue May 12 15:47:54 2020 +0200

    Move OBJECT_TYPES global variable to tests/journal_data.py
    
    since it's the only user of this variable left.

See https://jenkins.softwareheritage.org/job/DJNL/job/tests-on-diff/69/ for more details.

Harbormaster completed remote builds in B12358: Diff 11176.May 13 2020, 11:40 AM

ardumont accepted this revision.May 13 2020, 11:46 AM

This revision is now accepted and ready to land.May 13 2020, 11:46 AM

Closed by commit rDJNLbad6e3d67d50: Move OBJECT_TYPES global variable to tests/journal_data.py (authored by douardda). · Explain WhyMay 13 2020, 4:26 PM

This revision was automatically updated to reflect the committed changes.

douardda added a commit: rDJNLbad6e3d67d50: Move OBJECT_TYPES global variable to tests/journal_data.py.

douardda added a commit: rDJNL89cd8f7bea87: Fix test data: only create aware datetime objects.