Page MenuHomeSoftware Heritage

README: Update necessary dependencies for test purposes
ClosedPublic

Authored by ardumont on Wed, May 13, 11:20 AM.

Details

Summary

Without this dependencies locally, the tests will fail to run.
Better explicit that test dependencies on the readme.

Error sample without dependencies: P669

Test Plan

tox

Diff Detail

Repository
rDSEA Archive search
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont created this revision.Wed, May 13, 11:20 AM

Build has FAILED

Patch application report for D3147 (id=11174)

Rebasing onto 4dbcbc4e7d...

Current branch diff-target is up to date.
Changes applied before test
commit 684be71248fb98622016a25ee8f3b715474186af
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Wed May 13 11:18:34 2020 +0200

    README: Update necessary dependencies for test purposes

Link to build: https://jenkins.softwareheritage.org/job/DSEA/job/tests-on-diff/5/
See console output for more information: https://jenkins.softwareheritage.org/job/DSEA/job/tests-on-diff/5/console

ardumont edited the summary of this revision. (Show Details)Wed, May 13, 11:22 AM
ardumont edited the test plan for this revision. (Show Details)
ardumont added a project: Archive search.

It should mention, for non-Debian users, that it's expecting /usr/share/elasticsearch/jdk/bin/java to exist and have org.elasticsearch.bootstrap.Elasticsearch in its classpath.

vlorentz requested changes to this revision.Wed, May 13, 11:25 AM
This revision now requires changes to proceed.Wed, May 13, 11:25 AM

It should mention, for non-Debian users, that it's expecting /usr/share/elasticsearch/jdk/bin/java to exist and have org.elasticsearch.bootstrap.Elasticsearch in its classpath.

Ok.

Can you please update the swh.storage module with the equivalent information about the cassandra dependencies?

ardumont updated this revision to Diff 11175.Wed, May 13, 11:31 AM

Update according to review

Build has FAILED

Patch application report for D3147 (id=11175)

Rebasing onto 4dbcbc4e7d...

Current branch diff-target is up to date.
Changes applied before test
commit 893ed73bd633acd9e22889ff4ad524cb908981b5
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Wed May 13 11:18:34 2020 +0200

    README: Update necessary dependencies for test purposes

Link to build: https://jenkins.softwareheritage.org/job/DSEA/job/tests-on-diff/6/
See console output for more information: https://jenkins.softwareheritage.org/job/DSEA/job/tests-on-diff/6/console

ardumont edited the test plan for this revision. (Show Details)Wed, May 13, 3:31 PM
douardda accepted this revision.Wed, May 13, 3:50 PM
vlorentz accepted this revision.Wed, May 13, 3:58 PM
This revision is now accepted and ready to land.Wed, May 13, 3:58 PM

Build is green

Patch application report for D3147 (id=11187)

Rebasing onto 225ad532eb...

Current branch diff-target is up to date.
Changes applied before test
commit 586b7b96bcc27ee160e6f0e79b5fcbf289105fbc
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Wed May 13 11:18:34 2020 +0200

    README: Update necessary dependencies for test purposes

See https://jenkins.softwareheritage.org/job/DSEA/job/tests-on-diff/12/ for more details.

ardumont edited the test plan for this revision. (Show Details)Wed, May 13, 4:15 PM