typo

same, but with the actual chuck

assert object_type is unset is the class has subclasses

add the test suggested by olasd

In D3152#76660, @ardumont wrote:

Looks good.

Do you plan to add the test olasd mentioned? [1]

We should also have a test checking that no two objects types have the same object_type value. This test should check all BaseModel subclasses (instead of just stuff generated by strategies.objects).

[1] D3152#76613

so be it :-)

rename tag as object_type and use a Final instead of a Literal.

In D3152#76561, @vlorentz wrote:

And I'm not a big fan of the name. What about object_type, as we already use this name in other places?

typos (thx ardumont)

In D3151#76517, @ardumont wrote:

Remove global var and put that definition local to its use

In D3149#76484, @vlorentz wrote:

What about using a different prefix instead of adding a suffix, eg. swh.journal.anonymized_objects.?

It would require less special handling/configuration

In D3149#76430, @ardumont wrote:

I'm ok, but for one question.

Shouldn't this also accept no : in the object type (the prior behavior if i understood correctly)?

In D3149#76474, @douardda wrote:

In D3149#76428, @vlorentz wrote:

Did we already decide anonymized topics should use this name scheme?

Nope, this is a base for discussion :-)

In D3149#76428, @vlorentz wrote:

Did we already decide anonymized topics should use this name scheme?

typos (thx ardumont)

rebase

In D3137#76220, @vlorentz wrote:

we usually define a now() function at the beginning of modules to return an aware datetime, but that's ok too

several typos reported by anlambert

typo in commit message

In D3130#76039, @anlambert wrote:

Looks good to me. Just one nitpick, there is some typos in commit messages:

• instanciation -> instantiation
• instanciating -> instantiating

fix a few typos

few changes according to comments on IRC

Preferred solution: D3126

In D3122#75850, @vlorentz wrote:

why was get_journal_client removed from swh.journal.cli?

All the code you're adding in swh/search/cli.py should be in swh-journal, so it can be used by other CLIs using a journal client

nice work! thx

I'd like one or 2 comments (as stated in the comment above), and I don't like the inheritance between PrefixedAzureCloudObjStorage and AzureCloudObjStorage, but that's not the object of this diff.

Let's consider this is done now.

closed by d33d009d1fb9b89d47df3476c7da86c88b1d4035

correct django pinning