Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/cypress-diff/509/ for more details.
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
All Stories
Jan 27 2020
Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/cypress-diff/508/ for more details.
Build was aborted
Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/cypress-diff/507/ for more details.
Build was aborted
Remove unneeded possessive form
Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/904/ for more details.
utils.py: function to get a parsed persistent identifier
Probably doesn't anymore since we moved to confluent-kafka
In D2582#61509, @DanSeraf wrote:Should i handle the error in parse_persistent_identifier while creating the pid?
In D2582#61501, @vlorentz wrote:
- returning 400 instead of 500 for invalid pid, type annotation on lookup_missing_hashes
This part is ok now, but cf my earlier comment: "You should add a small wrapper around parse_persistent_identifier to handle the error, that can be shared with resolve_swh_persistent_id."
- returning 400 instead of 500 for invalid pid, type annotation on lookup_missing_hashes
Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/903/ for more details.
fix /known/ test expected values
Build has FAILED
minor changes, rebase
Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/901/ for more details.
- returning 400 instead of 500 for invalid pid, type annotation on lookup_missing_hashes
- rebase
Could you add tests?
Build is green
See https://jenkins.softwareheritage.org/job/DCORE/job/tox/397/ for more details.
Build is green
See https://jenkins.softwareheritage.org/job/DCORE/job/tox/396/ for more details.
rebase
add missing dep
Build has FAILED
remove commit
In D2586#61408, @ardumont wrote:As it's in core though, I'm unsure about the impacts so if someone else could review as well, that'd be neat.
I don't think I've actually seen this specific symptom in prod again, and if so only on workers that were hung up on something else already. We can reopen it if we notice it again.
Adapt according to review
You shouldn't remove the handling of ValidationError exceptions; because it raises an error 500 Internal Server Error, which should only be returned if there is a bug in the server code.
It's deployed btw.
Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/900/ for more details.
- /known/ endpoint tests
- test_service: testing missing hashes lookup with present pids
I agree with the reasoning in the description.
I started the review and asked for docstring updates.
I was gonna ask to add types as well.
But i stopped.
Jan 26 2020
Jan 24 2020
Build has FAILED
- known moved to identifiers view, parse pids before grouping them
- test present pids
Build has FAILED