Page MenuHomeSoftware Heritage

Add tests for db_transaction and db_transaction_generator.
ClosedPublic

Authored by vlorentz on Jan 24 2020, 5:39 PM.

Diff Detail

Repository
rDCORE Foundations and core functionalities
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Jan 24 2020, 5:39 PM
vlorentz updated this revision to Diff 9220.Jan 24 2020, 5:40 PM

remove useless fixture

vlorentz updated this revision to Diff 9223.Jan 24 2020, 5:54 PM

add missing dep

looks like D2585 and D2586 are entangled together.

vlorentz updated this revision to Diff 9232.Jan 27 2020, 1:28 PM

remove commit

vlorentz updated this revision to Diff 9233.Jan 27 2020, 1:35 PM

add missing dep

ardumont accepted this revision.Jan 28 2020, 2:10 PM
ardumont added inline comments.
swh/core/db/tests/test_db.py
191

not used, most probably wrong commit.

This revision is now accepted and ready to land.Jan 28 2020, 2:10 PM
vlorentz added inline comments.Jan 28 2020, 2:41 PM
swh/core/db/tests/test_db.py
191

it is used. The test checks it raises a ValueError.

ardumont added inline comments.Jan 28 2020, 2:42 PM
swh/core/db/tests/test_db.py
191

heh, missed it ;)