• MANIFEST.in: ship py.typed

In D2019#46745, @vlorentz wrote:

It does

• mypy: ignore django-stubs, needed only by hypothesis
• identifiers.py: do not inherit from on-the-fly namedtuple

• mypy: ignore django-stubs, needed only by hypothesis

• mypy: use conffile to ignore requests_mock

• mypy.ini: remove left-over sample section

In T2012#37261, @zack wrote:

Count me as -1 on this.

Strict rules like these tend to get in the way of getting work done when you need it.

From what you wrote, what I think will actually fix your problem is seeing the OK/KO CI marker in the list of pending review requests, so that you can just skip the ones with failing build without having to click them. Would that be enough?

@sunweaver here it is then: https://annex.softwareheritage.org/public/scratch/36489f4afbc3d2d3a43bf00d79f03deb4e9ed5f7.gz

In D1999#46513, @vlorentz wrote:

find swh docs -name '*.py' -o -name '*.rst' | xargs -r codespell -r "[\\w\\-'’\`]*[\\w\\-’\`]"

> (the default regexp is: https://github.com/codespell-project/codespell/blob/d7fa1e4/codespell_lib/_codespell.py#L29 )

closed in 43a9bf761d73b419a63d040ae335eceeadf852d9

@sunweaver: the bundle is ready, in theory you should be able to obtain it like this:

$ wget https://archive.softwareheritage.org/api/1/vault/revision/85678b0d6c52d6fd0af50c8e493c74dd15a7115d/gitfast/raw/ -O 85678b0d6c52d6fd0af50c8e493c74dd15a7115d.gitfast.gz
$ git init
$ zcat 85678b0d6c52d6fd0af50c8e493c74dd15a7115d.gitfast.gz | git fast-import

I say in theory because (due to T885) download of large bundles is a bit flaky right now.

see T1964 for a concrete example where the lack of streaming is causing problems (after the cooking, when the bundle is ready)

$ wget https://archive.softwareheritage.org/api/1/vault/revision/85678b0d6c52d6fd0af50c8e493c74dd15a7115d/gitfast/raw/
--2019-09-19 11:43:50--  https://archive.softwareheritage.org/api/1/vault/revision/85678b0d6c52d6fd0af50c8e493c74dd15a7115d/gitfast/raw/
Resolving archive.softwareheritage.org (archive.softwareheritage.org)... 128.93.193.31
Connecting to archive.softwareheritage.org (archive.softwareheritage.org)|128.93.193.31|:443... connected.
HTTP request sent, awaiting response... 200 OK
Length: 539845226 (515M) [application/gzip]
Saving to: ‘index.html’

In D1999#46506, @vlorentz wrote:

Why these three? We use single quotes everywhere.

Count me as -1 on this.

• trigger CI

• trigger CI

So, this is now actually working (@rdicosmo just tried it again) *but* the bundle stops being assembled shortly before finishing due to a maximum size limit of ~500 MB:

FWIW, Jenkins fails on this diff with:

Checking patch java/server/src/main/java/org/softwareheritage/graph/Entry.java...
error: java/server/src/main/java/org/softwareheritage/graph/Entry.java: does not exist in index

Looks like a spurious CI error?

In addition to the minor comment above, a few bare-bone tests that spawn the aiohttp daemon and try to actually query would be really nice. The toolchain has several moving parts, I can easily see it breaking unexpectedly.

closed in 11f8bbbadf3c187ac23029028bbabbbd8b040fdf