Differential D2012

db_testing.py: do not explode when TEST_DB_DUMP = None
ClosedPublic
Actions

Authored by zack on Sep 19 2019, 6:14 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Commits

rDCORE8faa3254ccbf: db_testing.py: do not explode when TEST_DB_DUMP = None

Summary

None is the default value, and sub-classes could possible not redefine it to be
an empty list. Hence, this change provides a sane default for downstream users.

Test Plan

tox

Diff Detail

Repository

rDCORE Foundations and core functionalities

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

zack created this revision.Sep 19 2019, 6:14 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptSep 19 2019, 6:14 PM

Build is green
See https://jenkins.softwareheritage.org/job/DCORE/job/tox/286/ for more details.

Harbormaster completed remote builds in B7868: Diff 6759.Sep 19 2019, 6:16 PM

ardumont accepted this revision.Sep 19 2019, 9:22 PM

This revision is now accepted and ready to land.Sep 19 2019, 9:22 PM

Closed by commit rDCORE8faa3254ccbf: db_testing.py: do not explode when TEST_DB_DUMP = None (authored by zack). · Explain WhySep 19 2019, 10:07 PM

This revision was automatically updated to reflect the committed changes.

zack added a commit: rDCORE8faa3254ccbf: db_testing.py: do not explode when TEST_DB_DUMP = None.

Revision Contents
Changeset List

Path

Size

swh/

core/

db/

tests/

db_testing.py

4 lines

Diff 6761

View Options

swh/core/db/tests/db_testing.py

db_testing.py: do not explode when TEST_DB_DUMP = NoneClosedPublicActions