Details

Reviewers

Group Reviewers

Commits

rDLS22f2f2c43c5d: core: make it possible to specify the api_baseurl init argument in…

Summary

This is required to be able to make lister classes instanciation easier and more
reliable, especially in the context of cli tools like 'swh lister run', for which
we want to be able to specify any lister init argument as extra parameter of the
command.

Depends on D1929

Diff Detail

Repository

rDLS Listers

Branch

master

Lint

Lint Skipped

Unit

Unit Tests Skipped

Build Status

Buildable 7570
Build 10835: tox-on-jenkins	Jenkins
Build 10834: arc lint + arc unit

Event Timeline

douardda created this revision.Aug 30 2019, 6:03 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptAug 30 2019, 6:03 PM

douardda added a child revision: D1931: bitbucket: make BitBucketLister's api_baseurl init argument optional.Aug 30 2019, 6:04 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DLS/job/tox/315/
See console output for more information: https://jenkins.softwareheritage.org/job/DLS/job/tox/315/console

Harbormaster failed remote builds in B7542: Diff 6486!Aug 30 2019, 6:15 PM

That simplifies and unifies the lister instantiation, /me likes.
I also agree with all the other diffs depending on this diff.
Thanks.

I guess the build failure is because you'll change the cli call later (get_lister is currently unhappy) or is that an arc patch order missed from jenkins?

ardumont accepted this revision.Sep 1 2019, 11:06 AM

This revision is now accepted and ready to land.Sep 1 2019, 11:06 AM

rebase

Harbormaster failed remote builds in B7563: Diff 6500!Sep 2 2019, 12:16 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DLS/job/tox/322/
See console output for more information: https://jenkins.softwareheritage.org/job/DLS/job/tox/322/console