Page MenuHomeSoftware Heritage

core: make it possible to specify the api_baseurl init argument in override_config
ClosedPublic

Authored by douardda on Aug 30 2019, 6:03 PM.

Details

Summary

This is required to be able to make lister classes instanciation easier and more
reliable, especially in the context of cli tools like 'swh lister run', for which
we want to be able to specify any lister init argument as extra parameter of the
command.

Depends on D1929

Diff Detail

Repository
rDLS Listers
Branch
master
Lint
Lint Skipped
Unit
Unit Tests Skipped
Build Status
Buildable 7570
Build 10835: tox-on-jenkinsJenkins
Build 10834: arc lint + arc unit

Event Timeline

That simplifies and unifies the lister instantiation, /me likes.
I also agree with all the other diffs depending on this diff.
Thanks.


I guess the build failure is because you'll change the cli call later (get_lister is currently unhappy) or is that an arc patch order missed from jenkins?

This revision is now accepted and ready to land.Sep 1 2019, 11:06 AM
This revision was landed with ongoing or failed builds.Sep 2 2019, 1:17 PM
This revision was automatically updated to reflect the committed changes.