Has no proper test yet (T1393). I'm going to send a diff that uses it for swh.deposit.
Diff Detail
Diff Detail
- Repository
- rDLDBASE Generic VCS/Package Loader
- Branch
- master
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 2649 Build 3296: tox-on-jenkins Jenkins Build 3295: arc lint + arc unit
Event Timeline
Comment Actions
Build has FAILED
Link to build: https://jenkins.softwareheritage.org/job/DLDBASE/job/tox/27/
See console output for more information: https://jenkins.softwareheritage.org/job/DLDBASE/job/tox/27/console
Comment Actions
Build has FAILED
Link to build: https://jenkins.softwareheritage.org/job/DLDBASE/job/tox/30/
See console output for more information: https://jenkins.softwareheritage.org/job/DLDBASE/job/tox/30/console
Comment Actions
Build has FAILED
Link to build: https://jenkins.softwareheritage.org/job/DLDBASE/job/tox/31/
See console output for more information: https://jenkins.softwareheritage.org/job/DLDBASE/job/tox/31/console
Comment Actions
Build is green
See https://jenkins.softwareheritage.org/job/DLDBASE/job/tox/33/ for more details.
| swh/loader/core/tests/__init__.py | ||
|---|---|---|
| 196 | I realize this it not a problem introduced by this diffs, but FWIW the naming of all these assertion should be assertFooEqual, not assertFooOk, because that is what they're testing. If would be just awesome if you could take the chance of this change to refactor that :-) Your example, though, makes this distinction particularly relevant. Because for metadata (which are dictionaries) it would make sense to both asserts equality and to assert that the expected metadata are a subset of the obtained one, as in the future we might end up detecting more metadata, and making old tests failing only due to that might not be what we want, at least in some cases. | |
Comment Actions
Build is green
See https://jenkins.softwareheritage.org/job/DLDBASE/job/tox/56/ for more details.