Paths

Table of Contentst

Differential D777

Add test_origin_metadata, and fix a bug.
ClosedPublic
Actions

Authored by vlorentz on Dec 5 2018, 12:09 PM.

Tags

None

Subscribers

Details

Reviewers

Group Reviewers

Commits

rDLDBASEc343d6e84c42: Add test_origin_metadata, and fix a bug.

Diff Detail

Repository

rDLDBASE Generic VCS/Package Loader

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Dec 5 2018, 12:09 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptDec 5 2018, 12:09 PM

Fix test.

Build is green
See https://jenkins.softwareheritage.org/job/DLDBASE/job/tox/68/ for more details.

Harbormaster completed remote builds in B2849: Diff 2442.Dec 5 2018, 12:11 PM

Harbormaster completed remote builds in B2851: Diff 2444.

Build is green
See https://jenkins.softwareheritage.org/job/DLDBASE/job/tox/69/ for more details.

vlorentz mentioned this in D721: Remove Storage mock..Dec 5 2018, 1:18 PM

vlorentz added a child revision: D721: Remove Storage mock..Dec 5 2018, 2:22 PM

ardumont accepted this revision.Dec 5 2018, 2:28 PM

ardumont added a subscriber: ardumont.

ardumont added inline comments.

swh/loader/core/tests/test_loader.py
269	I'm unclear about that first call. I know that in other diff, you comment alongside saying that it initializes the loader. But i'm still unsure ;) Other than that, sounds good.

This revision is now accepted and ready to land.Dec 5 2018, 2:28 PM

vlorentz marked an inline comment as done.Dec 5 2018, 2:29 PM

vlorentz added inline comments.

swh/loader/core/tests/test_loader.py
269	It sets `self.origin_id` and stuff. Nothing interesting.

rebase

Closed by commit rDLDBASEc343d6e84c42: Add test_origin_metadata, and fix a bug. (authored by vlorentz). · Explain WhyDec 5 2018, 2:30 PM

This revision was automatically updated to reflect the committed changes.

Harbormaster failed remote builds in B2868: Diff 2459!Dec 5 2018, 2:30 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DLDBASE/job/tox/71/
See console output for more information: https://jenkins.softwareheritage.org/job/DLDBASE/job/tox/71/console

ardumont added inline comments.Dec 5 2018, 2:30 PM

swh/loader/core/tests/test_loader.py
269	ah yes, was wondering about that. I just never connected the 2. cool

Revision Contents
Changeset List

Path

Size

swh/

loader/

core/

tests/

2 lines

49 lines

Diff 2460

swh/loader/core/tests/init.py

Loading...

swh/loader/core/tests/test_loader.py

Loading...