Page MenuHomeSoftware Heritage

Add test_origin_metadata, and fix a bug.
ClosedPublic

Authored by vlorentz on Wed, Dec 5, 12:09 PM.

Diff Detail

Repository
rDLDBASE Generic VCS Loader
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Wed, Dec 5, 12:09 PM
vlorentz updated this revision to Diff 2444.Wed, Dec 5, 12:11 PM
  • Fix test.
Harbormaster completed remote builds in B2851: Diff 2444.
ardumont accepted this revision.Wed, Dec 5, 2:28 PM
ardumont added a subscriber: ardumont.
ardumont added inline comments.
swh/loader/core/tests/test_loader.py
270

I'm unclear about that first call.
I know that in other diff, you comment alongside saying that it initializes the loader.
But i'm still unsure ;)

Other than that, sounds good.

This revision is now accepted and ready to land.Wed, Dec 5, 2:28 PM
vlorentz marked an inline comment as done.Wed, Dec 5, 2:29 PM
vlorentz added inline comments.
swh/loader/core/tests/test_loader.py
270

It sets self.origin_id and stuff. Nothing interesting.

vlorentz updated this revision to Diff 2459.Wed, Dec 5, 2:29 PM
  • rebase
This revision was automatically updated to reflect the committed changes.
ardumont added inline comments.Wed, Dec 5, 2:30 PM
swh/loader/core/tests/test_loader.py
270

ah yes, was wondering about that.
I just never connected the 2.

cool