Differential D716

Fix column name in metadata_provider_get.
ClosedPublic
Actions

Authored by vlorentz on Nov 27 2018, 5:59 PM.

Tags

None

Subscribers

ardumont, swh-public-ci

Details

Reviewers

Group Reviewers

Commits

rDSTOf203821ec74f: Fix column name in metadata_provider_get.
R65:f203821ec74f: Fix column name in metadata_provider_get.
rDSTOCf203821ec74f: Fix column name in metadata_provider_get.

Test Plan

Test coverage will come in the next diff

Diff Detail

Repository

rDSTO Storage manager

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Nov 27 2018, 5:59 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptNov 27 2018, 5:59 PM

vlorentz added a child revision: D717: Fix documented return type of metadata_provider_add..Nov 27 2018, 6:01 PM

Build is green
See https://jenkins.softwareheritage.org/job/DSTO/job/tox/125/ for more details.

Harbormaster completed remote builds in B2643: Diff 2269.Nov 27 2018, 6:04 PM

vlorentz added a child revision: D721: Remove Storage mock..Nov 27 2018, 6:51 PM

Isn't this tested?

No. But it should.

Add test for metadata_provider_get.

Harbormaster completed remote builds in B2672: Diff 2294.Nov 29 2018, 10:28 AM

Build is green
See https://jenkins.softwareheritage.org/job/DSTO/job/tox/127/ for more details.

No. But it should.

Damn right!

This revision is now accepted and ready to land.Nov 29 2018, 11:34 AM

Closed by commit rDSTOf203821ec74f: Fix column name in metadata_provider_get. (authored by vlorentz). · Explain WhyNov 29 2018, 2:40 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			swh/storage/db.py (2 lines)
M			swh/storage/tests/test_storage.py (20 lines)

Diff 2309

swh/storage/db.py

Loading...

swh/storage/tests/test_storage.py

Loading...