Page MenuHomeSoftware Heritage

Consume the iterator returned by tool_add.
ClosedPublic

Authored by vlorentz on Tue, Nov 27, 6:35 PM.

Details

Reviewers
douardda
Group Reviewers
Reviewers
Test Plan

Unfortunately, this file has no proper test, see T1393. I'm going to send a diff to swh.deposit that cover this, though.

Diff Detail

Repository
rDLDBASE Generic VCS Loader
Branch
tool_add
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 2735
Build 3422: tox-on-jenkinsJenkins
Build 3421: arc lint + arc unit

Event Timeline

vlorentz created this revision.Tue, Nov 27, 6:35 PM
douardda requested changes to this revision.Thu, Nov 29, 3:37 PM
douardda added a subscriber: douardda.

Please explain why you need to consume the iterator in your commit message or as a comment in the code.

This revision now requires changes to proceed.Thu, Nov 29, 3:37 PM
vlorentz updated this revision to Diff 2333.Fri, Nov 30, 10:13 AM
  • Explain in the commit message why list() is needed.
douardda accepted this revision.Fri, Nov 30, 12:03 PM
This revision is now accepted and ready to land.Fri, Nov 30, 12:03 PM
vlorentz updated this revision to Diff 2355.Fri, Nov 30, 12:22 PM
  • git magic