Page MenuHomeSoftware Heritage
Differential D721

Remove Storage mock.
ClosedPublic
Actions

Authored by vlorentz on Nov 27 2018, 6:51 PM.

Details

Reviewers
ardumont
Group Reviewers
Reviewers
Maniphest Tasks
T1307: Remove mock storages used in tests.
Commits
rDDEPfb46af33e369: Update class names.
rDDEPd17dff963c0e: Remove Storage mock.
Summary

Depends on D716, D717, D718, D719, D720.

Diff Detail

Repository
rDDEP Push deposit
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Nov 27 2018, 6:51 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptNov 27 2018, 6:51 PM
swh-public-ci added a subscriber: swh-public-ci.Nov 27 2018, 6:54 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DDEP/job/tox/14/
See console output for more information: https://jenkins.softwareheritage.org/job/DDEP/job/tox/14/console

Harbormaster failed remote builds in B2650: Diff 2276!Nov 27 2018, 6:54 PM
ardumont accepted this revision.Nov 28 2018, 5:34 PM
ardumont added a subscriber: ardumont.

sounds about right.

This revision is now accepted and ready to land.Nov 28 2018, 5:34 PM
vlorentz updated this revision to Diff 2448.Dec 5 2018, 1:15 PM
  • Fix test.
swh-public-ci added a comment.Dec 5 2018, 1:15 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DDEP/job/tox/17/
See console output for more information: https://jenkins.softwareheritage.org/job/DDEP/job/tox/17/console

swh-public-ci added a comment.Dec 5 2018, 1:18 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DDEP/job/tox/19/
See console output for more information: https://jenkins.softwareheritage.org/job/DDEP/job/tox/19/console

Harbormaster failed remote builds in B2855: Diff 2448!Dec 5 2018, 1:18 PM
vlorentz added a comment.Dec 5 2018, 1:18 PM

Build will be fixed after D777 gets merged and tagged.

vlorentz added a task: T1307: Remove mock storages used in tests..Dec 5 2018, 1:42 PM
vlorentz added a parent revision: D777: Add test_origin_metadata, and fix a bug..Dec 5 2018, 2:22 PM
vlorentz updated this revision to Diff 2465.Dec 5 2018, 3:01 PM
  • Update class names.
swh-public-ci added a comment.Dec 5 2018, 3:04 PM

Build is green
See https://jenkins.softwareheritage.org/job/DDEP/job/tox/73/ for more details.

Harbormaster completed remote builds in B2877: Diff 2465.Dec 5 2018, 3:04 PM
vlorentz updated this revision to Diff 2467.Dec 5 2018, 3:05 PM
  • Rebase
Closed by commit rDDEPd17dff963c0e: Remove Storage mock. (authored by vlorentz). · Explain WhyDec 5 2018, 3:05 PM
This revision was automatically updated to reflect the committed changes.
Harbormaster failed remote builds in B2880: Diff 2467!Dec 5 2018, 3:06 PM
swh-public-ci added a comment.Dec 5 2018, 3:06 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DDEP/job/tox/74/
See console output for more information: https://jenkins.softwareheritage.org/job/DDEP/job/tox/74/console

Revision Contents
Changeset List

PathSize
swh/
deposit/
tests/
20 lines
api/
12 lines
loader/
182 lines

Diff 2468

View Options

swh/deposit/tests/__init__.py

Loading...
View Options

swh/deposit/tests/api/test_deposit_read_metadata.py

Loading...
View Options

swh/deposit/tests/loader/test_loader.py

Loading...
About · Developer information · Legal