Page MenuHomeSoftware Heritage

Rename equality test methods.
ClosedPublic

Authored by vlorentz on Tue, Dec 4, 4:28 PM.

Diff Detail

Repository
rDLDBASE Generic VCS Loader
Branch
rename-equality-test-methods
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 2832
Build 3569: tox-on-jenkinsJenkins
Build 3568: arc lint + arc unit

Event Timeline

vlorentz created this revision.Tue, Dec 4, 4:28 PM
vlorentz planned changes to this revision.Tue, Dec 4, 4:29 PM
vlorentz updated this revision to Diff 2422.Tue, Dec 4, 4:54 PM
  • Fix name.
  • Add aliases for old method names, that show a warning.
vlorentz updated this revision to Diff 2424.Wed, Dec 5, 10:25 AM
  • Rename file (I'll use the same file name in other tests).
vlorentz updated this revision to Diff 2425.Wed, Dec 5, 10:59 AM
  • Rebase
anlambert accepted this revision.Wed, Dec 5, 11:25 AM
anlambert added a subscriber: anlambert.

Apart some verb that should be in imperative form in some docstrings, looks good to me

swh/loader/core/tests/__init__.py
44

s/Checks/Check/

57

s/Checks/Check/

79

s/Checks/Check/

146

s/Checks/Check/

This revision is now accepted and ready to land.Wed, Dec 5, 11:25 AM
vlorentz updated this revision to Diff 2428.Wed, Dec 5, 11:25 AM
  • Remove compatibility aliases, we're completely breaking them anyway.
vlorentz updated this revision to Diff 2429.Wed, Dec 5, 11:26 AM
  • Rename.
vlorentz updated this revision to Diff 2431.Wed, Dec 5, 11:27 AM
  • Squash
Harbormaster failed remote builds in B2830: Diff 2429!
vlorentz closed this revision.Wed, Dec 5, 11:28 AM