Page MenuHomeSoftware Heritage
Differential D772

Rename equality test methods.
ClosedPublic
Actions

Authored by vlorentz on Dec 4 2018, 4:28 PM.

Details

Reviewers
anlambert
Group Reviewers
Reviewers
Summary

https://forge.softwareheritage.org/D720#inline-4081

Diff Detail

Repository
rDLDBASE Generic VCS/Package Loader
Branch
rename-equality-test-methods
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 2832
Build 3569: tox-on-jenkinsJenkins
Build 3568: arc lint + arc unit

Event Timeline

vlorentz created this revision.Dec 4 2018, 4:28 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptDec 4 2018, 4:28 PM
vlorentz planned changes to this revision.Dec 4 2018, 4:29 PM
swh-public-ci added a subscriber: swh-public-ci.Dec 4 2018, 4:30 PM

Build is green
See https://jenkins.softwareheritage.org/job/DLDBASE/job/tox/57/ for more details.

Harbormaster completed remote builds in B2820: Diff 2420.Dec 4 2018, 4:30 PM
vlorentz updated this revision to Diff 2422.Dec 4 2018, 4:54 PM
  • Fix name.
  • Add aliases for old method names, that show a warning.
swh-public-ci added a comment.Dec 4 2018, 4:55 PM

Build is green
See https://jenkins.softwareheritage.org/job/DLDBASE/job/tox/58/ for more details.

Harbormaster completed remote builds in B2822: Diff 2422.Dec 4 2018, 4:55 PM
vlorentz mentioned this in D720: Add assertOriginMetadataOk..Dec 5 2018, 10:03 AM
vlorentz updated this revision to Diff 2424.Dec 5 2018, 10:25 AM
  • Rename file (I'll use the same file name in other tests).
Harbormaster failed remote builds in B2825: Diff 2424!Dec 5 2018, 10:26 AM
swh-public-ci added a comment.Dec 5 2018, 10:26 AM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DLDBASE/job/tox/59/
See console output for more information: https://jenkins.softwareheritage.org/job/DLDBASE/job/tox/59/console

vlorentz updated this revision to Diff 2425.Dec 5 2018, 10:59 AM
  • Rebase
swh-public-ci added a comment.Dec 5 2018, 11:00 AM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DLDBASE/job/tox/60/
See console output for more information: https://jenkins.softwareheritage.org/job/DLDBASE/job/tox/60/console

Harbormaster failed remote builds in B2826: Diff 2425!Dec 5 2018, 11:00 AM
anlambert accepted this revision.Dec 5 2018, 11:25 AM
anlambert added a subscriber: anlambert.

Apart some verb that should be in imperative form in some docstrings, looks good to me

swh/loader/core/tests/__init__.py
43

s/Checks/Check/

56

s/Checks/Check/

78

s/Checks/Check/

146

s/Checks/Check/

This revision is now accepted and ready to land.Dec 5 2018, 11:25 AM
vlorentz updated this revision to Diff 2428.Dec 5 2018, 11:25 AM
  • Remove compatibility aliases, we're completely breaking them anyway.
vlorentz updated this revision to Diff 2429.Dec 5 2018, 11:26 AM
  • Rename.
vlorentz updated this revision to Diff 2431.Dec 5 2018, 11:27 AM
  • Squash
swh-public-ci added a comment.Dec 5 2018, 11:27 AM

Build is green
See https://jenkins.softwareheritage.org/job/DLDBASE/job/tox/63/ for more details.

Harbormaster completed remote builds in B2829: Diff 2428.Dec 5 2018, 11:27 AM
Harbormaster failed remote builds in B2830: Diff 2429!
swh-public-ci added a comment.Dec 5 2018, 11:27 AM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DLDBASE/job/tox/64/
See console output for more information: https://jenkins.softwareheritage.org/job/DLDBASE/job/tox/64/console

Harbormaster failed remote builds in B2832: Diff 2431!Dec 5 2018, 11:27 AM
swh-public-ci added a comment.Dec 5 2018, 11:27 AM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DLDBASE/job/tox/65/
See console output for more information: https://jenkins.softwareheritage.org/job/DLDBASE/job/tox/65/console

vlorentz added a comment.Dec 5 2018, 11:28 AM

Landed in 39496027b27f31167de2fdcb107ef5c7efbd4901.

vlorentz closed this revision.Dec 5 2018, 11:28 AM

Revision Contents
Changeset List

PathSize
swh/
loader/
core/
tests/
47 lines

Diff 2431

View Options

swh/loader/core/tests/__init__.py

Loading...
About · Developer information · Legal