Adapt what's possible from the last round of review
Thanks!
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed All Stories
All Stories
All Stories
Jan 25 2022
Jan 25 2022
Wrap command call with chronic
Jenkins for Software Heritage <jenkins@jenkins-debian1.internal.softwareheritage.org> committed rDSTO271a259ae50c: Updated backport on buster-swh from debian/0.42.0-1_swh1 (unstable-swh) (authored by Jenkins for Software Heritage <jenkins@jenkins-debian1.internal.softwareheritage.org>).
Updated backport on buster-swh from debian/0.42.0-1_swh1 (unstable-swh)
Jenkins for Software Heritage <jenkins@jenkins-debian1.internal.softwareheritage.org> committed rDSTO8079f65a9e19: Merge tag 'debian/0.42.0-1_swh1' into debian/buster-swh (authored by Jenkins for Software Heritage <jenkins@jenkins-debian1.internal.softwareheritage.org>).
Merge tag 'debian/0.42.0-1_swh1' into debian/buster-swh
Build is green
Build passed on Jenkins, great ! Abandoning this, will land it later.
vsellier committed rDDOC4ac8648fb0a7: Document the mirror credentials management (authored by vsellier).
Document the mirror credentials management
- rebase
- update according the feedback
Make the script fail fast
Adapt according to review
Jenkins for Software Heritage <jenkins@jenkins-debian1.internal.softwareheritage.org> committed rDSTO121b00c50361: pristine-tar data for swh-storage_0.42.0.orig.tar.gz (authored by Jenkins for Software Heritage <jenkins@jenkins-debian1.internal.softwareheritage.org>).
pristine-tar data for swh-storage_0.42.0.orig.tar.gz
Jenkins for Software Heritage <jenkins@jenkins-debian1.internal.softwareheritage.org> committed rDSTOb752a68566ae: Updated debian changelog for version 0.42.0 (authored by Jenkins for Software Heritage <jenkins@jenkins-debian1.internal.softwareheritage.org>).
Updated debian changelog for version 0.42.0
Jenkins for Software Heritage <jenkins@jenkins-debian1.internal.softwareheritage.org> committed rDSTOc2a93a6f4dbf: Update upstream source from tag 'debian/upstream/0.42.0' (authored by Jenkins for Software Heritage <jenkins@jenkins-debian1.internal.softwareheritage.org>).
Update upstream source from tag 'debian/upstream/0.42.0'
Jenkins for Software Heritage <jenkins@jenkins-debian1.internal.softwareheritage.org> committed rDSTObedc3722881b: New upstream version 0.42.0 (authored by Jenkins for Software Heritage <jenkins@jenkins-debian1.internal.softwareheritage.org>).
New upstream version 0.42.0
olasd committed rDSNIP27369c56cac9: recover_corrupt_objects: Remove spurious select (authored by olasd).
recover_corrupt_objects: Remove spurious select
olasd committed rDSNIP44fe78774db2: recover_corrupt_objects: Pull config from a configfile instead of the cli (authored by olasd).
recover_corrupt_objects: Pull config from a configfile instead of the cli
In D7033#182832, @olasd wrote:Thanks! (and sorry for the hash algo ping-pong)
anlambert requested review of D7032: assets/highlightjs: Add new languages to highlight and fix some issues.
LGTM
thanks, just a small inlined remark regarding the httpie package installation
Build is green
anlambert requested review of D7034: common/origin_save: Fix extraction of elasticsearch document fields.
add logging
remove the 'scribe' attribution
In D7029#182839, @olasd wrote:I wonder if that'd be worth a warning. May end up being a bit noisy though.
Actually send the email instead of just displaying it
ardumont added a revision to T3877: Automate the weekly-planning script: D7035: Automate weekly-planning script.
I wonder if that'd be worth a warning. May end up being a bit noisy though.
the desired key len is 32 for sha256
Thanks! (and sorry for the hash algo ping-pong)
dachary committed rDOPHd79745c582c8: the key has a fixed len: do not hardcode it (authored by dachary).
the key has a fixed len: do not hardcode it
I'd reword the commit message as "Deduplicate hardcoded key size"
ardumont changed the status of T3877: Automate the weekly-planning script from Open to Work in Progress.
vlorentz added projects to T3887: Storing multiple authors in Revisions and Releases: Data Model, SWORD deposit.
That sounds ok to me: scm entries are deduplicated. 2 pages corresponding to the same scm entry (i.e. with the same scm url) will produce only one output.
In this sample we should indeed have 2 jars and 1 scm.
I'm answering your questions now so you can get a change to come back to me before I start working on this again tomorrow.
ardumont committed rDLSa599493b4846: maven: Let logging instruction do the formatting (authored by ardumont).
maven: Let logging instruction do the formatting
ardumont committed rDLS8667b04abcbb: maven: Add more debug logging instruction (authored by ardumont).
maven: Add more debug logging instruction
Alphare added a revision to T3888: Storing associated bugs: D6344: Non-incremental, non-delta Bazaar/Breezy loader.
vlorentz committed rDSNIP3c8ad398dabf: recover_corrupt_objects.py: Remove print, cleanup import (authored by vlorentz).
recover_corrupt_objects.py: Remove print, cleanup import
vlorentz committed rDSNIP219ca5b64358: recover_corrupt_objects.py: Double-check insertion (authored by vlorentz).
recover_corrupt_objects.py: Double-check insertion
Add recover_corrupt_objects.py
I'm not 100% convinced we need to recheck the objects at every addition (within a transaction that can still fail to commit) instead of afterwards, but it doesn't /hurt/ either. We'll make a full pass on all objects again later anyway.
vlorentz updated the task description for T3886: Representing timezones with non-integer number of minutes.
vlorentz updated the task description for T3886: Representing timezones with non-integer number of minutes.
vlorentz updated the task description for T3886: Representing timezones with non-integer number of minutes.
vlorentz updated the task description for T3886: Representing timezones with non-integer number of minutes.
vlorentz triaged T3886: Representing timezones with non-integer number of minutes as Normal priority.
dachary committed rDOBJS7b5538279be0: implement statistics collection during benchmarks (authored by dachary).
implement statistics collection during benchmarks
Build is green
doesn't matplotlib work with the built-in tkinter by default?
address review comments
ardumont closed T3873: Migrate inventory to the admin vlan, a subtask of T3850: Migrate admin apps node to admin vlan, as Resolved.
Register bojimans in the admin vlan
anlambert closed T3870: Analyze svn externals repository ingestion with loader.svn v1.0, a subtask of T3864: staging: Deploy swh.loader.svn v1.0.0, as Resolved.
anlambert closed T3870: Analyze svn externals repository ingestion with loader.svn v1.0 as Resolved.
swh-loader-svn v1.1.0 has been released, new tests have been scheduled on staging (T3875#77706).
Subversion origins that failed to load or with a partial visit status when using swh-loader-svn v1.0.0 (T3870#77580)
have been resubmitted on staging to check how many can now be fully loaded using swh-loader-svn v1.1.0.
Looks good. I trust you for the bzr part, so I didn't check it
Build is green
Rebase
ardumont renamed T3875: Deploy loader.svn v1.1 and analyze remaining errors from Deploy loader.svn v1.1 to staging: Deploy loader.svn v1.1.
staging:
- Package python3-swh.loader.svn upgraded
- Service swh-worker@loader_{svn,high_priority} restarted
ardumont moved T3875: Deploy loader.svn v1.1 and analyze remaining errors from in-progress to deployed/landed/monitoring on the System administration board.
Build is green