Page MenuHomeSoftware Heritage

Filter out extids targeting non-existing releases
ClosedPublic

Authored by vlorentz on Jan 24 2022, 6:04 PM.

Details

Reviewers
ardumont
Group Reviewers
Reviewers
Maniphest Tasks
Restricted Maniphest Task
Commits
rDLDBASE4718713b9ae0: Filter out extids targeting non-existing releases
Summary

No need to filter out revisions as well, this is already handled elsewhere.

Along with D7028, this resolves T3884.

Diff Detail

Repository
rDLDBASE Generic VCS/Package Loader
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Build is green

Patch application report for D7029 (id=25479)

Rebasing onto 78b2e9f7f4...

Current branch diff-target is up to date.
Changes applied before test
commit dddd7d49262d6f553ecf8c898a3415fd1bdf71c3
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Mon Jan 24 18:03:57 2022 +0100

    Filter out extids targeting non-existing releases
    
    No need to filter out revisions as well, this is already handled elsewhere.
    
    Along with D7028, this resolves T3884.

See https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/687/ for more details.

I wonder if that'd be worth a warning. May end up being a bit noisy though.

Or, in other words: are there any usecases where inserting an extid pointing to an object we don't have in the archive makes sense?

In D7029#182839, @olasd wrote:

I wonder if that'd be worth a warning. May end up being a bit noisy though.

Sentry recorded only two occurences so far, so it shouldn't be too noisy.

Or, in other words: are there any usecases where inserting an extid pointing to an object we don't have in the archive makes sense?

I don't see any, especially not in package loaders

Build is green

Patch application report for D7029 (id=25504)

Rebasing onto 78b2e9f7f4...

Current branch diff-target is up to date.
Changes applied before test
commit 4718713b9ae0c7fedefd82d0d5944c4871943065
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Mon Jan 24 18:03:57 2022 +0100

    Filter out extids targeting non-existing releases
    
    No need to filter out revisions as well, this is already handled elsewhere.
    
    Along with D7028, this resolves T3884.

See https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/688/ for more details.

This revision is now accepted and ready to land.Jan 26 2022, 9:46 AM