Differential D7033

the desired key len is 32 for sha256
ClosedPublic
Actions

Authored by dachary on Jan 25 2022, 3:36 PM.

Details

Reviewers

olasd

Group Reviewers

Reviewers

Commits

rDOPH3b5a0b09c9d3: the desired key len is 32 for sha256

Diff Detail

Repository

rDOPH Perfect Hash algorithm

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

dachary created this revision.Jan 25 2022, 3:36 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptJan 25 2022, 3:36 PM

Build is green

Patch application report for D7033 (id=25498)

Rebasing onto d79745c582...

Current branch diff-target is up to date.

Changes applied before test

commit 3b5a0b09c9d3174d6d27cf3693c9032502395fe2
Author: Loïc Dachary <loic@dachary.org>
Date:   Tue Jan 25 15:35:13 2022 +0100

    the desired key len is 32 for sha256

See https://jenkins.softwareheritage.org/job/DOPH/job/tests-on-diff/26/ for more details.

Harbormaster completed remote builds in B26330: Diff 25498.Jan 25 2022, 3:37 PM

dachary requested review of this revision.Jan 25 2022, 3:37 PM

Thanks! (and sorry for the hash algo ping-pong)

This revision is now accepted and ready to land.Jan 25 2022, 3:46 PM

Closed by commit rDOPH3b5a0b09c9d3: the desired key len is 32 for sha256 (authored by dachary). · Explain WhyJan 25 2022, 3:48 PM

This revision was automatically updated to reflect the committed changes.

dachary added a commit: rDOPH3b5a0b09c9d3: the desired key len is 32 for sha256.

In D7033#182832, @olasd wrote:

Thanks! (and sorry for the hash algo ping-pong)

I'm glad you caught this now!

Revision Contents
Changeset List

Path

Size

swh/

perfecthash/

hash.h

2 lines

Diff 25499

View Options

the desired key len is 32 for sha256ClosedPublicActions