- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed All Stories
All Stories
All Stories
May 6 2021
May 6 2021
vlorentz committed rDCORE4d70ee0cfab6: requirements-db-pytestplugin: Don't install pytest-postgresql 3.0+ (authored by vlorentz).
requirements-db-pytestplugin: Don't install pytest-postgresql 3.0+
Make the SourceForge lister incremental
Harbormaster failed remote builds in B21309: Diff 20327 for D5659: Make the SourceForge lister incremental!
Build has FAILED
Postfix the type aliases with "T"
Build is green
Build is green
Rebase
Refactor test detection in a function
Actions performed:
- wwn-0x5000c500d5de652a(sdb) : new -> spare
- wwn-0x5000c500a22eed6f(sdh) : spare -> mirror
- wwn-0x5000c500d5dda886(sdc) : new -> mirror
vsellier closed T3243: Replace /dev/sdb and /dev/sdc on storage1.staging, a subtask of T3236: staging: Disk error on storage1, as Resolved.
The checks ran without detecting any bad block on the disk.
They can be added on the zfs pool again.
swh-public-ci added a comment to D5685: Add new bundle type to list only when connected as privileged user.
Build is green
ardumont added a comment to D5685: Add new bundle type to list only when connected as privileged user.
Thanks adapted.
ardumont updated the diff for D5685: Add new bundle type to list only when connected as privileged user.
Adapt according to last suggestions
May 5 2021
May 5 2021
Abandoned in favor of D5687
Alphare committed rDDEP144a6e76aa6a: requirements-test: don't install pytest-postgresql 3.0+ (authored by Alphare).
requirements-test: don't install pytest-postgresql 3.0+
seirl accepted D5689: Make test_directory_bogus_perms/test_revision_bogus_perms actually test the cookers.
LGTM
vlorentz requested review of D5689: Make test_directory_bogus_perms/test_revision_bogus_perms actually test the cookers.
(tests failures are unrelated)
vlorentz requested review of D5690: requirements-db-pytestplugin: Don't install pytest-postgresql 3.0+.
swh-public-ci added a comment to D5673: origin_save: Enable to filter user submitted save requests in Web UI.
Build is green
anlambert added inline comments to D5673: origin_save: Enable to filter user submitted save requests in Web UI.
anlambert updated the diff for D5673: origin_save: Enable to filter user submitted save requests in Web UI.
Fix migrations
swh-public-ci added a comment to D5685: Add new bundle type to list only when connected as privileged user.
Build is green
swh-public-ci added a comment to D5673: origin_save: Enable to filter user submitted save requests in Web UI.
Build is green
anlambert added inline comments to D5685: Add new bundle type to list only when connected as privileged user.
anlambert planned changes to D5673: origin_save: Enable to filter user submitted save requests in Web UI.
ardumont added inline comments to D5685: Add new bundle type to list only when connected as privileged user.
changelog for the 21.1.5 version
Good day everyone,
ardumont updated the diff for D5685: Add new bundle type to list only when connected as privileged user.
- Add the last test!
- reword commit message
anlambert updated the diff for D5673: origin_save: Enable to filter user submitted save requests in Web UI.
Update: Adapt according to reviews
ardumont added inline comments to D5685: Add new bundle type to list only when connected as privileged user.
anlambert added inline comments to D5685: Add new bundle type to list only when connected as privileged user.
ardumont added inline comments to D5685: Add new bundle type to list only when connected as privileged user.
swh-public-ci added a comment to D5685: Add new bundle type to list only when connected as privileged user.
Build is green
ardumont retitled D5685: Add new bundle type to list only when connected as privileged user from Add new bundle type to list only when privileged to Add new bundle type to list only when connected as privileged user.
Harbormaster failed remote builds in B21289: Diff 20307 for D5685: Add new bundle type to list only when connected as privileged user!
swh-public-ci added a comment to D5685: Add new bundle type to list only when connected as privileged user.
Build has FAILED
first diff, achievement unlocked, w00t ;)
is stupid one though :)
anlambert added a comment to D5673: origin_save: Enable to filter user submitted save requests in Web UI.
Can't the CSS refer to custom-control input and custom-control label instead of custom-control-input and custom-control-label?
ardumont updated the diff for D5685: Add new bundle type to list only when connected as privileged user.
- Add missing tests (there remains one to uncomment and make green)
- Adapt according to suggestions
Jayesh Velayudhan <jayesh@softwareheritage.org> committed rDENVc4d30113b11d: Minor typo fix in docker documentation (authored by Jayesh Velayudhan <jayesh@softwareheritage.org>).
Minor typo fix in docker documentation
In D5686#144406, @ardumont wrote:first diff, achievement unlocked, w00t ;)
first diff, achievement unlocked, w00t ;)
ardumont added a comment to D5685: Add new bundle type to list only when connected as privileged user.
ack on what you said, thanks.
anlambert added inline comments to D5685: Add new bundle type to list only when connected as privileged user.
anlambert added inline comments to D5685: Add new bundle type to list only when connected as privileged user.
ardumont updated the summary of D5685: Add new bundle type to list only when connected as privileged user.
anlambert added a comment to D5673: origin_save: Enable to filter user submitted save requests in Web UI.
Proper solution would be to store a list of user ids in the save request model using a django ArrayField.
vlorentz committed rDENV5dff0c9216e7: Document the default user account's credentials. (authored by vlorentz).
Document the default user account's credentials.
vlorentz committed rDENVbb0a086e0e8d: Add missing dependency between swh-web and swh-scheduler. (authored by vlorentz).
Add missing dependency between swh-web and swh-scheduler.
anlambert planned changes to D5673: origin_save: Enable to filter user submitted save requests in Web UI.
anlambert added a comment to D5673: origin_save: Enable to filter user submitted save requests in Web UI.
In D5673#144347, @vlorentz wrote:I'm done now.
Last comment: when someone creates a Save request and it remains in status "not yet scheduled", and a logged in user clicks "Save again", it does not appear when this user selects "show only your requests".
I did not try with other statuses, though.Is it on purpose?
ardumont requested review of D5685: Add new bundle type to list only when connected as privileged user.
misc/origin_save: Fix black format
vlorentz added a comment to D5673: origin_save: Enable to filter user submitted save requests in Web UI.
I'm done now.
anlambert added a comment to D5673: origin_save: Enable to filter user submitted save requests in Web UI.
No API endpoint for this feature?
vlorentz requested changes to D5673: origin_save: Enable to filter user submitted save requests in Web UI.
vlorentz added a comment to D5673: origin_save: Enable to filter user submitted save requests in Web UI.
(I did not finish reviewing, but I'm marking this as "request changes" now so you don't merge it immediately)
lgtm, a couple of question/suggestion and one spurious print to drop inline ;)
vsellier closed T3307: apidoc generation is not performed on swh modules during dev build as Resolved.
ardumont added inline comments to D5673: origin_save: Enable to filter user submitted save requests in Web UI.
aeviso committed rDPROV243aa290acb1: Fixed edge-case bug in buld_isochrone_graph. (authored by aeviso).
Fixed edge-case bug in buld_isochrone_graph.
anlambert added inline comments to D5673: origin_save: Enable to filter user submitted save requests in Web UI.
vsellier committed rDDOC5e6f5d854803: Don't install the modules in editable mode (authored by vsellier).
Don't install the modules in editable mode
rebase
And I think that I found how to fix the last remaining warning cited above.
good news ;)
thanks
And I think that I found how to fix the last remaining warning cited above.
anlambert requested review of D5673: origin_save: Enable to filter user submitted save requests in Web UI.
completely remove the -e option
anlambert added inline comments to D5681: Add support to not install the dev modules in editable mode.
vlorentz committed rDDOC8ac2cde32120: Update links to Sphinx's documentation. (authored by vlorentz).
Update links to Sphinx's documentation.
vlorentz added inline comments to D5681: Add support to not install the dev modules in editable mode.
vsellier added inline comments to D5681: Add support to not install the dev modules in editable mode.