Make test_directory_bogus_perms/test_revision_bogus_perms actually test the cookers
ClosedPublic
Actions

Authored by vlorentz on May 5 2021, 7:13 PM.

Details

Reviewers

seirl
douardda

Group Reviewers

Reviewers

Commits

rDVAU3c14013bc7ee: Make test_directory_bogus_perms/test_revision_bogus_perms/ actually test the…

Summary

Bogus permissions were normalized by git because it was even loaded;
so the cooker's normalization was not actually tested.

This commit uses Dulwich instead of git to stage the changes,
and monkey-patches Dulwich to prevent it from normalizing.

Diff Detail

Repository

rDVAU Software Heritage Vault

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.May 5 2021, 7:13 PM

Build has FAILED

Patch application report for D5689 (id=20314)

Rebasing onto f87dd54d5d...

Current branch diff-target is up to date.

Changes applied before test

commit e82f5cc389538625fb8059d821768a413c5e3136
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Wed May 5 19:12:49 2021 +0200

    Make test_directory_bogus_perms actually test the cooker
    
    Bogus permissions were normalized by git because it was even loaded;
    so the cooker's normalization was not actually tested.
    
    This commit uses Dulwich instead of git to stage the changes,
    and monkey-patches Dulwich to prevent it from normalizing.

Link to build: https://jenkins.softwareheritage.org/job/DVAU/job/tests-on-diff/76/
See console output for more information: https://jenkins.softwareheritage.org/job/DVAU/job/tests-on-diff/76/console

Harbormaster returned this revision to the author for changes because remote builds failed.May 5 2021, 7:14 PM

Harbormaster failed remote builds in B21296: Diff 20314!

also test_revision_bogus_perms

Build has FAILED

Patch application report for D5689 (id=20316)

Rebasing onto f87dd54d5d...

Current branch diff-target is up to date.

Changes applied before test

commit 3c14013bc7eeb598e24122d922ba85534ac11708
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Wed May 5 19:12:49 2021 +0200

    Make test_directory_bogus_perms/test_revision_bogus_perms/ actually test the cookers
    
    Bogus permissions were normalized by git because it was even loaded;
    so the cooker's normalization was not actually tested.
    
    This commit uses Dulwich instead of git to stage the changes,
    and monkey-patches Dulwich to prevent it from normalizing.

Link to build: https://jenkins.softwareheritage.org/job/DVAU/job/tests-on-diff/77/
See console output for more information: https://jenkins.softwareheritage.org/job/DVAU/job/tests-on-diff/77/console

Harbormaster returned this revision to the author for changes because remote builds failed.May 5 2021, 7:58 PM

Harbormaster failed remote builds in B21298: Diff 20316!

(tests failures are unrelated)

LGTM

This revision is now accepted and ready to land.May 5 2021, 8:10 PM

Build is green

Patch application report for D5689 (id=20316)

Rebasing onto f87dd54d5d...

Current branch diff-target is up to date.

Changes applied before test

commit 3c14013bc7eeb598e24122d922ba85534ac11708
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Wed May 5 19:12:49 2021 +0200

    Make test_directory_bogus_perms/test_revision_bogus_perms/ actually test the cookers
    
    Bogus permissions were normalized by git because it was even loaded;
    so the cooker's normalization was not actually tested.
    
    This commit uses Dulwich instead of git to stage the changes,
    and monkey-patches Dulwich to prevent it from normalizing.

See https://jenkins.softwareheritage.org/job/DVAU/job/tests-on-diff/78/ for more details.

Harbormaster completed remote builds in B21298: Diff 20316.May 6 2021, 10:47 AM

Closed by commit rDVAU3c14013bc7ee: Make test_directory_bogus_perms/test_revision_bogus_perms/ actually test the… (authored by vlorentz). · Explain WhyMay 6 2021, 10:47 AM

This revision was automatically updated to reflect the committed changes.

vlorentz added a commit: rDVAU3c14013bc7ee: Make test_directory_bogus_perms/test_revision_bogus_perms/ actually test the….