Page MenuHomeSoftware Heritage
Feed Advanced Search

Jun 29 2022

VickyMerzOwn closed T4275: CffMapping: Add checks for value types, a subtask of T4274: Resolve all known crashes in the metadata indexer, as Resolved.
Jun 29 2022, 11:15 AM · Indexer, Metadata workflow
VickyMerzOwn closed T4275: CffMapping: Add checks for value types as Resolved.
Jun 29 2022, 11:15 AM · Easy hack, Indexer, Metadata workflow
VickyMerzOwn closed D8036: Check CFF Value Types.
Jun 29 2022, 11:01 AM
VickyMerzOwn committed rDCIDX1be4e184d4b9: cff: Add checks for value types (authored by VickyMerzOwn).
cff: Add checks for value types
Jun 29 2022, 11:01 AM
VickyMerzOwn updated the diff for D8036: Check CFF Value Types.

Applied commit on master (using cherry-pick)

Jun 29 2022, 10:46 AM
VickyMerzOwn updated the diff for D8036: Check CFF Value Types.

Adds test for invalid value for a field.
If a list(or any other type) is provided where a string is expected, the field is simply ignored.

Jun 29 2022, 9:47 AM

Jun 28 2022

VickyMerzOwn updated the task description for T4357: Metadata Indexer for Composer.
Jun 28 2022, 5:13 PM · Indexer
VickyMerzOwn triaged T4357: Metadata Indexer for Composer as Normal priority.

Sorry about the change. It was by mistake.

Jun 28 2022, 5:11 PM · Indexer
VickyMerzOwn raised the priority of T4357: Metadata Indexer for Composer from Normal to Needs Triage.
Jun 28 2022, 5:11 PM · Indexer
VickyMerzOwn created T4357: Metadata Indexer for Composer.
Jun 28 2022, 4:43 PM · Indexer
VickyMerzOwn updated the diff for D8036: Check CFF Value Types.

Squash commits

Jun 28 2022, 4:31 PM
VickyMerzOwn created P1393 License type format in composer.json.
Jun 28 2022, 4:26 PM
VickyMerzOwn updated the diff for D8036: Check CFF Value Types.

Adds test for empty fields in CFFMapping

Jun 28 2022, 11:47 AM
VickyMerzOwn updated the diff for D8036: Check CFF Value Types.

Checks value types in normalize methods
Deletes the extra function added for type checking

Jun 28 2022, 10:49 AM
VickyMerzOwn updated the diff for D8036: Check CFF Value Types.

Checks value types in normalize methods
Deletes the extra function added for type checking

Jun 28 2022, 10:22 AM

Jun 24 2022

VickyMerzOwn requested review of D8036: Check CFF Value Types.
Jun 24 2022, 9:11 PM
VickyMerzOwn added a revision to T4275: CffMapping: Add checks for value types: D8036: Check CFF Value Types.
Jun 24 2022, 8:01 PM · Easy hack, Indexer, Metadata workflow
VickyMerzOwn added a comment to T4275: CffMapping: Add checks for value types.

I'm not so sure what needs to be done here.
If some fields have no values, does it have to skip it or put some default value?

Jun 24 2022, 3:58 PM · Easy hack, Indexer, Metadata workflow

Jun 21 2022

VickyMerzOwn closed D7795: Test to detect uppercase NPM metadata file.
Jun 21 2022, 9:13 PM
VickyMerzOwn closed D8007: Fix crash when npm description is not a string.
Jun 21 2022, 1:48 PM
VickyMerzOwn committed rDCIDXbbf9dc80475a: Fix crash when npm description is not a string (authored by VickyMerzOwn).
Fix crash when npm description is not a string
Jun 21 2022, 1:48 PM
VickyMerzOwn requested review of D8007: Fix crash when npm description is not a string.
Jun 21 2022, 11:39 AM
VickyMerzOwn added a revision to T4333: test_npm_adversarial fails: D8007: Fix crash when npm description is not a string.
Jun 21 2022, 11:33 AM · Indexer
VickyMerzOwn closed T4276: CffMapping: ignore invalid yaml files, a subtask of T4274: Resolve all known crashes in the metadata indexer, as Resolved.
Jun 21 2022, 11:27 AM · Indexer, Metadata workflow
VickyMerzOwn closed T4276: CffMapping: ignore invalid yaml files as Resolved.
Jun 21 2022, 11:27 AM · Indexer, Metadata workflow
VickyMerzOwn closed D8002: CffMapping: Ignores invalid yaml files.
Jun 21 2022, 11:25 AM
VickyMerzOwn committed rDCIDX153bda12aa0d: cff: Ignore invalid yaml files (authored by VickyMerzOwn).
cff: Ignore invalid yaml files
Jun 21 2022, 11:25 AM
VickyMerzOwn updated the diff for D8002: CffMapping: Ignores invalid yaml files.

Rebased

Jun 21 2022, 11:07 AM
VickyMerzOwn updated the diff for D8002: CffMapping: Ignores invalid yaml files.

Tests cff mappings of empty yaml files
Tests cff mappings of lists in yaml files

Jun 21 2022, 11:02 AM
VickyMerzOwn added a comment to D8002: CffMapping: Ignores invalid yaml files.

Okay, got it. I have made these changes. Updated the diff title and is the summary of D8002 sufficient & correct now?

Jun 21 2022, 9:01 AM
VickyMerzOwn updated the diff for D8002: CffMapping: Ignores invalid yaml files.

Changes commit message

Jun 21 2022, 8:57 AM
VickyMerzOwn added a revision to T4276: CffMapping: ignore invalid yaml files: D8002: CffMapping: Ignores invalid yaml files.
Jun 21 2022, 8:54 AM · Indexer, Metadata workflow
VickyMerzOwn retitled D8002: CffMapping: Ignores invalid yaml files from Ignores invalid yaml files to CffMapping: Ignores invalid yaml files.
Jun 21 2022, 8:54 AM
VickyMerzOwn added a comment to D8002: CffMapping: Ignores invalid yaml files.
  1. Please mention the task you are solving in the diff description (see https://docs.softwareheritage.org/devel/contributing/git-style-guide.html )

Do I repeat which task I am solving in every diff description?
If so, I suppose I am to put as the subject, what I am changing in the diff, eg. "rebase", "fix XXX" etc in the title of the diff. Is this right?

Jun 21 2022, 8:13 AM

Jun 20 2022

VickyMerzOwn updated the diff for D8002: CffMapping: Ignores invalid yaml files.

Undo a change not for T4276

Jun 20 2022, 3:10 PM
VickyMerzOwn updated the diff for D8002: CffMapping: Ignores invalid yaml files.

Cleans commit history

Jun 20 2022, 11:33 AM
VickyMerzOwn added inline comments to D8002: CffMapping: Ignores invalid yaml files.
Jun 20 2022, 10:52 AM
VickyMerzOwn updated the diff for D8002: CffMapping: Ignores invalid yaml files.

Rebase

Jun 20 2022, 10:23 AM
VickyMerzOwn updated the diff for D8002: CffMapping: Ignores invalid yaml files.
  • Ignores invalid yaml files
  • Solves hypothesis error in T4333
Jun 20 2022, 10:04 AM

Jun 17 2022

VickyMerzOwn updated the diff for D8002: CffMapping: Ignores invalid yaml files.

Undo deletion of normalize_description

Jun 17 2022, 11:30 PM
VickyMerzOwn updated the diff for D8002: CffMapping: Ignores invalid yaml files.

Adds test for skipping invalid yaml files

Jun 17 2022, 6:53 PM
VickyMerzOwn updated the language for P1386 normalize_description method in NpmMapping class from autodetect to python.
Jun 17 2022, 6:10 PM · Indexer
VickyMerzOwn edited P1386 normalize_description method in NpmMapping class.
Jun 17 2022, 6:08 PM · Indexer
VickyMerzOwn updated the language for P1386 normalize_description method in NpmMapping class from python to autodetect.
Jun 17 2022, 6:07 PM · Indexer
VickyMerzOwn created P1386 normalize_description method in NpmMapping class.
Jun 17 2022, 6:05 PM · Indexer
VickyMerzOwn created T4333: test_npm_adversarial fails.
Jun 17 2022, 12:15 PM · Indexer
VickyMerzOwn updated the diff for D8002: CffMapping: Ignores invalid yaml files.

Logs the invalid-yaml-file-warning

Jun 17 2022, 11:34 AM
VickyMerzOwn updated the diff for D8002: CffMapping: Ignores invalid yaml files.

Logs warning of invalid yaml file

Jun 17 2022, 11:17 AM
VickyMerzOwn requested review of D8002: CffMapping: Ignores invalid yaml files.
Jun 17 2022, 10:51 AM

May 26 2022

VickyMerzOwn created P1368 Blog I: Software Heritage.
May 26 2022, 11:58 AM

May 12 2022

VickyMerzOwn committed rDCIDX3adc5a408f3f: Reformat test to detect uppercase NPM metadata file (authored by VickyMerzOwn).
Reformat test to detect uppercase NPM metadata file
May 12 2022, 5:01 PM
VickyMerzOwn closed D7823: Parametrize test to detect NPM metadata files uppercase.
May 12 2022, 5:01 PM
VickyMerzOwn committed rDCIDX59781c4735f5: Add vickymerzown to CONTRIBUTORS (authored by VickyMerzOwn).
Add vickymerzown to CONTRIBUTORS
May 12 2022, 5:01 PM
VickyMerzOwn added a comment to D7823: Parametrize test to detect NPM metadata files uppercase.

Oops... updated it :-)

May 12 2022, 4:59 PM
VickyMerzOwn updated the diff for D7823: Parametrize test to detect NPM metadata files uppercase.

Include vickymerzown in CONTRIBUTORS

May 12 2022, 4:58 PM
VickyMerzOwn retitled D7823: Parametrize test to detect NPM metadata files uppercase from Add vickymerzown to CONTRIBUTORS to Parametrize test to detect NPM metadata files uppercase.
May 12 2022, 4:52 PM
VickyMerzOwn updated the diff for D7823: Parametrize test to detect NPM metadata files uppercase.

Update title of D7823

May 12 2022, 4:50 PM
VickyMerzOwn requested review of D7823: Parametrize test to detect NPM metadata files uppercase.
May 12 2022, 4:45 PM
VickyMerzOwn added a comment to D7795: Test to detect uppercase NPM metadata file.

I did some horrible things with git. after you accepted my diff, I merged my branch to master. When I tried pushing, it was throwing an error. Turns out that I made a few commits on master before I started working on the new branch. So I tried to squash these commits on master and I squashed a couple of commits that weren't mine, to begin with. Could you please suggest what to do? Right now, it would be easy to just make the changes in a new diff. is this okay?

May 12 2022, 4:23 PM
VickyMerzOwn updated the diff for D7795: Test to detect uppercase NPM metadata file.
  • Reformat test to detect uppercase NPM metadata file
  • Add vickymerzown to CONTRIBUTORS
May 12 2022, 2:34 PM

May 11 2022

VickyMerzOwn updated the diff for D7795: Test to detect uppercase NPM metadata file.
  • Add vickymerzown to CONTRIBUTORS
May 11 2022, 8:04 PM
VickyMerzOwn updated the diff for D7795: Test to detect uppercase NPM metadata file.

Parametrize test using subTest in unittest

May 11 2022, 6:23 PM
VickyMerzOwn updated the diff for D7795: Test to detect uppercase NPM metadata file.

Test using @pytest.mark.parametrize decorator

May 11 2022, 5:37 PM

May 9 2022

VickyMerzOwn requested review of D7795: Test to detect uppercase NPM metadata file.
May 9 2022, 4:48 PM

Apr 21 2022

VickyMerzOwn closed D7608: Change misleading documentation in swh-indexer/cli.py.
Apr 21 2022, 9:47 AM
VickyMerzOwn committed rDCIDXf53ed039ef18: Change misleading documentation in swh-indexer/cli.py (authored by VickyMerzOwn).
Change misleading documentation in swh-indexer/cli.py
Apr 21 2022, 9:47 AM
VickyMerzOwn requested review of D7608: Change misleading documentation in swh-indexer/cli.py.
Apr 21 2022, 8:56 AM

Apr 20 2022

VickyMerzOwn closed D7587: Add annotations to the main function in __init__.py.
Apr 20 2022, 10:45 AM
VickyMerzOwn committed rDCIDX270a2b3c74f4: Add annotations to the__init__.py, base.py, cff.py, codemeta.py and maven.py in… (authored by VickyMerzOwn).
Add annotations to the__init__.py, base.py, cff.py, codemeta.py and maven.py in…
Apr 20 2022, 10:45 AM
VickyMerzOwn added a comment to D7587: Add annotations to the main function in __init__.py.

My pleasure... :-)

Apr 20 2022, 10:17 AM

Apr 19 2022

VickyMerzOwn updated the diff for D7587: Add annotations to the main function in __init__.py.

Squash all commits

Apr 19 2022, 11:58 PM
VickyMerzOwn updated the diff for D7587: Add annotations to the main function in __init__.py.
  • Revise annotations in base.py
Apr 19 2022, 6:08 PM
VickyMerzOwn updated the diff for D7587: Add annotations to the main function in __init__.py.

Revise annotations of and Format codemeta.py and maven.py

Apr 19 2022, 4:01 PM
VickyMerzOwn added inline comments to D7587: Add annotations to the main function in __init__.py.
Apr 19 2022, 3:51 PM
VickyMerzOwn abandoned D7592: Add annotations to the main function in __init__.py.
Apr 19 2022, 3:38 PM
VickyMerzOwn updated the diff for D7587: Add annotations to the main function in __init__.py.
  • Revise changes to base.py WRT comments
  • Revise annotatiions to cff.py
Apr 19 2022, 11:01 AM
VickyMerzOwn added a comment to T4028: Define and add a CSP to the web app.

This looks really interesting to me. How exactly can I get started? Where is the web app present? (Isn't it hosted on Docker?)

Apr 19 2022, 12:51 AM · Easy hack, Web app
VickyMerzOwn updated subscribers of T4073: add tooltip on add forge now request status .

Hello @arishmaurya , it is on the add-forge-now admin dashboard view but isn't open publicly yet (from @ardumont 's comment on https://forge.softwareheritage.org/T4078).

Apr 19 2022, 12:47 AM · Easy hack, Add Forge Now
VickyMerzOwn updated the diff for D7587: Add annotations to the main function in __init__.py.
  • Add annotations to maven.py
Apr 19 2022, 12:14 AM

Apr 18 2022

VickyMerzOwn updated the diff for D7587: Add annotations to the main function in __init__.py.
  • Add annotations to codemeta.py
Apr 18 2022, 11:28 PM
VickyMerzOwn updated the diff for D7587: Add annotations to the main function in __init__.py.
  • Add some more annotations to base.py
Apr 18 2022, 11:07 PM
VickyMerzOwn updated the diff for D7587: Add annotations to the main function in __init__.py.

Add annotations to __init__.py, base.py and cff.py

Apr 18 2022, 10:33 PM
VickyMerzOwn updated the diff for D7587: Add annotations to the main function in __init__.py.
  • Add some more annotations to base.py
  • Add some more annotations to cff.py
Apr 18 2022, 8:39 PM
VickyMerzOwn updated the diff for D7587: Add annotations to the main function in __init__.py.
  • Add annotations to cff.py
Apr 18 2022, 6:19 PM
VickyMerzOwn added a comment to D7587: Add annotations to the main function in __init__.py.
Apr 18 2022, 6:07 PM
VickyMerzOwn updated the diff for D7587: Add annotations to the main function in __init__.py.

Add annotations to cff.py

Apr 18 2022, 4:47 PM
VickyMerzOwn updated the diff for D7587: Add annotations to the main function in __init__.py.

Add annotations to base.py

Apr 18 2022, 11:54 AM
VickyMerzOwn updated the diff for D7587: Add annotations to the main function in __init__.py.

Add annotations to base.py

Apr 18 2022, 11:37 AM
VickyMerzOwn updated the diff for D7587: Add annotations to the main function in __init__.py.

Add annotations to base.py

Apr 18 2022, 11:27 AM
VickyMerzOwn added a comment to D7587: Add annotations to the main function in __init__.py.

@ardumont Is this good enough to be merged? If so, there are other annotations that need to be added and I'll create those diffs as well.

Apr 18 2022, 11:19 AM

Apr 16 2022

VickyMerzOwn updated the diff for D7587: Add annotations to the main function in __init__.py.

Add annotations to the functions in base.py

Apr 16 2022, 1:53 PM
VickyMerzOwn requested review of D7592: Add annotations to the main function in __init__.py.
Apr 16 2022, 8:36 AM
VickyMerzOwn retitled D7587: Add annotations to the main function in __init__.py from Adds annotations to the main function in __init__.py to Add annotations to the main function in __init__.py.
Apr 16 2022, 7:56 AM
VickyMerzOwn retitled D7587: Add annotations to the main function in __init__.py from Added annotations to the main function in __init__.py to Adds annotations to the main function in __init__.py.
Apr 16 2022, 7:55 AM

Apr 15 2022

VickyMerzOwn added a comment to D7587: Add annotations to the main function in __init__.py.
Apr 15 2022, 9:32 PM
VickyMerzOwn requested review of D7587: Add annotations to the main function in __init__.py.
Apr 15 2022, 11:20 AM
VickyMerzOwn added a comment to T2259: Add type annotations to metadata mappings.

While annotating, are we expected to use native Python Datatypes (like str, int, float etc.) or do I use the NewType class of the Type library as in the example below:

Apr 15 2022, 9:38 AM · Easy hack, Indexer
VickyMerzOwn added a comment to T3230: Add various markdown variants to list of intrinsic metadata files to be indexed .

Hey, I would like to work on this issue.

Sometimes these variants site side by side with the plain text ones

I didn't understand what site here means.
Could anyone help me with more info about the issue?

Apr 15 2022, 9:21 AM · Intrinsic metadata, Indexer