Differential D8007

Fix crash when npm description is not a string
ClosedPublic
Actions

Authored by VickyMerzOwn on Jun 21 2022, 11:33 AM.

Details

Reviewers

vlorentz

Group Reviewers

Reviewers

Maniphest Tasks

T4333: test_npm_adversarial fails

Commits

rDCIDXbbf9dc80475a: Fix crash when npm description is not a string

Summary

Fix T4333

Diff Detail

Repository

rDCIDX Metadata indexer

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

VickyMerzOwn created this revision.Jun 21 2022, 11:33 AM

Herald added a reviewer: Reviewers. · View Herald TranscriptJun 21 2022, 11:33 AM

Build is green

Patch application report for D8007 (id=28859)

Rebasing onto 153bda12aa...

Current branch diff-target is up to date.

Changes applied before test

commit bbf9dc80475a8156ad6184ada594ca696a30079a
Author: Satvik Vemuganti <vemugantisesha@iitbhilai.ac.in>
Date:   Tue Jun 21 15:02:23 2022 +0530

    Fix crash when npm description is not a string

See https://jenkins.softwareheritage.org/job/DCIDX/job/tests-on-diff/272/ for more details.

Harbormaster completed remote builds in B29946: Diff 28859.Jun 21 2022, 11:39 AM

VickyMerzOwn requested review of this revision.Jun 21 2022, 11:39 AM

vlorentz accepted this revision.Jun 21 2022, 1:31 PM

This revision is now accepted and ready to land.Jun 21 2022, 1:31 PM

Closed by commit rDCIDXbbf9dc80475a: Fix crash when npm description is not a string (authored by VickyMerzOwn). · Explain WhyJun 21 2022, 1:48 PM

This revision was automatically updated to reflect the committed changes.

VickyMerzOwn added a commit: rDCIDXbbf9dc80475a: Fix crash when npm description is not a string.

Revision Contents
Changeset List

Path

Size

swh/

indexer/

metadata_dictionary/

npm.py

2 lines

tests/

test_metadata.py

24 lines

Diff 28860

View Options

swh/indexer/metadata_dictionary/npm.py