Page MenuHomeSoftware Heritage
Differential D7587

Add annotations to the main function in __init__.py
ClosedPublic
Actions

Authored by VickyMerzOwn on Apr 15 2022, 11:16 AM.

Details

Reviewers
vlorentz
Group Reviewers
Reviewers
Maniphest Tasks
T2259: Add type annotations to metadata mappings
Commits
rDCIDX270a2b3c74f4: Add annotations to the__init__.py, base.py, cff.py, codemeta.py and maven.py in…
Required Signatures
L3 Software Heritage Contributor License Agreement, version 1.0

Diff Detail

Repository
rDCIDX Metadata indexer
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
ardumont added a subscriber: ardumont.Apr 15 2022, 1:56 PM

Hello,

Thanks for your contribution.

@VickyMerzOwn you need to sign the L3 document (linked in this very diff) so we can review your diff though.

Cheers,

ardumont added a comment.Apr 15 2022, 4:38 PM

lgtm.

Please, use imperative form in your commit message though.
Here that'd be: "Add annotations to the main function in __init__.py".

More information on our docs [1].

[1] https://docs.softwareheritage.org/devel/contributing/git-style-guide.html#link-commits-to-tasks

Cheers,

VickyMerzOwn added a comment.Apr 15 2022, 9:31 PM
This comment was removed by VickyMerzOwn.
VickyMerzOwn retitled this revision from Added annotations to the main function in __init__.py to Adds annotations to the main function in __init__.py.Apr 16 2022, 7:55 AM
VickyMerzOwn retitled this revision from Adds annotations to the main function in __init__.py to Add annotations to the main function in __init__.py.
VickyMerzOwn updated this revision to Diff 27497.Apr 16 2022, 1:52 PM

Add annotations to the functions in base.py

swh-public-ci added a comment.Apr 16 2022, 1:57 PM

Build is green

Patch application report for D7587 (id=27497)

Rebasing onto 4fe8cacf21...

Current branch diff-target is up to date.
Changes applied before test
commit 906ab2ac21aa602c3e48e3fbbecf09487c535610
Author: Satvik Vemuganti <vemugantisesha@iitbhilai.ac.in>
Date:   Fri Apr 15 14:32:05 2022 +0530

    Added annotations to the main function in __init__.py

See https://jenkins.softwareheritage.org/job/DCIDX/job/tests-on-diff/202/ for more details.

Harbormaster completed remote builds in B28518: Diff 27497.Apr 16 2022, 1:57 PM
VickyMerzOwn added a comment.Apr 18 2022, 11:19 AM

@ardumont Is this good enough to be merged? If so, there are other annotations that need to be added and I'll create those diffs as well.

VickyMerzOwn updated this revision to Diff 27498.Apr 18 2022, 11:27 AM

Add annotations to base.py

swh-public-ci added a comment.Apr 18 2022, 11:31 AM

Build has FAILED

Patch application report for D7587 (id=27498)

Rebasing onto 4fe8cacf21...

Current branch diff-target is up to date.
Changes applied before test
commit 07bfc71539d4cb7fa3a3910eb2bdaa2c34b193cb
Author: Satvik Vemuganti <vemugantisesha@iitbhilai.ac.in>
Date:   Mon Apr 18 14:55:02 2022 +0530

    Add annotations to base.py

commit 906ab2ac21aa602c3e48e3fbbecf09487c535610
Author: Satvik Vemuganti <vemugantisesha@iitbhilai.ac.in>
Date:   Fri Apr 15 14:32:05 2022 +0530

    Added annotations to the main function in __init__.py

Link to build: https://jenkins.softwareheritage.org/job/DCIDX/job/tests-on-diff/203/
See console output for more information: https://jenkins.softwareheritage.org/job/DCIDX/job/tests-on-diff/203/console

Harbormaster failed remote builds in B28519: Diff 27498!Apr 18 2022, 11:31 AM
VickyMerzOwn updated this revision to Diff 27499.Apr 18 2022, 11:37 AM

Add annotations to base.py

swh-public-ci added a comment.Apr 18 2022, 11:41 AM

Build has FAILED

Patch application report for D7587 (id=27499)

Rebasing onto 4fe8cacf21...

Current branch diff-target is up to date.
Changes applied before test
commit e535236000516516ba64de1078c5e4c7ca72d7d8
Author: Satvik Vemuganti <vemugantisesha@iitbhilai.ac.in>
Date:   Mon Apr 18 15:06:56 2022 +0530

    Add annotations to base.py

commit 07bfc71539d4cb7fa3a3910eb2bdaa2c34b193cb
Author: Satvik Vemuganti <vemugantisesha@iitbhilai.ac.in>
Date:   Mon Apr 18 14:55:02 2022 +0530

    Add annotations to base.py

commit 906ab2ac21aa602c3e48e3fbbecf09487c535610
Author: Satvik Vemuganti <vemugantisesha@iitbhilai.ac.in>
Date:   Fri Apr 15 14:32:05 2022 +0530

    Added annotations to the main function in __init__.py

Link to build: https://jenkins.softwareheritage.org/job/DCIDX/job/tests-on-diff/204/
See console output for more information: https://jenkins.softwareheritage.org/job/DCIDX/job/tests-on-diff/204/console

Harbormaster failed remote builds in B28520: Diff 27499!Apr 18 2022, 11:41 AM
VickyMerzOwn updated this revision to Diff 27500.Apr 18 2022, 11:54 AM

Add annotations to base.py

swh-public-ci added a comment.Apr 18 2022, 11:58 AM

Build is green

Patch application report for D7587 (id=27500)

Rebasing onto 4fe8cacf21...

Current branch diff-target is up to date.
Changes applied before test
commit 74ad0bc730c908132c2a1f514e79ecd5b475af8b
Author: Satvik Vemuganti <vemugantisesha@iitbhilai.ac.in>
Date:   Mon Apr 18 15:23:38 2022 +0530

    Add annotations to base.py

commit e535236000516516ba64de1078c5e4c7ca72d7d8
Author: Satvik Vemuganti <vemugantisesha@iitbhilai.ac.in>
Date:   Mon Apr 18 15:06:56 2022 +0530

    Add annotations to base.py

commit 07bfc71539d4cb7fa3a3910eb2bdaa2c34b193cb
Author: Satvik Vemuganti <vemugantisesha@iitbhilai.ac.in>
Date:   Mon Apr 18 14:55:02 2022 +0530

    Add annotations to base.py

commit 906ab2ac21aa602c3e48e3fbbecf09487c535610
Author: Satvik Vemuganti <vemugantisesha@iitbhilai.ac.in>
Date:   Fri Apr 15 14:32:05 2022 +0530

    Added annotations to the main function in __init__.py

See https://jenkins.softwareheritage.org/job/DCIDX/job/tests-on-diff/205/ for more details.

Harbormaster completed remote builds in B28521: Diff 27500.Apr 18 2022, 11:58 AM
vlorentz added a subscriber: vlorentz.Apr 18 2022, 4:34 PM

Thanks.

Please use Optional[...] instead of Union[..., None].

And try to make signatures more specific:

VickyMerzOwn updated this revision to Diff 27501.Apr 18 2022, 4:47 PM

Add annotations to cff.py

swh-public-ci added a comment.Apr 18 2022, 4:49 PM

Build has FAILED

Patch application report for D7587 (id=27501)

Rebasing onto 4fe8cacf21...

Current branch diff-target is up to date.
Changes applied before test
commit 334d50fa304f05e7286fe07ddc174825d2000c43
Author: Satvik Vemuganti <vemugantisesha@iitbhilai.ac.in>
Date:   Mon Apr 18 20:15:59 2022 +0530

    Add annotations to cff.py

commit 74ad0bc730c908132c2a1f514e79ecd5b475af8b
Author: Satvik Vemuganti <vemugantisesha@iitbhilai.ac.in>
Date:   Mon Apr 18 15:23:38 2022 +0530

    Add annotations to base.py

commit e535236000516516ba64de1078c5e4c7ca72d7d8
Author: Satvik Vemuganti <vemugantisesha@iitbhilai.ac.in>
Date:   Mon Apr 18 15:06:56 2022 +0530

    Add annotations to base.py

commit 07bfc71539d4cb7fa3a3910eb2bdaa2c34b193cb
Author: Satvik Vemuganti <vemugantisesha@iitbhilai.ac.in>
Date:   Mon Apr 18 14:55:02 2022 +0530

    Add annotations to base.py

commit 906ab2ac21aa602c3e48e3fbbecf09487c535610
Author: Satvik Vemuganti <vemugantisesha@iitbhilai.ac.in>
Date:   Fri Apr 15 14:32:05 2022 +0530

    Added annotations to the main function in __init__.py

Link to build: https://jenkins.softwareheritage.org/job/DCIDX/job/tests-on-diff/206/
See console output for more information: https://jenkins.softwareheritage.org/job/DCIDX/job/tests-on-diff/206/console

Harbormaster failed remote builds in B28522: Diff 27501!Apr 18 2022, 4:49 PM
VickyMerzOwn added a comment.Apr 18 2022, 6:07 PM
In D7587#198105, @vlorentz wrote:

Please use Optional[...] instead of Union[..., None].

I have to use `Optional[Union[...,...]]`, right?

And try to make signatures more specific:

Okay, I'll do this as well.

VickyMerzOwn updated this revision to Diff 27502.Apr 18 2022, 6:19 PM
  • Add annotations to cff.py
swh-public-ci added a comment.Apr 18 2022, 6:24 PM

Build is green

Patch application report for D7587 (id=27502)

Rebasing onto 4fe8cacf21...

Current branch diff-target is up to date.
Changes applied before test
commit 05f68f33fe7894d2791b9cb8260f5a33706f53a1
Author: Satvik Vemuganti <vemugantisesha@iitbhilai.ac.in>
Date:   Mon Apr 18 21:49:18 2022 +0530

    Add annotations to cff.py

commit 334d50fa304f05e7286fe07ddc174825d2000c43
Author: Satvik Vemuganti <vemugantisesha@iitbhilai.ac.in>
Date:   Mon Apr 18 20:15:59 2022 +0530

    Add annotations to cff.py

commit 74ad0bc730c908132c2a1f514e79ecd5b475af8b
Author: Satvik Vemuganti <vemugantisesha@iitbhilai.ac.in>
Date:   Mon Apr 18 15:23:38 2022 +0530

    Add annotations to base.py

commit e535236000516516ba64de1078c5e4c7ca72d7d8
Author: Satvik Vemuganti <vemugantisesha@iitbhilai.ac.in>
Date:   Mon Apr 18 15:06:56 2022 +0530

    Add annotations to base.py

commit 07bfc71539d4cb7fa3a3910eb2bdaa2c34b193cb
Author: Satvik Vemuganti <vemugantisesha@iitbhilai.ac.in>
Date:   Mon Apr 18 14:55:02 2022 +0530

    Add annotations to base.py

commit 906ab2ac21aa602c3e48e3fbbecf09487c535610
Author: Satvik Vemuganti <vemugantisesha@iitbhilai.ac.in>
Date:   Fri Apr 15 14:32:05 2022 +0530

    Added annotations to the main function in __init__.py

See https://jenkins.softwareheritage.org/job/DCIDX/job/tests-on-diff/207/ for more details.

Harbormaster completed remote builds in B28523: Diff 27502.Apr 18 2022, 6:24 PM
VickyMerzOwn updated this revision to Diff 27503.Apr 18 2022, 8:39 PM
  • Add some more annotations to base.py
  • Add some more annotations to cff.py
swh-public-ci added a comment.Apr 18 2022, 8:43 PM

Build has FAILED

Patch application report for D7587 (id=27503)

Rebasing onto 4fe8cacf21...

Current branch diff-target is up to date.
Changes applied before test
commit 17072eb9a583fc609fa922bb8bd69532ea815d63
Author: Satvik Vemuganti <vemugantisesha@iitbhilai.ac.in>
Date:   Tue Apr 19 00:08:38 2022 +0530

    Add some more annotations to cff.py

commit f0b3401c1cee303fdabc9cc498c1b414d83f6e5e
Author: Satvik Vemuganti <vemugantisesha@iitbhilai.ac.in>
Date:   Mon Apr 18 23:53:27 2022 +0530

    Add some more annotations to base.py

commit 05f68f33fe7894d2791b9cb8260f5a33706f53a1
Author: Satvik Vemuganti <vemugantisesha@iitbhilai.ac.in>
Date:   Mon Apr 18 21:49:18 2022 +0530

    Add annotations to cff.py

commit 334d50fa304f05e7286fe07ddc174825d2000c43
Author: Satvik Vemuganti <vemugantisesha@iitbhilai.ac.in>
Date:   Mon Apr 18 20:15:59 2022 +0530

    Add annotations to cff.py

commit 74ad0bc730c908132c2a1f514e79ecd5b475af8b
Author: Satvik Vemuganti <vemugantisesha@iitbhilai.ac.in>
Date:   Mon Apr 18 15:23:38 2022 +0530

    Add annotations to base.py

commit e535236000516516ba64de1078c5e4c7ca72d7d8
Author: Satvik Vemuganti <vemugantisesha@iitbhilai.ac.in>
Date:   Mon Apr 18 15:06:56 2022 +0530

    Add annotations to base.py

commit 07bfc71539d4cb7fa3a3910eb2bdaa2c34b193cb
Author: Satvik Vemuganti <vemugantisesha@iitbhilai.ac.in>
Date:   Mon Apr 18 14:55:02 2022 +0530

    Add annotations to base.py

commit 906ab2ac21aa602c3e48e3fbbecf09487c535610
Author: Satvik Vemuganti <vemugantisesha@iitbhilai.ac.in>
Date:   Fri Apr 15 14:32:05 2022 +0530

    Added annotations to the main function in __init__.py

Link to build: https://jenkins.softwareheritage.org/job/DCIDX/job/tests-on-diff/208/
See console output for more information: https://jenkins.softwareheritage.org/job/DCIDX/job/tests-on-diff/208/console

Harbormaster failed remote builds in B28524: Diff 27503!Apr 18 2022, 8:43 PM
VickyMerzOwn updated this revision to Diff 27504.Apr 18 2022, 10:33 PM

Add annotations to __init__.py, base.py and cff.py

swh-public-ci added a comment.Apr 18 2022, 10:37 PM

Build has FAILED

Patch application report for D7587 (id=27504)

Rebasing onto 4fe8cacf21...

Current branch diff-target is up to date.
Changes applied before test
commit 17072eb9a583fc609fa922bb8bd69532ea815d63
Author: Satvik Vemuganti <vemugantisesha@iitbhilai.ac.in>
Date:   Tue Apr 19 00:08:38 2022 +0530

    Add some more annotations to cff.py

commit f0b3401c1cee303fdabc9cc498c1b414d83f6e5e
Author: Satvik Vemuganti <vemugantisesha@iitbhilai.ac.in>
Date:   Mon Apr 18 23:53:27 2022 +0530

    Add some more annotations to base.py

commit 05f68f33fe7894d2791b9cb8260f5a33706f53a1
Author: Satvik Vemuganti <vemugantisesha@iitbhilai.ac.in>
Date:   Mon Apr 18 21:49:18 2022 +0530

    Add annotations to cff.py

commit 334d50fa304f05e7286fe07ddc174825d2000c43
Author: Satvik Vemuganti <vemugantisesha@iitbhilai.ac.in>
Date:   Mon Apr 18 20:15:59 2022 +0530

    Add annotations to cff.py

commit 74ad0bc730c908132c2a1f514e79ecd5b475af8b
Author: Satvik Vemuganti <vemugantisesha@iitbhilai.ac.in>
Date:   Mon Apr 18 15:23:38 2022 +0530

    Add annotations to base.py

commit e535236000516516ba64de1078c5e4c7ca72d7d8
Author: Satvik Vemuganti <vemugantisesha@iitbhilai.ac.in>
Date:   Mon Apr 18 15:06:56 2022 +0530

    Add annotations to base.py

commit 07bfc71539d4cb7fa3a3910eb2bdaa2c34b193cb
Author: Satvik Vemuganti <vemugantisesha@iitbhilai.ac.in>
Date:   Mon Apr 18 14:55:02 2022 +0530

    Add annotations to base.py

commit 906ab2ac21aa602c3e48e3fbbecf09487c535610
Author: Satvik Vemuganti <vemugantisesha@iitbhilai.ac.in>
Date:   Fri Apr 15 14:32:05 2022 +0530

    Added annotations to the main function in __init__.py

Link to build: https://jenkins.softwareheritage.org/job/DCIDX/job/tests-on-diff/209/
See console output for more information: https://jenkins.softwareheritage.org/job/DCIDX/job/tests-on-diff/209/console

Harbormaster failed remote builds in B28525: Diff 27504!Apr 18 2022, 10:37 PM
VickyMerzOwn updated this revision to Diff 27505.Apr 18 2022, 11:07 PM
  • Add some more annotations to base.py
swh-public-ci added a comment.Apr 18 2022, 11:12 PM

Build is green

Patch application report for D7587 (id=27505)

Rebasing onto 4fe8cacf21...

Current branch diff-target is up to date.
Changes applied before test
commit dd6ca459b588b1b891d41cac57cdd8d0d2cab78f
Author: Satvik Vemuganti <vemugantisesha@iitbhilai.ac.in>
Date:   Tue Apr 19 02:37:00 2022 +0530

    Add some more annotations to base.py

commit 17072eb9a583fc609fa922bb8bd69532ea815d63
Author: Satvik Vemuganti <vemugantisesha@iitbhilai.ac.in>
Date:   Tue Apr 19 00:08:38 2022 +0530

    Add some more annotations to cff.py

commit f0b3401c1cee303fdabc9cc498c1b414d83f6e5e
Author: Satvik Vemuganti <vemugantisesha@iitbhilai.ac.in>
Date:   Mon Apr 18 23:53:27 2022 +0530

    Add some more annotations to base.py

commit 05f68f33fe7894d2791b9cb8260f5a33706f53a1
Author: Satvik Vemuganti <vemugantisesha@iitbhilai.ac.in>
Date:   Mon Apr 18 21:49:18 2022 +0530

    Add annotations to cff.py

commit 334d50fa304f05e7286fe07ddc174825d2000c43
Author: Satvik Vemuganti <vemugantisesha@iitbhilai.ac.in>
Date:   Mon Apr 18 20:15:59 2022 +0530

    Add annotations to cff.py

commit 74ad0bc730c908132c2a1f514e79ecd5b475af8b
Author: Satvik Vemuganti <vemugantisesha@iitbhilai.ac.in>
Date:   Mon Apr 18 15:23:38 2022 +0530

    Add annotations to base.py

commit e535236000516516ba64de1078c5e4c7ca72d7d8
Author: Satvik Vemuganti <vemugantisesha@iitbhilai.ac.in>
Date:   Mon Apr 18 15:06:56 2022 +0530

    Add annotations to base.py

commit 07bfc71539d4cb7fa3a3910eb2bdaa2c34b193cb
Author: Satvik Vemuganti <vemugantisesha@iitbhilai.ac.in>
Date:   Mon Apr 18 14:55:02 2022 +0530

    Add annotations to base.py

commit 906ab2ac21aa602c3e48e3fbbecf09487c535610
Author: Satvik Vemuganti <vemugantisesha@iitbhilai.ac.in>
Date:   Fri Apr 15 14:32:05 2022 +0530

    Added annotations to the main function in __init__.py

See https://jenkins.softwareheritage.org/job/DCIDX/job/tests-on-diff/210/ for more details.

Harbormaster completed remote builds in B28526: Diff 27505.Apr 18 2022, 11:12 PM
VickyMerzOwn updated this revision to Diff 27506.Apr 18 2022, 11:28 PM
  • Add annotations to codemeta.py
swh-public-ci added a comment.Apr 18 2022, 11:32 PM

Build is green

Patch application report for D7587 (id=27506)

Rebasing onto 4fe8cacf21...

Current branch diff-target is up to date.
Changes applied before test
commit a7198bea6acfaeda8ff18be6ffe1e869966924e4
Author: Satvik Vemuganti <vemugantisesha@iitbhilai.ac.in>
Date:   Tue Apr 19 02:57:43 2022 +0530

    Add annotations to codemeta.py

commit dd6ca459b588b1b891d41cac57cdd8d0d2cab78f
Author: Satvik Vemuganti <vemugantisesha@iitbhilai.ac.in>
Date:   Tue Apr 19 02:37:00 2022 +0530

    Add some more annotations to base.py

commit 17072eb9a583fc609fa922bb8bd69532ea815d63
Author: Satvik Vemuganti <vemugantisesha@iitbhilai.ac.in>
Date:   Tue Apr 19 00:08:38 2022 +0530

    Add some more annotations to cff.py

commit f0b3401c1cee303fdabc9cc498c1b414d83f6e5e
Author: Satvik Vemuganti <vemugantisesha@iitbhilai.ac.in>
Date:   Mon Apr 18 23:53:27 2022 +0530

    Add some more annotations to base.py

commit 05f68f33fe7894d2791b9cb8260f5a33706f53a1
Author: Satvik Vemuganti <vemugantisesha@iitbhilai.ac.in>
Date:   Mon Apr 18 21:49:18 2022 +0530

    Add annotations to cff.py

commit 334d50fa304f05e7286fe07ddc174825d2000c43
Author: Satvik Vemuganti <vemugantisesha@iitbhilai.ac.in>
Date:   Mon Apr 18 20:15:59 2022 +0530

    Add annotations to cff.py

commit 74ad0bc730c908132c2a1f514e79ecd5b475af8b
Author: Satvik Vemuganti <vemugantisesha@iitbhilai.ac.in>
Date:   Mon Apr 18 15:23:38 2022 +0530

    Add annotations to base.py

commit e535236000516516ba64de1078c5e4c7ca72d7d8
Author: Satvik Vemuganti <vemugantisesha@iitbhilai.ac.in>
Date:   Mon Apr 18 15:06:56 2022 +0530

    Add annotations to base.py

commit 07bfc71539d4cb7fa3a3910eb2bdaa2c34b193cb
Author: Satvik Vemuganti <vemugantisesha@iitbhilai.ac.in>
Date:   Mon Apr 18 14:55:02 2022 +0530

    Add annotations to base.py

commit 906ab2ac21aa602c3e48e3fbbecf09487c535610
Author: Satvik Vemuganti <vemugantisesha@iitbhilai.ac.in>
Date:   Fri Apr 15 14:32:05 2022 +0530

    Added annotations to the main function in __init__.py

See https://jenkins.softwareheritage.org/job/DCIDX/job/tests-on-diff/211/ for more details.

Harbormaster completed remote builds in B28527: Diff 27506.Apr 18 2022, 11:32 PM
VickyMerzOwn updated this revision to Diff 27507.Apr 19 2022, 12:14 AM
  • Add annotations to maven.py
swh-public-ci added a comment.Apr 19 2022, 12:19 AM

Build is green

Patch application report for D7587 (id=27507)

Rebasing onto 4fe8cacf21...

Current branch diff-target is up to date.
Changes applied before test
commit f885ab3b45be36ac83511153eb0673c1d4fda727
Author: Satvik Vemuganti <vemugantisesha@iitbhilai.ac.in>
Date:   Tue Apr 19 03:44:22 2022 +0530

    Add annotations to maven.py

commit a7198bea6acfaeda8ff18be6ffe1e869966924e4
Author: Satvik Vemuganti <vemugantisesha@iitbhilai.ac.in>
Date:   Tue Apr 19 02:57:43 2022 +0530

    Add annotations to codemeta.py

commit dd6ca459b588b1b891d41cac57cdd8d0d2cab78f
Author: Satvik Vemuganti <vemugantisesha@iitbhilai.ac.in>
Date:   Tue Apr 19 02:37:00 2022 +0530

    Add some more annotations to base.py

commit 17072eb9a583fc609fa922bb8bd69532ea815d63
Author: Satvik Vemuganti <vemugantisesha@iitbhilai.ac.in>
Date:   Tue Apr 19 00:08:38 2022 +0530

    Add some more annotations to cff.py

commit f0b3401c1cee303fdabc9cc498c1b414d83f6e5e
Author: Satvik Vemuganti <vemugantisesha@iitbhilai.ac.in>
Date:   Mon Apr 18 23:53:27 2022 +0530

    Add some more annotations to base.py

commit 05f68f33fe7894d2791b9cb8260f5a33706f53a1
Author: Satvik Vemuganti <vemugantisesha@iitbhilai.ac.in>
Date:   Mon Apr 18 21:49:18 2022 +0530

    Add annotations to cff.py

commit 334d50fa304f05e7286fe07ddc174825d2000c43
Author: Satvik Vemuganti <vemugantisesha@iitbhilai.ac.in>
Date:   Mon Apr 18 20:15:59 2022 +0530

    Add annotations to cff.py

commit 74ad0bc730c908132c2a1f514e79ecd5b475af8b
Author: Satvik Vemuganti <vemugantisesha@iitbhilai.ac.in>
Date:   Mon Apr 18 15:23:38 2022 +0530

    Add annotations to base.py

commit e535236000516516ba64de1078c5e4c7ca72d7d8
Author: Satvik Vemuganti <vemugantisesha@iitbhilai.ac.in>
Date:   Mon Apr 18 15:06:56 2022 +0530

    Add annotations to base.py

commit 07bfc71539d4cb7fa3a3910eb2bdaa2c34b193cb
Author: Satvik Vemuganti <vemugantisesha@iitbhilai.ac.in>
Date:   Mon Apr 18 14:55:02 2022 +0530

    Add annotations to base.py

commit 906ab2ac21aa602c3e48e3fbbecf09487c535610
Author: Satvik Vemuganti <vemugantisesha@iitbhilai.ac.in>
Date:   Fri Apr 15 14:32:05 2022 +0530

    Added annotations to the main function in __init__.py

See https://jenkins.softwareheritage.org/job/DCIDX/job/tests-on-diff/212/ for more details.

Harbormaster completed remote builds in B28528: Diff 27507.Apr 19 2022, 12:19 AM
vlorentz requested changes to this revision.Apr 19 2022, 8:17 AM
vlorentz added inline comments.
swh/indexer/metadata_dictionary/base.py
63

You can make it more specific than Any here

155

Optional and Union[..., None] is redundant, just use Optional[Dict]

swh/indexer/metadata_dictionary/cff.py
33

Why Optional and List?

swh/indexer/metadata_dictionary/codemeta.py
28

Technically, the dicts can be arbitrarily nested; so Optional[Dict[str, Any]] is more correct

swh/indexer/metadata_dictionary/maven.py
28

ditto

This revision now requires changes to proceed.Apr 19 2022, 8:17 AM
VickyMerzOwn updated this revision to Diff 27508.Apr 19 2022, 11:01 AM
  • Revise changes to base.py WRT comments
  • Revise annotatiions to cff.py
swh-public-ci added a comment.Apr 19 2022, 11:06 AM

Build is green

Patch application report for D7587 (id=27508)

Rebasing onto 4fe8cacf21...

Current branch diff-target is up to date.
Changes applied before test
commit 5f374579d2686ef7b62e74d140eaf6e995063732
Author: Satvik Vemuganti <vemugantisesha@iitbhilai.ac.in>
Date:   Tue Apr 19 14:16:02 2022 +0530

    Revise annotatiions to cff.py

commit fe87b377b24e0b3207588daf7d7c1b82736e9985
Author: Satvik Vemuganti <vemugantisesha@iitbhilai.ac.in>
Date:   Tue Apr 19 13:59:28 2022 +0530

    Revise changes to base.py WRT comments

commit f885ab3b45be36ac83511153eb0673c1d4fda727
Author: Satvik Vemuganti <vemugantisesha@iitbhilai.ac.in>
Date:   Tue Apr 19 03:44:22 2022 +0530

    Add annotations to maven.py

commit a7198bea6acfaeda8ff18be6ffe1e869966924e4
Author: Satvik Vemuganti <vemugantisesha@iitbhilai.ac.in>
Date:   Tue Apr 19 02:57:43 2022 +0530

    Add annotations to codemeta.py

commit dd6ca459b588b1b891d41cac57cdd8d0d2cab78f
Author: Satvik Vemuganti <vemugantisesha@iitbhilai.ac.in>
Date:   Tue Apr 19 02:37:00 2022 +0530

    Add some more annotations to base.py

commit 17072eb9a583fc609fa922bb8bd69532ea815d63
Author: Satvik Vemuganti <vemugantisesha@iitbhilai.ac.in>
Date:   Tue Apr 19 00:08:38 2022 +0530

    Add some more annotations to cff.py

commit f0b3401c1cee303fdabc9cc498c1b414d83f6e5e
Author: Satvik Vemuganti <vemugantisesha@iitbhilai.ac.in>
Date:   Mon Apr 18 23:53:27 2022 +0530

    Add some more annotations to base.py

commit 05f68f33fe7894d2791b9cb8260f5a33706f53a1
Author: Satvik Vemuganti <vemugantisesha@iitbhilai.ac.in>
Date:   Mon Apr 18 21:49:18 2022 +0530

    Add annotations to cff.py

commit 334d50fa304f05e7286fe07ddc174825d2000c43
Author: Satvik Vemuganti <vemugantisesha@iitbhilai.ac.in>
Date:   Mon Apr 18 20:15:59 2022 +0530

    Add annotations to cff.py

commit 74ad0bc730c908132c2a1f514e79ecd5b475af8b
Author: Satvik Vemuganti <vemugantisesha@iitbhilai.ac.in>
Date:   Mon Apr 18 15:23:38 2022 +0530

    Add annotations to base.py

commit e535236000516516ba64de1078c5e4c7ca72d7d8
Author: Satvik Vemuganti <vemugantisesha@iitbhilai.ac.in>
Date:   Mon Apr 18 15:06:56 2022 +0530

    Add annotations to base.py

commit 07bfc71539d4cb7fa3a3910eb2bdaa2c34b193cb
Author: Satvik Vemuganti <vemugantisesha@iitbhilai.ac.in>
Date:   Mon Apr 18 14:55:02 2022 +0530

    Add annotations to base.py

commit 906ab2ac21aa602c3e48e3fbbecf09487c535610
Author: Satvik Vemuganti <vemugantisesha@iitbhilai.ac.in>
Date:   Fri Apr 15 14:32:05 2022 +0530

    Added annotations to the main function in __init__.py

See https://jenkins.softwareheritage.org/job/DCIDX/job/tests-on-diff/213/ for more details.

Harbormaster completed remote builds in B28532: Diff 27508.Apr 19 2022, 11:06 AM
vlorentz added a task: T2259: Add type annotations to metadata mappings.Apr 19 2022, 1:14 PM
VickyMerzOwn marked 3 inline comments as done.Apr 19 2022, 3:51 PM
VickyMerzOwn added inline comments.
swh/indexer/metadata_dictionary/codemeta.py
28

I thought of that but then realised this would be more specific. ( I tried to avoid Any wherever I could)

swh/indexer/metadata_dictionary/maven.py
28

I could change it though. I haven't done type annotations before I came across the issue, so still learning things.

vlorentz added inline comments.Apr 19 2022, 3:52 PM
swh/indexer/metadata_dictionary/base.py
35

Use the same annotation here as you did below (this is the base class)

swh/indexer/metadata_dictionary/codemeta.py
28

that's true in general, but not here.

VickyMerzOwn updated this revision to Diff 27526.Apr 19 2022, 4:01 PM

Revise annotations of and Format codemeta.py and maven.py

swh-public-ci added a comment.Apr 19 2022, 4:05 PM

Build is green

Patch application report for D7587 (id=27526)

Rebasing onto 4fe8cacf21...

Current branch diff-target is up to date.
Changes applied before test
commit f3da534168357503e89a428f2eb75a99277b1220
Author: Satvik Vemuganti <vemugantisesha@iitbhilai.ac.in>
Date:   Tue Apr 19 19:30:42 2022 +0530

    Format codemeta.py and maven.py

commit 5f374579d2686ef7b62e74d140eaf6e995063732
Author: Satvik Vemuganti <vemugantisesha@iitbhilai.ac.in>
Date:   Tue Apr 19 14:16:02 2022 +0530

    Revise annotatiions to cff.py

commit fe87b377b24e0b3207588daf7d7c1b82736e9985
Author: Satvik Vemuganti <vemugantisesha@iitbhilai.ac.in>
Date:   Tue Apr 19 13:59:28 2022 +0530

    Revise changes to base.py WRT comments

commit f885ab3b45be36ac83511153eb0673c1d4fda727
Author: Satvik Vemuganti <vemugantisesha@iitbhilai.ac.in>
Date:   Tue Apr 19 03:44:22 2022 +0530

    Add annotations to maven.py

commit a7198bea6acfaeda8ff18be6ffe1e869966924e4
Author: Satvik Vemuganti <vemugantisesha@iitbhilai.ac.in>
Date:   Tue Apr 19 02:57:43 2022 +0530

    Add annotations to codemeta.py

commit dd6ca459b588b1b891d41cac57cdd8d0d2cab78f
Author: Satvik Vemuganti <vemugantisesha@iitbhilai.ac.in>
Date:   Tue Apr 19 02:37:00 2022 +0530

    Add some more annotations to base.py

commit 17072eb9a583fc609fa922bb8bd69532ea815d63
Author: Satvik Vemuganti <vemugantisesha@iitbhilai.ac.in>
Date:   Tue Apr 19 00:08:38 2022 +0530

    Add some more annotations to cff.py

commit f0b3401c1cee303fdabc9cc498c1b414d83f6e5e
Author: Satvik Vemuganti <vemugantisesha@iitbhilai.ac.in>
Date:   Mon Apr 18 23:53:27 2022 +0530

    Add some more annotations to base.py

commit 05f68f33fe7894d2791b9cb8260f5a33706f53a1
Author: Satvik Vemuganti <vemugantisesha@iitbhilai.ac.in>
Date:   Mon Apr 18 21:49:18 2022 +0530

    Add annotations to cff.py

commit 334d50fa304f05e7286fe07ddc174825d2000c43
Author: Satvik Vemuganti <vemugantisesha@iitbhilai.ac.in>
Date:   Mon Apr 18 20:15:59 2022 +0530

    Add annotations to cff.py

commit 74ad0bc730c908132c2a1f514e79ecd5b475af8b
Author: Satvik Vemuganti <vemugantisesha@iitbhilai.ac.in>
Date:   Mon Apr 18 15:23:38 2022 +0530

    Add annotations to base.py

commit e535236000516516ba64de1078c5e4c7ca72d7d8
Author: Satvik Vemuganti <vemugantisesha@iitbhilai.ac.in>
Date:   Mon Apr 18 15:06:56 2022 +0530

    Add annotations to base.py

commit 07bfc71539d4cb7fa3a3910eb2bdaa2c34b193cb
Author: Satvik Vemuganti <vemugantisesha@iitbhilai.ac.in>
Date:   Mon Apr 18 14:55:02 2022 +0530

    Add annotations to base.py

commit 906ab2ac21aa602c3e48e3fbbecf09487c535610
Author: Satvik Vemuganti <vemugantisesha@iitbhilai.ac.in>
Date:   Fri Apr 15 14:32:05 2022 +0530

    Added annotations to the main function in __init__.py

See https://jenkins.softwareheritage.org/job/DCIDX/job/tests-on-diff/214/ for more details.

Harbormaster completed remote builds in B28550: Diff 27526.Apr 19 2022, 4:05 PM
vlorentz added inline comments.Apr 19 2022, 4:07 PM
swh/indexer/metadata_dictionary/base.py
35

you forgot this

VickyMerzOwn updated this revision to Diff 27527.Apr 19 2022, 6:08 PM
  • Revise annotations in base.py
swh-public-ci added a comment.Apr 19 2022, 6:12 PM

Build is green

Patch application report for D7587 (id=27527)

Rebasing onto 4fe8cacf21...

Current branch diff-target is up to date.
Changes applied before test
commit 4435b65267b3a116cb5600938e242979da819a5c
Author: Satvik Vemuganti <vemugantisesha@iitbhilai.ac.in>
Date:   Tue Apr 19 21:37:30 2022 +0530

    Revise annotations in base.py

commit f3da534168357503e89a428f2eb75a99277b1220
Author: Satvik Vemuganti <vemugantisesha@iitbhilai.ac.in>
Date:   Tue Apr 19 19:30:42 2022 +0530

    Format codemeta.py and maven.py

commit 5f374579d2686ef7b62e74d140eaf6e995063732
Author: Satvik Vemuganti <vemugantisesha@iitbhilai.ac.in>
Date:   Tue Apr 19 14:16:02 2022 +0530

    Revise annotatiions to cff.py

commit fe87b377b24e0b3207588daf7d7c1b82736e9985
Author: Satvik Vemuganti <vemugantisesha@iitbhilai.ac.in>
Date:   Tue Apr 19 13:59:28 2022 +0530

    Revise changes to base.py WRT comments

commit f885ab3b45be36ac83511153eb0673c1d4fda727
Author: Satvik Vemuganti <vemugantisesha@iitbhilai.ac.in>
Date:   Tue Apr 19 03:44:22 2022 +0530

    Add annotations to maven.py

commit a7198bea6acfaeda8ff18be6ffe1e869966924e4
Author: Satvik Vemuganti <vemugantisesha@iitbhilai.ac.in>
Date:   Tue Apr 19 02:57:43 2022 +0530

    Add annotations to codemeta.py

commit dd6ca459b588b1b891d41cac57cdd8d0d2cab78f
Author: Satvik Vemuganti <vemugantisesha@iitbhilai.ac.in>
Date:   Tue Apr 19 02:37:00 2022 +0530

    Add some more annotations to base.py

commit 17072eb9a583fc609fa922bb8bd69532ea815d63
Author: Satvik Vemuganti <vemugantisesha@iitbhilai.ac.in>
Date:   Tue Apr 19 00:08:38 2022 +0530

    Add some more annotations to cff.py

commit f0b3401c1cee303fdabc9cc498c1b414d83f6e5e
Author: Satvik Vemuganti <vemugantisesha@iitbhilai.ac.in>
Date:   Mon Apr 18 23:53:27 2022 +0530

    Add some more annotations to base.py

commit 05f68f33fe7894d2791b9cb8260f5a33706f53a1
Author: Satvik Vemuganti <vemugantisesha@iitbhilai.ac.in>
Date:   Mon Apr 18 21:49:18 2022 +0530

    Add annotations to cff.py

commit 334d50fa304f05e7286fe07ddc174825d2000c43
Author: Satvik Vemuganti <vemugantisesha@iitbhilai.ac.in>
Date:   Mon Apr 18 20:15:59 2022 +0530

    Add annotations to cff.py

commit 74ad0bc730c908132c2a1f514e79ecd5b475af8b
Author: Satvik Vemuganti <vemugantisesha@iitbhilai.ac.in>
Date:   Mon Apr 18 15:23:38 2022 +0530

    Add annotations to base.py

commit e535236000516516ba64de1078c5e4c7ca72d7d8
Author: Satvik Vemuganti <vemugantisesha@iitbhilai.ac.in>
Date:   Mon Apr 18 15:06:56 2022 +0530

    Add annotations to base.py

commit 07bfc71539d4cb7fa3a3910eb2bdaa2c34b193cb
Author: Satvik Vemuganti <vemugantisesha@iitbhilai.ac.in>
Date:   Mon Apr 18 14:55:02 2022 +0530

    Add annotations to base.py

commit 906ab2ac21aa602c3e48e3fbbecf09487c535610
Author: Satvik Vemuganti <vemugantisesha@iitbhilai.ac.in>
Date:   Fri Apr 15 14:32:05 2022 +0530

    Added annotations to the main function in __init__.py

See https://jenkins.softwareheritage.org/job/DCIDX/job/tests-on-diff/215/ for more details.

Harbormaster completed remote builds in B28552: Diff 27527.Apr 19 2022, 6:12 PM
vlorentz accepted this revision.Apr 19 2022, 6:26 PM

Thanks!

This revision is now accepted and ready to land.Apr 19 2022, 6:26 PM
vlorentz requested changes to this revision.Apr 19 2022, 8:34 PM

Actually, one last thing: you need to squash your commits before landing this.

This revision now requires changes to proceed.Apr 19 2022, 8:34 PM
VickyMerzOwn updated this revision to Diff 27529.Apr 19 2022, 11:58 PM

Squash all commits

swh-public-ci added a comment.Apr 20 2022, 12:03 AM

Build is green

Patch application report for D7587 (id=27529)

Rebasing onto 4fe8cacf21...

Current branch diff-target is up to date.
Changes applied before test
commit 270a2b3c74f4f66b9368bb21df84acf9c2287eba
Author: Satvik Vemuganti <vemugantisesha@iitbhilai.ac.in>
Date:   Fri Apr 15 14:32:05 2022 +0530

    Add annotations to the__init__.py, base.py, cff.py, codemeta.py and maven.py in metadata_dictionary

See https://jenkins.softwareheritage.org/job/DCIDX/job/tests-on-diff/216/ for more details.

Harbormaster completed remote builds in B28554: Diff 27529.Apr 20 2022, 12:03 AM
vlorentz accepted this revision.Apr 20 2022, 10:06 AM

Thanks again

This revision is now accepted and ready to land.Apr 20 2022, 10:06 AM
VickyMerzOwn added a comment.Apr 20 2022, 10:17 AM

My pleasure... :-)

Closed by commit rDCIDX270a2b3c74f4: Add annotations to the__init__.py, base.py, cff.py, codemeta.py and maven.py in… (authored by VickyMerzOwn). · Explain WhyApr 20 2022, 10:45 AM
This revision was automatically updated to reflect the committed changes.
VickyMerzOwn added a commit: rDCIDX270a2b3c74f4: Add annotations to the__init__.py, base.py, cff.py, codemeta.py and maven.py in….

Revision Contents
Changeset List

PathSize
swh/
indexer/
metadata_dictionary/
2 lines
29 lines
26 lines
5 lines
3 lines

Diff 27532

View Options

swh/indexer/metadata_dictionary/__init__.py

Loading...
View Options

swh/indexer/metadata_dictionary/base.py

Loading...
View Options

swh/indexer/metadata_dictionary/cff.py

Loading...
View Options

swh/indexer/metadata_dictionary/codemeta.py

Loading...
View Options

swh/indexer/metadata_dictionary/maven.py

Loading...
About · Developer information · Legal