in the browse requests tab, set an hyperlink on forge url (and the usual forge ling icon)
Description
Description
Revisions and Commits
Revisions and Commits
| Status | Assigned | Task | ||
|---|---|---|---|---|
| Migrated | gitlab-migration | T2197 Ingestion / coverage | ||
| Migrated | gitlab-migration | T2199 "Save Forge Now" | ||
| Migrated | gitlab-migration | T1538 Add "forge" now | ||
| Migrated | gitlab-migration | T4047 User interface to submit and follow Add forge now requests | ||
| Migrated | gitlab-migration | T4070 add forge now submission form | ||
| Migrated | gitlab-migration | T3989 [Add forge now] Create "browse add requests" tab | ||
| Migrated | gitlab-migration | T4078 add forge now - add a link on forge url |
Event Timeline
Comment Actions
@bchauvet i want to work on this issue can you please guide me where i have to add link ?
Comment Actions
Hello, it's on the add-forge-now admin dashboard view (which lists add-forge-now requsets).
You won't actually see it in the archive for now as it's not publicly opened yet.
You can still work on this though using the docker images and make it run locally.
Then adapt the code to make the currently displayed field forge_url a link.
For this, you need to adapt the following code [1].
And then checks with your swh-web instance locally runnlng that the link is now displayed as an url link (instead of raw text).
Comment Actions
Hey @ardumont!
I'm unable to run swh-web using the docker images, more details here
Could you please help me out with this?
Sure. A couple of questions regarding your paste.
Why are you using sudo when starting the docker-compose?
docker-compose up is the command to run with your unix user
Note that docker-compose up swh-web should be enough to avoid starting
too much unnecessary services (if you want to hack on swh-web at first).
What does your docker-compose.override.yml look like?
It seems from the log you are mounting your local swh-web repository on top of it during the start-up (it's fine).
But somehow there is a permission issue somewhere.
My unix login is part of the 'docker' unix group so i don't have to sudo.
I got it running without docker, the hyperlinks show up on the browse-requests tab,
can I submit a diff?
Sure, you can.
Just make sure the build is green at the end.
Make tests run locally on your repository and/or have a, look at the jenkins build logs.