I understand that, it's just it can look very weird for someone not really in the project... not sure where to add a comment to make this clear (besides the commit message)

Jun 4 2021, 10:57 AM

douardda updated the diff for D5773: Refactor the isochrone graph computation.

wrong revset...

Jun 4 2021, 10:32 AM

douardda updated the diff for D5812: Add a test_provenance_heuristics_content_find_all() test.

rebase

Jun 4 2021, 10:31 AM

douardda added inline comments to D5812: Add a test_provenance_heuristics_content_find_all() test.

Jun 4 2021, 10:18 AM

douardda updated the diff for D5773: Refactor the isochrone graph computation.

rebase

Jun 4 2021, 10:13 AM

douardda updated the diff for D5811: Add a simple out-of-order dataset.

Fix the synth file...

Jun 4 2021, 9:54 AM

douardda created P1061 (An Untitled Masterwork).

Jun 4 2021, 9:35 AM

Jun 3 2021

douardda added a comment to D5805: Add a new (git) dataset generation scaffolding for tests.

In D5805#148044, @vlorentz wrote:

Why did you commit cmdbts2.msgpack instead of regenerating it? Is it too slow?

Jun 3 2021, 3:36 PM

douardda updated the diff for D5773: Refactor the isochrone graph computation.

rebase

Jun 3 2021, 3:33 PM

douardda updated the diff for D5812: Add a test_provenance_heuristics_content_find_all() test.

rebase

Jun 3 2021, 3:32 PM

douardda updated the diff for D5811: Add a simple out-of-order dataset.

rebase + include a R06 revision

Jun 3 2021, 3:31 PM

douardda updated the diff for D5805: Add a new (git) dataset generation scaffolding for tests.

rebase

Jun 3 2021, 3:30 PM

douardda abandoned D5772: Add a test for the build_isochrone_graph() function.

probably useless now with D5805 coming along.

Jun 3 2021, 3:27 PM

douardda closed D5781: Simplify DB queries in ProvenanceWithPathDB.content_find_(first|all).

Jun 3 2021, 3:23 PM

douardda committed rDPROV08344d3f76c0: Simplify DB queries in ProvenanceWithPathDB.content_find_(first|all) (authored by douardda).

Simplify DB queries in ProvenanceWithPathDB.content_find_(first|all)

Jun 3 2021, 3:23 PM

douardda closed D5780: Add a test for content_find_all().

Jun 3 2021, 3:23 PM

douardda committed rDPROVce700ffb9810: Add a test for content_find_all() (authored by douardda).

Add a test for content_find_all()

Jun 3 2021, 3:23 PM

douardda updated the diff for D5781: Simplify DB queries in ProvenanceWithPathDB.content_find_(first|all).

rebas

Jun 3 2021, 3:20 PM

douardda updated the diff for D5780: Add a test for content_find_all().

rebase on master

Jun 3 2021, 3:18 PM

douardda closed D5813: Make ProvenanceDB.commit() optionally raise the exception.

Jun 3 2021, 3:16 PM

douardda committed rDPROV33eada55f05a: Make ProvenanceDB.commit() optionally raise the exception (authored by douardda).

Make ProvenanceDB.commit() optionally raise the exception

Jun 3 2021, 3:16 PM

douardda updated the diff for D5813: Make ProvenanceDB.commit() optionally raise the exception.

rebase on master and apply vlorentz' suggestion

Jun 3 2021, 3:11 PM

douardda updated the summary of D5813: Make ProvenanceDB.commit() optionally raise the exception.

Jun 3 2021, 3:09 PM

douardda added a comment to D5811: Add a simple out-of-order dataset.

In D5811#147864, @douardda wrote:

@aeviso I have a question: in this scenario, do we expect the date in the directory table for A/C and A/B/C (sha1 c9cabe7f49012e3fdef6ac6b929efb5654f583cf) directories to be invalidated or updated due to the arrival, at rev R05, of a version of the b file dated earlier than originally seen in R01?

Jun 3 2021, 10:52 AM

douardda updated the diff for D5813: Make ProvenanceDB.commit() optionally raise the exception.

rebase

Jun 3 2021, 10:08 AM

douardda updated the diff for D5812: Add a test_provenance_heuristics_content_find_all() test.

rebase

Jun 3 2021, 10:08 AM

douardda updated the diff for D5811: Add a simple out-of-order dataset.

rebase

Jun 3 2021, 10:07 AM

douardda updated the diff for D5805: Add a new (git) dataset generation scaffolding for tests.

rebase

Jun 3 2021, 10:07 AM

douardda updated the diff for D5781: Simplify DB queries in ProvenanceWithPathDB.content_find_(first|all).

rebase

Jun 3 2021, 10:06 AM

douardda updated the diff for D5780: Add a test for content_find_all().

rebase

Jun 3 2021, 10:05 AM

douardda updated the diff for D5773: Refactor the isochrone graph computation.

rebase

Jun 3 2021, 10:05 AM

douardda updated the diff for D5772: Add a test for the build_isochrone_graph() function.

rebase

Jun 3 2021, 10:04 AM

Jun 2 2021

douardda updated the diff for D5813: Make ProvenanceDB.commit() optionally raise the exception.

rebase

Jun 2 2021, 5:39 PM

douardda updated the diff for D5812: Add a test_provenance_heuristics_content_find_all() test.

rebase

Jun 2 2021, 5:38 PM

douardda updated the diff for D5811: Add a simple out-of-order dataset.

rebase

Jun 2 2021, 5:38 PM

douardda updated the diff for D5805: Add a new (git) dataset generation scaffolding for tests.

actually pick the correct revisions for this diff...

Jun 2 2021, 5:37 PM

douardda updated the diff for D5805: Add a new (git) dataset generation scaffolding for tests.

rebase

Jun 2 2021, 5:35 PM

douardda updated the diff for D5781: Simplify DB queries in ProvenanceWithPathDB.content_find_(first|all).

rebase

Jun 2 2021, 5:35 PM

douardda updated the diff for D5780: Add a test for content_find_all().

rebase

Jun 2 2021, 5:34 PM

douardda updated the diff for D5773: Refactor the isochrone graph computation.

fix typos, add more comments/docstrings, and remove completly the IsochroneNode.files attribute

Jun 2 2021, 5:33 PM

douardda added a comment to D5781: Simplify DB queries in ProvenanceWithPathDB.content_find_(first|all).

In D5781#147873, @aeviso wrote:

This diff is already accepted by ardumont, who knows SQL better than I do. There is no much for me to review here

Jun 2 2021, 5:25 PM

douardda added a comment to D5781: Simplify DB queries in ProvenanceWithPathDB.content_find_(first|all).

In D5781#147873, @aeviso wrote:

This diff is already accepted by ardumont, who knows SQL better than I do. There is no much for me to review here

Jun 2 2021, 5:19 PM

douardda added a comment to D5813: Make ProvenanceDB.commit() optionally raise the exception.

In D5813#147855, @aeviso wrote:

Why would we want to do this? The actual idea is to guarantee that the commit method never fails, so we can remove the while not provenance.commit() line in the revision_add function.

Jun 2 2021, 4:58 PM

douardda added a comment to D5781: Simplify DB queries in ProvenanceWithPathDB.content_find_(first|all).

In D5781#147856, @aeviso wrote:

We are about to start refactoring the provenance backend. It would be nice to have this changes pushed, since re-basing them might by complicated after refactoring.

Jun 2 2021, 4:47 PM

douardda updated subscribers of D5812: Add a test_provenance_heuristics_content_find_all() test.

Jun 2 2021, 3:28 PM

douardda updated subscribers of D5811: Add a simple out-of-order dataset.

@aeviso I have a question: in this scenario, do we expect the date in the directory table for A/C and A/B/C (sha1 c9cabe7f49012e3fdef6ac6b929efb5654f583cf) directories to be invalidated or updated due to the arrival, at rev R05, of a version of the b file dated earlier than originally seen in R01?

Jun 2 2021, 3:05 PM

douardda added inline comments to D5773: Refactor the isochrone graph computation.

Jun 2 2021, 2:46 PM

douardda added a comment to D5773: Refactor the isochrone graph computation.

In D5773#147275, @douardda wrote:

In D5773#147221, @aeviso wrote:

I'm not really sure this new algorithm does the same as the previous one. Some subtle things were changed and I have the filling the semantics are different now. Also, I found the previous version to be clearer, I rather stay with it