Update (not using a variable as this fails the build)
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Advanced Search
Nov 23 2022
Hardcode the path to rsvndump which got emptied when using a variable (for some reason)
Rebase and add comment
lgtm but fix the typo in the docstring cli parameter ;)
lgtm but this is missing the migration script update first (and the bump in the schema version somewhere?).
Nov 22 2022
one non blocking suggestion inline
Adapt according to remark
Just an inline remark but otherwise it's ok.
Nov 21 2022
The second part looks good to me. :)
Fix build
Adapt according to first round of review
Nov 18 2022
Adapt according to review
Rebase
Nov 17 2022
Reword some sentences
lgtm, one question inline.
Well, wrong forge to push diff.
Fixing that in our gitlab instance [1].
Nov 16 2022
Nov 15 2022
Amend impacted docstrings
Adapt according to discussion
Nov 14 2022
Fix mistyped signature
Add coverage (which is a bit convoluted but we are in loader-core so no real loader to
check that actual behavior beyond what i propose).
Only, more_data_to_fetch/create_snapshot is renamed create_partial_visit though as
that makes more sense now.
- Rebase
- reword commit and diff description
- adapt parameter according to review suggestion from @vlorentz
Nov 10 2022
I wonder whether we should merge this config file and that of the other script, so that we get all settings in one place.
What do you think?
Yes, i think so too. But which script, to be sure, manage_user_groups right?
I just started it that way to simplify the reading.
I think that i'll adapt according to what you proposed here then update the diff then we land.
Add cli.py
Adapt according to last remark, dump partial json updated project.
And fix some staging issues (after that first run):