Page MenuHomeSoftware Heritage

cli: Move the main code of export_graph to its own function
ClosedPublic

Authored by vlorentz on Thu, Nov 10, 10:17 AM.

Details

Summary

So it can be reused by a Luigi task

Depends on D8827.

Diff Detail

Repository
rDDATASET Datasets
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Build is green

Patch application report for D8828 (id=31823)

Could not rebase; Attempt merge onto b2ae082661...

Updating b2ae082..eea3e15
Fast-forward
 swh/dataset/athena.py |  4 +++-
 swh/dataset/cli.py    | 56 +++++++++++++++++++++++++++++++++------------------
 2 files changed, 39 insertions(+), 21 deletions(-)
Changes applied before test
commit eea3e15bf7e4a817c07fee63f5262a525b6473e3
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Nov 10 10:17:04 2022 +0100

    cli: Move the main code of export_graph to its own function
    
    So it can be reused by a Luigi task

commit 5087a463974e548d78cb169264bb78935428e4a6
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Nov 10 10:11:51 2022 +0100

    athena: Fix create_table to work with restricted permissions
    
    For some reason, using a non-existing database works when working with
    credentials with unnecessarily high privileges (though it is not clear
    to me which permissions allow this).

See https://jenkins.softwareheritage.org/job/DDATASET/job/tests-on-diff/158/ for more details.

This revision is now accepted and ready to land.Thu, Nov 10, 3:44 PM