Differential D8827

athena: Fix create_table to work with restricted permissions
ClosedPublic
Actions

Authored by vlorentz on Nov 10 2022, 10:12 AM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Maniphest Tasks

T4676: Add Luigi workflow in swh-dataset

Commits

rDDATASET5087a463974e: athena: Fix create_table to work with restricted permissions

Summary

For some reason, using a non-existing database works when working with
credentials with unnecessarily high privileges (though it is not clear
to me which permissions allow this).

Diff Detail

Repository

rDDATASET Datasets

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Nov 10 2022, 10:12 AM

Herald added a reviewer: Reviewers. · View Herald TranscriptNov 10 2022, 10:12 AM

Build is green

Patch application report for D8827 (id=31822)

Rebasing onto b2ae082661...

Current branch diff-target is up to date.

Changes applied before test

commit 5087a463974e548d78cb169264bb78935428e4a6
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Nov 10 10:11:51 2022 +0100

    athena: Fix create_table to work with restricted permissions
    
    For some reason, using a non-existing database works when working with
    credentials with unnecessarily high privileges (though it is not clear
    to me which permissions allow this).

See https://jenkins.softwareheritage.org/job/DDATASET/job/tests-on-diff/157/ for more details.

Harbormaster completed remote builds in B32762: Diff 31822.Nov 10 2022, 10:14 AM

vlorentz requested review of this revision.Nov 10 2022, 10:14 AM

vlorentz added a child revision: D8828: cli: Move the main code of export_graph to its own function.Nov 10 2022, 10:17 AM

vlorentz added a task: T4676: Add Luigi workflow in swh-dataset.Nov 10 2022, 10:42 AM

ardumont accepted this revision.Nov 10 2022, 3:27 PM

This revision is now accepted and ready to land.Nov 10 2022, 3:27 PM

Closed by commit rDDATASET5087a463974e: athena: Fix create_table to work with restricted permissions (authored by vlorentz). · Explain WhyNov 10 2022, 4:38 PM

This revision was automatically updated to reflect the committed changes.

vlorentz added a commit: rDDATASET5087a463974e: athena: Fix create_table to work with restricted permissions.