Page MenuHomeSoftware Heritage
Feed Advanced Search

Aug 31 2022

anlambert committed rDWAPPS7617d615b2ca: misc/jslicenses: Move feature into its own django application (authored by anlambert).
misc/jslicenses: Move feature into its own django application
Aug 31 2022, 4:20 PM
anlambert accepted D8356: Add a centralized error handler.

Looks good to me.

Aug 31 2022, 3:44 PM
anlambert requested review of D8359: Remove no longer needed misc folder.
Aug 31 2022, 3:43 PM
anlambert requested review of D8357: misc/jslicenses: Move feature into its own django application.
Aug 31 2022, 3:14 PM
anlambert added a revision to T4398: Create one django application for each webapp feature: D8357: misc/jslicenses: Move feature into its own django application.
Aug 31 2022, 2:20 PM · Web app
anlambert committed rDWAPPS5380e936f80e: tests/mailmap: Restore test_app.py accidentally removed in a77e5ab36cae (authored by anlambert).
tests/mailmap: Restore test_app.py accidentally removed in a77e5ab36cae
Aug 31 2022, 2:19 PM
anlambert planned changes to D8355: pubdev: Modify loader after origin URL modification in related lister.
Aug 31 2022, 12:17 PM
anlambert planned changes to D8354: pubdev: Modify origin URL and retrieve package last update.
Aug 31 2022, 12:16 PM
anlambert updated the diff for D8354: pubdev: Modify origin URL and retrieve package last update.

Check last_update date extraction for a package.

Aug 31 2022, 11:49 AM
anlambert requested review of D8354: pubdev: Modify origin URL and retrieve package last update.
Aug 31 2022, 11:43 AM
anlambert requested review of D8355: pubdev: Modify loader after origin URL modification in related lister.
Aug 31 2022, 11:42 AM
anlambert closed D8349: misc/banners: Move feature into its own django application.
Aug 31 2022, 11:39 AM
anlambert committed rDWAPPSce5c9159933f: misc/banners: Move feature into its own django application (authored by anlambert).
misc/banners: Move feature into its own django application
Aug 31 2022, 11:39 AM
anlambert added a revision to T4465: Ingest pub.dev (Dart, Flutter): D8355: pubdev: Modify loader after origin URL modification in related lister.
Aug 31 2022, 11:38 AM · PubDev loader, PubDev lister, Archive coverage
anlambert added a revision to T4465: Ingest pub.dev (Dart, Flutter): D8354: pubdev: Modify origin URL and retrieve package last update.
Aug 31 2022, 11:38 AM · PubDev loader, PubDev lister, Archive coverage

Aug 30 2022

anlambert requested review of D8349: misc/banners: Move feature into its own django application.
Aug 30 2022, 5:26 PM
anlambert added a revision to T4398: Create one django application for each webapp feature: D8349: misc/banners: Move feature into its own django application.
Aug 30 2022, 5:10 PM · Web app
anlambert committed rDWAPPS37e9a300cdcb: package.json: Update dependencies (authored by anlambert).
package.json: Update dependencies
Aug 30 2022, 4:50 PM
anlambert committed rDWAPPS7ebb1ee020fe: metrics: Move test_app.py file in related tests folder (authored by anlambert).
metrics: Move test_app.py file in related tests folder
Aug 30 2022, 4:50 PM
anlambert committed rDWAPPS8cb3a8154ee0: archive_coverage: Update iframe CSS class renamed in a7ab8afb1951 (authored by anlambert).
archive_coverage: Update iframe CSS class renamed in a7ab8afb1951
Aug 30 2022, 4:50 PM
anlambert closed D8347: postgresql: Fix SQL query for origin_find_visit_by_date method.
Aug 30 2022, 3:12 PM
anlambert committed rDSTOd038240ce71e: postgresql: Fix SQL query for origin_find_visit_by_date method (authored by anlambert).
postgresql: Fix SQL query for origin_find_visit_by_date method
Aug 30 2022, 3:12 PM
anlambert requested review of D8347: postgresql: Fix SQL query for origin_find_visit_by_date method.
Aug 30 2022, 3:00 PM
anlambert created P1437 (An Untitled Masterwork).
Aug 30 2022, 2:06 PM
anlambert closed D8342: Remove empty api_data.py file in root directory.
Aug 30 2022, 12:31 PM
anlambert committed rDWCLIa25482bef10c: Remove empty api_data.py file in root directory (authored by anlambert).
Remove empty api_data.py file in root directory
Aug 30 2022, 12:31 PM
anlambert accepted D8296: Golang module loader.

LGTM

Aug 30 2022, 12:31 PM
anlambert accepted D8298: Add incremental function to Golang Lister.

LGTM

Aug 30 2022, 12:30 PM
anlambert accepted D7329: Non-incremental Golang module lister.

Looks good to me, thanks !

Aug 30 2022, 12:30 PM · Lister
anlambert requested review of D8342: Remove empty api_data.py file in root directory.
Aug 30 2022, 11:52 AM
anlambert closed D8337: misc/metrics: Move feature into its own django application.
Aug 30 2022, 11:42 AM
anlambert committed rDWAPPSa77e5ab36cae: misc/metrics: Move feature into its own django application (authored by anlambert).
misc/metrics: Move feature into its own django application
Aug 30 2022, 11:42 AM
anlambert requested review of D8337: misc/metrics: Move feature into its own django application.
Aug 30 2022, 11:18 AM
anlambert accepted D8340: metadata: Drop unsupported key 'type'.
Aug 30 2022, 10:42 AM

Aug 29 2022

anlambert added a revision to T4398: Create one django application for each webapp feature: D8337: misc/metrics: Move feature into its own django application.
Aug 29 2022, 5:33 PM · Web app
anlambert committed rDWAPPS61b575db215d: sqlite: Use multiple database files when running parallel cypress tests (authored by anlambert).
sqlite: Use multiple database files when running parallel cypress tests
Aug 29 2022, 5:07 PM
anlambert committed rDWAPPScb03344f8a58: package.json: Add cy2 development dependency (authored by anlambert).
package.json: Add cy2 development dependency
Aug 29 2022, 5:07 PM
anlambert committed rDWAPPS3adcbde7f785: cypress/admin: Add missing intercept in test implementation (authored by anlambert).
cypress/admin: Add missing intercept in test implementation
Aug 29 2022, 5:07 PM
anlambert committed rDWAPPS4a8de541123b: cypress.config.js: Add projectId (authored by anlambert).
cypress.config.js: Add projectId
Aug 29 2022, 5:07 PM
anlambert committed rDWAPPSb7be6a88dce7: cypress/origin-save: Add wait instructions to fix flaky tests (authored by anlambert).
cypress/origin-save: Add wait instructions to fix flaky tests
Aug 29 2022, 5:07 PM
anlambert closed D8326: Modify some configuration to allow running cypress tests in parallel.
Aug 29 2022, 5:07 PM
anlambert committed rDWAPPS4b83f99981a4: cypress/add-forge-now-request-create: Add missing wait instructions (authored by anlambert).
cypress/add-forge-now-request-create: Add missing wait instructions
Aug 29 2022, 5:07 PM
anlambert added inline comments to D8298: Add incremental function to Golang Lister.
Aug 29 2022, 3:20 PM
anlambert planned changes to D8328: templates/cypress: Run tests in parallel using sorry-cypress.

Based on my tests on our Jenkins instance, swh-web build jobs with the changes in that diff become unstable when there is more
than three jobs executed in parallel (as there is a lot of cypress processes consuming a lot of resources on the Jenkins node).

Aug 29 2022, 11:46 AM

Aug 26 2022

anlambert requested review of D8326: Modify some configuration to allow running cypress tests in parallel.
Aug 26 2022, 5:36 PM
anlambert requested review of D8328: templates/cypress: Run tests in parallel using sorry-cypress.
Aug 26 2022, 5:28 PM
anlambert added a revision to T3423: Execute cypress tests in parallel on Jenkins: D8328: templates/cypress: Run tests in parallel using sorry-cypress.
Aug 26 2022, 5:28 PM · Continuous Integration, Web app
anlambert added a revision to T3423: Execute cypress tests in parallel on Jenkins: D8326: Modify some configuration to allow running cypress tests in parallel.
Aug 26 2022, 5:20 PM · Continuous Integration, Web app
anlambert committed rCJSWH9ac7737a8b45: jobs/templates/swh-pipeline: Fix indentation level (authored by anlambert).
jobs/templates/swh-pipeline: Fix indentation level
Aug 26 2022, 4:53 PM
anlambert added a comment to T3423: Execute cypress tests in parallel on Jenkins.

After some hacks on the current Jenkins pipeline for swh-web to test if it was feasible, I managed to setup the use of sorry-cypress but could not run multiple cypress in parallel as Jenkins pipelines forbid nested parallel stages.
So this would require setting up a dedicated pipeline build job for cypress tests as currently Python and cypress tests are executed in parallel in a single job.

Aug 26 2022, 3:01 PM · Continuous Integration, Web app
anlambert added inline comments to D8310: Add revision log field in the revision type.
Aug 26 2022, 2:39 PM

Aug 25 2022

anlambert closed D8317: misc/coverage: Move feature into its own django application.
Aug 25 2022, 7:40 PM
anlambert committed rDWAPPSa7ab8afb1951: misc/coverage: Move feature into its own django application (authored by anlambert).
misc/coverage: Move feature into its own django application
Aug 25 2022, 7:40 PM
anlambert added a comment to D8314: add a documentation landing page.

For the record, that new doc is not build by our CI, apply this patch to do it.

diff --git a/tox.ini b/tox.ini
index 3e768bf..52f8678 100644
--- a/tox.ini
+++ b/tox.ini
@@ -16,6 +16,7 @@ setenv =
 commands =
   {envpython} -m pifpaf run postgresql -- make -C sysadm {posargs:html}
   {envpython} -m pifpaf run postgresql -- make -C user {posargs:html}
+  {envpython} -m pifpaf run postgresql -- make -C general {posargs:html}
   {envpython} -m pifpaf run postgresql -- make -C docs {posargs:html}
Aug 25 2022, 5:47 PM
anlambert added a comment to D8314: add a documentation landing page.

Why duplicating loader/lister logos ? I do not get its purpose.

Aug 25 2022, 5:44 PM
anlambert updated the diff for D8317: misc/coverage: Move feature into its own django application.

Fix docstring

Aug 25 2022, 5:42 PM
anlambert added inline comments to D8317: misc/coverage: Move feature into its own django application.
Aug 25 2022, 5:38 PM
anlambert requested review of D8317: misc/coverage: Move feature into its own django application.
Aug 25 2022, 5:19 PM
anlambert added a revision to T4398: Create one django application for each webapp feature: D8317: misc/coverage: Move feature into its own django application.
Aug 25 2022, 5:03 PM · Web app
anlambert requested changes to D8296: Golang module loader.

I found another issue when trying to run the loader in our docker env, see inline comment.

Aug 25 2022, 4:34 PM
anlambert requested changes to D7329: Non-incremental Golang module lister.

I found an issue when testing the lister in our docker environment, see inline comment.

Aug 25 2022, 4:30 PM · Lister
anlambert requested changes to D8298: Add incremental function to Golang Lister.

Please add an incremental parameter to the lister in order to be able to perform a full relisting of go packages if it is set to False
(other listers with incremental feature proceed like this).

Aug 25 2022, 3:58 PM
anlambert added inline comments to D8298: Add incremental function to Golang Lister.
Aug 25 2022, 11:39 AM
anlambert added inline comments to D8298: Add incremental function to Golang Lister.
Aug 25 2022, 11:18 AM

Aug 24 2022

anlambert committed rDWAPPS1f17548cd043: nyc.config.js: Also set custom value for temp-dir option (authored by anlambert).
nyc.config.js: Also set custom value for temp-dir option
Aug 24 2022, 8:13 PM
anlambert closed D8291: docs/Makefile: Fix local build of global swh documentation.
Aug 24 2022, 6:03 PM
anlambert committed rDDOC79efac6b306d: docs/Makefile: Fix local build of global swh documentation (authored by anlambert).
docs/Makefile: Fix local build of global swh documentation
Aug 24 2022, 6:03 PM
anlambert updated the diff for D8291: docs/Makefile: Fix local build of global swh documentation.

Rebase

Aug 24 2022, 5:59 PM
anlambert committed rDWAPPS87030b2a5437: nyc: Use dynamic js config instead of static one in package.json (authored by anlambert).
nyc: Use dynamic js config instead of static one in package.json
Aug 24 2022, 4:34 PM
anlambert closed D8297: misc/badges: Move feature into a dedicated django application.
Aug 24 2022, 3:30 PM
anlambert committed rDWAPPSc24f1a764af6: misc/badges: Move feature into a dedicated django application (authored by anlambert).
misc/badges: Move feature into a dedicated django application
Aug 24 2022, 3:30 PM
anlambert added inline comments to D8297: misc/badges: Move feature into a dedicated django application.
Aug 24 2022, 3:11 PM
anlambert requested review of D8297: misc/badges: Move feature into a dedicated django application.
Aug 24 2022, 2:46 PM
anlambert abandoned D8306: sqlite: Create swh-web database in /tmp when running cypress tests.

No significant speedup when running tests, abandoning this.

Aug 24 2022, 2:09 PM
anlambert updated the diff for D8306: sqlite: Create swh-web database in /tmp when running cypress tests.

Not really conclusive, trying with /dev/shm/.

Aug 24 2022, 1:56 PM
anlambert requested review of D8306: sqlite: Create swh-web database in /tmp when running cypress tests.
Aug 24 2022, 1:55 PM
anlambert closed D8300: sqlite: Try to mitigate locked database when running cypress tests.
Aug 24 2022, 12:11 PM
anlambert committed rDWAPPSddcfa6ce48c1: sqlite: Prevent locked database errors when running cypress tests (authored by anlambert).
sqlite: Prevent locked database errors when running cypress tests
Aug 24 2022, 12:11 PM
anlambert updated the diff for D8300: sqlite: Try to mitigate locked database when running cypress tests.

Add comments and remove timeout config

Aug 24 2022, 12:00 PM
anlambert updated the diff for D8300: sqlite: Try to mitigate locked database when running cypress tests.

Yrying sqlite WAL journal approach.

Aug 24 2022, 11:45 AM
anlambert retitled D8300: sqlite: Try to mitigate locked database when running cypress tests from sqlite: Try to mitigate locked database when running tests in parallel to sqlite: Try to mitigate locked database when running cypress tests.
Aug 24 2022, 11:44 AM
anlambert added a comment to D8300: sqlite: Try to mitigate locked database when running cypress tests.

Actually, what about changing the DB path, so both tests instances don't use the same? :memory: might even work

Aug 24 2022, 11:36 AM

Aug 23 2022

anlambert requested review of D8300: sqlite: Try to mitigate locked database when running cypress tests.
Aug 23 2022, 7:38 PM
anlambert closed D8299: assets/add_forge: Improve datatables rendering.
Aug 23 2022, 6:53 PM
anlambert committed rDWAPPS8496d6a55141: assets/add_forge: Improve datatables rendering (authored by anlambert).
assets/add_forge: Improve datatables rendering
Aug 23 2022, 6:53 PM
anlambert requested review of D8299: assets/add_forge: Improve datatables rendering.
Aug 23 2022, 5:25 PM
anlambert closed D8295: misc: Move SWHID iframe view in browse django application.
Aug 23 2022, 4:51 PM
anlambert committed rDWAPPS007c9c782df9: misc: Move SWHID iframe view in browse django application (authored by anlambert).
misc: Move SWHID iframe view in browse django application
Aug 23 2022, 4:51 PM
anlambert closed D8294: browse: Move related templates into dedicated django application.
Aug 23 2022, 4:51 PM
anlambert committed rDWAPPS4b1ee0509861: browse: Move related templates into dedicated django application (authored by anlambert).
browse: Move related templates into dedicated django application
Aug 23 2022, 4:51 PM
anlambert requested review of D8295: misc: Move SWHID iframe view in browse django application.
Aug 23 2022, 4:17 PM
anlambert requested review of D8294: browse: Move related templates into dedicated django application.
Aug 23 2022, 4:16 PM
anlambert added a revision to T4398: Create one django application for each webapp feature: D8294: browse: Move related templates into dedicated django application.
Aug 23 2022, 3:59 PM · Web app
anlambert requested review of D8291: docs/Makefile: Fix local build of global swh documentation.
Aug 23 2022, 3:05 PM
anlambert accepted D8258: Split endpoint table into categories.

Looks good to me, thanks !

Aug 23 2022, 2:38 PM
anlambert accepted D8292: gogs: Lower unnecessarily verbose logging statement.
Aug 23 2022, 2:00 PM
anlambert accepted D8293: arch: Use lazy interpolation in logging statements.
Aug 23 2022, 2:00 PM
anlambert accepted D8289: gitea: Inherit from Gogs lister.

Looks good to me.

Aug 23 2022, 1:59 PM
anlambert committed rDWAPPScb2f35021f60: auth/utils: Fix circular import triggered by sphinx autodoc (authored by anlambert).
auth/utils: Fix circular import triggered by sphinx autodoc
Aug 23 2022, 1:13 PM
anlambert closed D8290: auth/utils: Fix circular import triggered by sphinx autodoc.
Aug 23 2022, 1:13 PM