It only depends on swh.web.browse which is a base django application
always activated so it can be moved into its own django application.
Details
- Reviewers
jayeshv - Group Reviewers
Reviewers - Commits
- rDWAPPSc24f1a764af6: misc/badges: Move feature into a dedicated django application
Diff Detail
- Repository
- rDWAPPS Web applications
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
Build was aborted
Patch application report for D8297 (id=29958)
Rebasing onto 007c9c782d...
Current branch diff-target is up to date.
Changes applied before test
commit 5a86b2fb0fafba99908e2e0b2c96f53959273f26 Author: Antoine Lambert <anlambert@softwareheritage.org> Date: Tue Aug 23 16:46:47 2022 +0200 misc/badges: Move feature into a dedicated django application It only depends on swh.web.browse which is a base django application always activated so it can be moved into its own django application.
Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1998/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1998/console
Build has FAILED
Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/2000/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/2000/console
Build has FAILED
Patch application report for D8297 (id=29965)
Rebasing onto 8496d6a551...
Current branch diff-target is up to date.
Changes applied before test
commit 074c55efb8eca262f79203c53f6b20935a92df06 Author: Antoine Lambert <anlambert@softwareheritage.org> Date: Tue Aug 23 16:46:47 2022 +0200 misc/badges: Move feature into a dedicated django application It only depends on swh.web.browse which is a base django application always activated so it can be moved into its own django application.
Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/2001/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/2001/console
Build is green
Patch application report for D8297 (id=29985)
Rebasing onto ddcfa6ce48...
Current branch diff-target is up to date.
Changes applied before test
commit c24f1a764af63a5fbb6abbfc8b66e100cc1e6f20 Author: Antoine Lambert <anlambert@softwareheritage.org> Date: Tue Aug 23 16:46:47 2022 +0200 misc/badges: Move feature into a dedicated django application It only depends on swh.web.browse which is a base django application always activated so it can be moved into its own django application.
See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/2012/ for more details.
swh/web/browse/templates/includes/show-swhids.html | ||
---|---|---|
65 | This check is to enable and disable support for badges, correct?. Will the /badge/<swhid> URL throw a 404 if the app is missing? |
swh/web/browse/templates/includes/show-swhids.html | ||
---|---|---|
65 | Yes of course, see test_badges_deactivate below. |