In D7534#196906, @ardumont wrote:

That's true for the pypi code (hence tests here) but what about production (oldstable)? [1]

An acceptable answer i guess is "it's not used in production" (it's possible ;).

[1]

$ rmadison python3-werkzeug
python3-werkzeug | 0.9.6+dfsg-1+deb8u1    | oldoldoldstable | all
python3-werkzeug | 0.11.15+dfsg1-1+deb9u1 | oldoldstable    | all
python3-werkzeug | 0.14.1+dfsg1-4+deb10u1 | oldstable       | all
python3-werkzeug | 1.0.1+dfsg1-2          | stable          | all
python3-werkzeug | 2.0.2+dfsg1-1          | testing         | all
python3-werkzeug | 2.0.2+dfsg1-1          | unstable        | all

Update: Use django_cache decorator

Address @vlorentz comment

Rebase

Build failure is expected here, see T4119.

Update diff to same content as I hard resetted my master branch by mistake.

Are E203, E231 and W503 still needed with the most recent black style?

My attempts at configuring bugbear focused on the (recent-ish, flake8 4.x) extend-ignore and extend-select options, to avoid having to repeat the default settings for them. I guess they interact poorly with the way bugbear hooks into flake8.

Considering that we'll have to poke at that config everywhere anyway the next time we upgrade flake8, we may as well do it that way...

Based on the discussion following D7502#196088, I came up with the following script to execute in swh-environment in order to :

• upgrade black in all swh repos and use flake8-bugbear for the line length warnings
• reformat Python code with latest black version
• add .git-blame-ignore-revs file to ignore reformatting commits
• run flake8 after all these changes to check everything is OK

Great, thanks !

Fine with me too.

Instead of running black swh, I would suggest using pre-commit run -a black to make sure the proper version is used, and all affected files are properly reformatted (we have some python files not in the swh directory).

Rebase

So I made some tests today to fix the infinite reloading of the webapp in browser when overriding swh-web sources and when the source directory is writable.
Turns out the issue was coming from the use of webpack loader cache as we use production settings for the webapp in docker env.
Unfortunately, it clashes with the use of webpack-dev-server so the infinite reload.
The use of webpack-dev-server in docker was originally working as I forced the use of dev settings in that case but
it was reverted in rDENV6c4f3c5f41fc5a4f1f96b92d006cfcf82e6cffee.
Fortunately, I found a workaround to restore webpack-dev-server use (D7505).

@vlorentz, the following patch makes the deposits cypress tests stable.

Any actions required in this task?

Looks like it is time to upgrade black in all swh modules as black 19.10b0 is incompatible with click 8.1.x.

Granted for landing, thanks !

One last thing before we can land this:

• please squash commits into a single one if its is not already done and use the following message:

add_forge_now: Add hyperlinks to forge URLs in Browse Requests tab

Still one change required before I can accept the diff (see inline comment).

Looks good to me. Please add your name in the CONTRIBUTORS file at the root of the repository and I will accept the diff.

Thanks for your contribution. I have added some inline comments to handle before we can land this.