Differential D7530

misc/coverage: Bump cache timeout from 5 minutes to 1 hour
ClosedPublic
Actions

Authored by anlambert on Apr 8 2022, 11:25 AM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Commits

rDWAPPSd35ba5194f10: misc/coverage: Bump cache timeout from 5 minutes to 1 hour

Summary

Updating origin type counters in coverage widget every hour seems
more reasonable that doing it every 5 minutes as the underlying
database requests are pretty costly.

Diff Detail

Repository

rDWAPPS Web applications

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

anlambert created this revision.Apr 8 2022, 11:25 AM

Herald added a reviewer: Reviewers. · View Herald TranscriptApr 8 2022, 11:25 AM

Build has FAILED

Patch application report for D7530 (id=27316)

Rebasing onto bdee9fe46e...

Current branch diff-target is up to date.

Changes applied before test

commit d35ba5194f107f8fcf59ac85b16d5db7c7dcd3ae
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Fri Apr 8 11:21:11 2022 +0200

    misc/coverage: Bump cache timeout from 5 minutes to 1 hour
    
    Updating origin type counters in coverage widget every hour seems
    more reasonable that doing it every 5 minutes as the underlying
    database requests are pretty costly.

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1698/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1698/console

Harbormaster returned this revision to the author for changes because remote builds failed.Apr 8 2022, 11:27 AM

Harbormaster failed remote builds in B28247: Diff 27316!

Build is green

Patch application report for D7530 (id=27316)

Rebasing onto bdee9fe46e...

Current branch diff-target is up to date.

Changes applied before test

commit d35ba5194f107f8fcf59ac85b16d5db7c7dcd3ae
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Fri Apr 8 11:21:11 2022 +0200

    misc/coverage: Bump cache timeout from 5 minutes to 1 hour
    
    Updating origin type counters in coverage widget every hour seems
    more reasonable that doing it every 5 minutes as the underlying
    database requests are pretty costly.

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1699/ for more details.

Harbormaster completed remote builds in B28247: Diff 27316.Apr 8 2022, 11:56 AM

anlambert requested review of this revision.Apr 8 2022, 11:56 AM

ardumont accepted this revision.Apr 8 2022, 12:18 PM

This revision is now accepted and ready to land.Apr 8 2022, 12:18 PM

Closed by commit rDWAPPSd35ba5194f10: misc/coverage: Bump cache timeout from 5 minutes to 1 hour (authored by anlambert). · Explain WhyApr 8 2022, 1:30 PM

This revision was automatically updated to reflect the committed changes.

anlambert added a commit: rDWAPPSd35ba5194f10: misc/coverage: Bump cache timeout from 5 minutes to 1 hour.