requirements-test: Remove pytest pinning to < 7
ClosedPublic
Actions

Authored by anlambert on Apr 6 2022, 5:07 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Commits

rDCORE7be2dbf02d06: requirements-test: Remove pytest pinning to < 7

Summary

pytest-postgresql 3.1.3 and pytest-redis 2.4.0 added support for pytest >= 7 so we can now drop the pytest pinning.

We also need to remove that pinning in all swh modules, using mr run sed -i 's/^pytest <.*$/pytest/' requirements-test.txt will do the trick.

Diff Detail

Repository

rDCORE Foundations and core functionalities

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

anlambert created this revision.Apr 6 2022, 5:07 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptApr 6 2022, 5:07 PM

anlambert added inline comments.Apr 6 2022, 5:08 PM

swh/core/pytest_plugin.py
137–140	This is needed because we are using `pytest 6.2.5` when building debian packages.

Build is green

Patch application report for D7515 (id=27262)

Rebasing onto 2a2615357b...

Current branch diff-target is up to date.

Changes applied before test

commit 7be2dbf02d06f7127eae9a3a44cc496b86a8e6d3
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Wed Apr 6 17:06:11 2022 +0200

    requirements-test: Remove pytest pinning to < 7
    
    pytest-postgresql 3.1.3 and pytest-redis 2.4.0 added support for
    pytest >= 7 so we can now drop the pytest pinning.

See https://jenkins.softwareheritage.org/job/DCORE/job/tests-on-diff/384/ for more details.

Harbormaster completed remote builds in B28166: Diff 27262.Apr 6 2022, 5:09 PM

anlambert requested review of this revision.Apr 6 2022, 5:09 PM

anlambert edited the summary of this revision. (Show Details)Apr 6 2022, 5:09 PM

anlambert edited the summary of this revision. (Show Details)

ardumont accepted this revision.Apr 6 2022, 5:27 PM

This revision is now accepted and ready to land.Apr 6 2022, 5:27 PM

Closed by commit rDCORE7be2dbf02d06: requirements-test: Remove pytest pinning to < 7 (authored by anlambert). · Explain WhyApr 6 2022, 5:50 PM

This revision was automatically updated to reflect the committed changes.

anlambert added a commit: rDCORE7be2dbf02d06: requirements-test: Remove pytest pinning to < 7.