Differential D7526

common/utils: Add a django_cache decorator and use it in codebase
ClosedPublic
Actions

Authored by anlambert on Apr 7 2022, 5:18 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Commits

rDWAPPSb364c93d81a6: common/utils: Add a django_cache decorator and use it in codebase

Summary

Add a decorator enabling to put the result of a function call in Django
cache, subsequent calls will then directly return the cached value.

Use that decorator whenever it is possible in swh-web codebase to simplify
the handling of cached values and improve code readability.

Diff Detail

Repository

rDWAPPS Web applications

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

anlambert created this revision.Apr 7 2022, 5:18 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptApr 7 2022, 5:18 PM

anlambert added a child revision: D7521: common/utils: Use cache in origin_visit_types function.Apr 7 2022, 5:18 PM

Build is green

Patch application report for D7526 (id=27304)

Rebasing onto 96b27bf43e...

Current branch diff-target is up to date.

Changes applied before test

commit b364c93d81a6286c238336aa102b7ba2a55b5d66
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Thu Apr 7 16:59:06 2022 +0200

    common/utils: Add a django_cache decorator and use it in codebase
    
    Add a decorator enabling to put the result of a function call in Django
    cache, subsequent calls will then directly return the cached value.
    
    Use that decorator whenever it is possible in swh-web codebase to simplify
    the handling of cached values and improve code readability.

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1696/ for more details.

Harbormaster completed remote builds in B28234: Diff 27304.Apr 7 2022, 5:37 PM

anlambert requested review of this revision.Apr 7 2022, 5:37 PM

ardumont accepted this revision.Apr 8 2022, 11:13 AM

This revision is now accepted and ready to land.Apr 8 2022, 11:13 AM

ardumont mentioned this in D7521: common/utils: Use cache in origin_visit_types function.Apr 8 2022, 11:13 AM

Closed by commit rDWAPPSb364c93d81a6: common/utils: Add a django_cache decorator and use it in codebase (authored by anlambert). · Explain WhyApr 8 2022, 11:25 AM

This revision was automatically updated to reflect the committed changes.

anlambert added a commit: rDWAPPSb364c93d81a6: common/utils: Add a django_cache decorator and use it in codebase.